From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2842CC3064D for ; Thu, 27 Jun 2024 11:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ws2lsZTC4SU5kzgJgq1om4TLcklNOCM4NOTY4dQ7f/c=; b=CMuIIOp9D0DGed 59j0eU7oc6bNvk/RvCEEWLxBB3svIXBTP82cVs6jqsA3PDxidLt35KZoMmhXPQ5M+C0CP886WjXoC fEAIcymeMFQ1KwbLqRwj2Rg2UOMNtvdU989k3bLreb8djnks9PPeHCmu036xiXePss1DdD8vtr1oW 5Rr/6a5dENqj+DgV5k5YkLQ21jWHJxFSwM3bgf1PJAz9Pl2R8OmbWYINjBWQab8e+VXI3nC2OjrXH Kh1r5dEgQCeUljmg8TCFBNdML7qUC+B2RdhS9nwgzq2e+U+mV8TBaz5YeX+jhaozjO+wfoS7KYVfJ PfYhoCrSyMhvKFd6f70Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMn1v-0000000A6bw-181y; Thu, 27 Jun 2024 11:11:07 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMn1Z-0000000A6W4-0y2e; Thu, 27 Jun 2024 11:10:54 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-57d26a4ee65so1354324a12.2; Thu, 27 Jun 2024 04:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719486641; x=1720091441; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RjG4NvLPZHP15XSF73Un+NgkQkULbEPKorgzxgkPLfo=; b=TJWc1E7aM4tjIa5XaKEghZuBEmpWevBc0/XssDla4mBA6BAzc743Lltacimf6JIjoA Ei/11RofSEhRM77CJbEXAqVpUcsUxeOFT0kJcAeLgMSnjjNAyd6MOpVmJ7mn+kfOTtDU V2pupoZJzUVzry7YSda485geMpOxxsYX9m8mMe1AAXcA7QQNQeenikFA7AQyFZaOtzeM 7A68oMvZYwoqn/iPSDNwhjazjJM9P+xTkWhuaz5Z1/utWicrBYnSCuFk6F92HPMyO5nI jPt0pJWmGEj3x1Rj+1k6UMyEZ6DiudU0qCiFb9F+yumpPesYS6ZSG6oHx3v2xuhg/4/d KS0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719486641; x=1720091441; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RjG4NvLPZHP15XSF73Un+NgkQkULbEPKorgzxgkPLfo=; b=UpfvrNC2qn71CGGA8vu8Y2VwoS2hw4fs4hXgKSfut2xiGiKsVZAR2AVJOTkVZRIEne CCjb8xqzubTJS2xWDg6Qb+ax4jN9u8KCfaqFeCYQQaLt+ZMt8XpqaJyXVInNLwG7sxri HQZHUVgH4MrqMaMI0c5PJuLfEpIFBMdbVZ7B69YMvl7DNJVKlg6Kpls089MJDqD5f8Om g0CohWVk+cI/KTl/ePlkr+kUqHTG7tOZM/qKq6DHvl+SshOH4ROz6KkKY2nozbnQct5B mW0RJ8hawPdQ75b705G0ZIXYSPq/7I+VFLPIsTQuWLR93rMR3ck9I9nNvgVO16Me7kqI EjEQ== X-Forwarded-Encrypted: i=1; AJvYcCWMnx5nrRuffRtejjLzAOHjWSrLFrtzpljOTXKlvfbw0QaJvjuSDgFBZSeHfTptOEsXBVrsiPaVp8/6Wnc+zRmuDkOZNIWZGQn3tIXdcuyQfiZ6fcTJYlqwNFco1BISyARZ+OWvN6QZ2cOyFYyrAP5ounmJE5wsTr0= X-Gm-Message-State: AOJu0Yzxy/7GmIlnLUiZ2c9/RNErh69SuaxLCwwOU6fbHjaIq4LqBnQz mad0OmsFpj7yi0MP6Mz5kL+s3E+W1xHgQBvpZK814ILajrak5rU= X-Google-Smtp-Source: AGHT+IH4fbvY1cFOwHHzrwt3dVlavsf75UZvpMeelUbWWYiwXGXJ5CcSyvDpzggFY+YcW3P4/NbQ2g== X-Received: by 2002:a05:6402:520c:b0:582:1f66:1472 with SMTP id 4fb4d7f45d1cf-5821f661646mr6043539a12.31.1719486640245; Thu, 27 Jun 2024 04:10:40 -0700 (PDT) Received: from ?IPV6:2a02:810b:f40:4600:2023:48bf:6b4:88a4? ([2a02:810b:f40:4600:2023:48bf:6b4:88a4]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-584d16bbf1csm733229a12.44.2024.06.27.04.10.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jun 2024 04:10:39 -0700 (PDT) Message-ID: Date: Thu, 27 Jun 2024 13:10:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] media: rockchip: Introduce the rkvdec2 driver To: Jonas Karlman , Detlev Casanova Cc: Ezequiel Garcia , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Greg Kroah-Hartman , Sebastian Reichel , Dragan Simic , Diederik de Haas , Andy Yan , Boris Brezillon , Hans Verkuil , Daniel Almeida , Paul Kocialkowski , Nicolas Dufresne , Benjamin Gaignard , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20240620142532.406564-1-detlev.casanova@collabora.com> <20240620142532.406564-3-detlev.casanova@collabora.com> <3815203.kQq0lBPeGt@arisu> <5a15b138-4e03-4487-8a53-b7ff3527701f@gmail.com> <66e56996-4b56-4262-973f-672121071391@kwiboo.se> Content-Language: en-US From: Alex Bee In-Reply-To: <66e56996-4b56-4262-973f-672121071391@kwiboo.se> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_041045_332374_E67E551C X-CRM114-Status: GOOD ( 33.23 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org CkFtIDI3LjA2LjI0IHVtIDExOjQxIHNjaHJpZWIgSm9uYXMgS2FybG1hbjoKPiBIaSBBbGV4LAo+ Cj4gT24gMjAyNC0wNi0yNiAxMToxMiwgQWxleCBCZWUgd3JvdGU6Cj4+IEhpIERldGxldiwKPj4K Pj4gQW0gMjUuMDYuMjQgdW0gMTg6NTYgc2NocmllYiBEZXRsZXYgQ2FzYW5vdmE6Cj4+PiBIaSBB bGV4LAo+Pj4KPj4+IE9uIFN1bmRheSwgSnVuZSAyMywgMjAyNCA1OjMzOjI4IEEuTS4gRURUIHlv dSB3cm90ZToKPj4+PiBIaSBEZXRsZXYsCj4+Pj4KPj4+PiBBbSAyMC4wNi4yNCB1bSAxNjoxOSBz Y2hyaWViIERldGxldiBDYXNhbm92YToKPj4+Pj4gVGhpcyBkcml2ZXIgc3VwcG9ydHMgdGhlIHNl Y29uZCBnZW5lcmF0aW9uIG9mIHRoZSBSb2NrY2hpcCBWaWRlbwo+Pj4+PiBkZWNvZGVyLCBhbHNv IGtub3duIGFzIHZkcHUzNHguCj4+Pj4+IEl0IGlzIGN1cnJlbnRseSBvbmx5IHVzZWQgb24gdGhl IFJLMzU4OChzKSBTb0MuCj4+Pj4+Cj4+Pj4+IFRoZXJlIGFyZSAyIGRlY29kZXJzIG9uIHRoZSBS SzM1ODggU29DIHRoYXQgY2FuIHdvcmsgaW4gcGFpciB0byBkZWNvZGUKPj4+Pj4gOEsgdmlkZW8g YXQgMzAgRlBTIGJ1dCBjdXJyZW50bHksIG9ubHkgdXNpbmcgb25lIGNvcmUgYXQgYSB0aW1lIGlz Cj4+Pj4+IHN1cHBvcnRlZC4KPj4+Pj4KPj4+Pj4gU2NoZWR1bGluZyByZXF1ZXN0cyBiZXR3ZWVu IHRoZSB0d28gY29yZXMgd2lsbCBiZSBpbXBsZW1lbnRlZCBsYXRlci4KPj4+Pj4KPj4+Pj4gVGhl IGNvcmUgc3VwcG9ydHMgSDI2NCwgSEVWQywgVlA5IGFuZCBBVlMyIGRlY29kaW5nIGJ1dCB0aGlz IGRyaXZlcgo+Pj4+PiBjdXJyZW50bHkgb25seSBzdXBwb3J0cyBIMjY0Lgo+Pj4+Pgo+Pj4+PiBU aGUgZHJpdmVyIGlzIGJhc2VkIG9uIHJrdmRlYyBhbmQgdGhleSBtYXkgc2hhcmUgc29tZSBjb2Rl IGluIHRoZQo+Pj4+PiBmdXR1cmUuCj4+Pj4+IFRoZSBkZWNpc2lvbiB0byBtYWtlIGEgZGlmZmVy ZW50IGRyaXZlciBpcyBtYWlubHkgYmVjYXVzZSBya3ZkZWMyIGhhcwo+Pj4+PiBtb3JlIGZlYXR1 cmVzIGFuZCBjYW4gd29yayB3aXRoIG11bHRpcGxlIGNvcmVzLgo+Pj4+Pgo+Pj4+PiBUaGUgcmVn aXN0ZXJzIGFyZSBtYXBwZWQgaW4gYSBzdHJ1Y3QgaW4gUkFNIHVzaW5nIGJpdGZpZWxkcy4gSXQg aXMgSU8KPj4+Pj4gY29waWVkIHRvIHRoZSBIVyB3aGVuIGFsbCB2YWx1ZXMgYXJlIGNvbmZpZ3Vy ZWQuCj4+Pj4+IFRoZSBkZWNpc2lvbiB0byB1c2Ugc3VjaCBhIHN0cnVjdCBpbnN0ZWFkIG9mIHdy aXRpbmcgYnVmZmVycyBvbmUgYnkgb25lCj4+Pj4+Cj4+Pj4+IGlzIGJhc2VkIG9uIHRoZSBmb2xs b3dpbmcgcmVhc29uczoKPj4+Pj4gICAgIC0gUm9ja2NoaXAgY29yZXMgYXJlIGtub3duIHRvIG1p c2JlaGF2ZSB3aGVuIHJlZ2lzdGVycyBhcmUgbm90IHdyaXR0ZW4KPj4+Pj4gICAgIAo+Pj4+PiAg ICAgICBpbiBhZGRyZXNzIG9yZGVyLAo+Pj4+PiAgICAgCj4+Pj4+ICAgICAtIFRob3NlIGNvcmVz IGFsc28gbmVlZCB0aGUgc29mdHdhcmUgdG8gd3JpdGUgYWxsIHJlZ2lzdGVycywgZXZlbiBpZgo+ Pj4+PiAgICAgCj4+Pj4+ICAgICAgIHRoZXkgYXJlIHdyaXR0ZW4gdGhlaXIgZGVmYXVsdCB2YWx1 ZXMgb3IgYXJlIG5vdCByZWxhdGVkIHRvIHRoZSB0YXNrCj4+Pj4+ICAgICAgICh0aGlzIGNvcmUg d2lsbCBub3Qgc3RhcnQgZGVjb2Rpbmcgc29tZSBIMjY0IGZyYW1lcyBpZiBzb21lIFZQOQo+Pj4+ PiAgICAgICByZWdpc3RlcnMgYXJlIG5vdCB3cml0dGVuIHRvIDApCj4+Pj4+ICAgICAKPj4+Pj4g ICAgIC0gSW4gdGhlIGZ1dHVyZSwgdG8gc3VwcG9ydCBtdWx0aXBsZSBjb3JlcywgdGhlIHNjaGVk dWxlciBjb3VsZCBiZQo+Pj4+PiAgICAgCj4+Pj4+ICAgICAgIG9wdGltaXplZCBieSBzdG9yaW5n IHRoZSBwcmVjb21wdXRlZCByZWdpc3RlcnMgdmFsdWVzIGFuZCBjb3B5IHRoZW0KPj4+Pj4gICAg ICAgdG8gdGhlIEhXIGFzIHNvb3MgYXMgYSBjb3JlIGJlY29tZXMgYXZhaWxhYmxlLgo+Pj4+Pgo+ Pj4+PiBUaGlzIG1ha2VzIHRoZSBjb2RlIG1vcmUgcmVhZGFibGUgYW5kIG1heSBicmluZyBwZXJm b3JtYW5jZSBpbXByb3ZlbWVudHMKPj4+Pj4gaW4gZnV0dXJlIGZlYXR1cmVzLgo+Pj4+Pgo+Pj4+ PiBTaWduZWQtb2ZmLWJ5OiBEZXRsZXYgQ2FzYW5vdmEgPGRldGxldi5jYXNhbm92YUBjb2xsYWJv cmEuY29tPgo+Pj4+PiAtLS0KPj4+Pj4KPj4+Pj4gICAgIGRyaXZlcnMvc3RhZ2luZy9tZWRpYS9L Y29uZmlnICAgICAgICAgICAgICAgIHwgICAgMSArCj4+Pj4+ICAgICBkcml2ZXJzL3N0YWdpbmcv bWVkaWEvTWFrZWZpbGUgICAgICAgICAgICAgICB8ICAgIDEgKwo+Pj4+PiAgICAgZHJpdmVycy9z dGFnaW5nL21lZGlhL3JrdmRlYzIvS2NvbmZpZyAgICAgICAgfCAgIDE1ICsKPj4+Pj4gICAgIGRy aXZlcnMvc3RhZ2luZy9tZWRpYS9ya3ZkZWMyL01ha2VmaWxlICAgICAgIHwgICAgMyArCj4+Pj4+ ICAgICBkcml2ZXJzL3N0YWdpbmcvbWVkaWEvcmt2ZGVjMi9UT0RPICAgICAgICAgICB8ICAgIDkg Kwo+Pj4+PiAgICAgZHJpdmVycy9zdGFnaW5nL21lZGlhL3JrdmRlYzIvcmt2ZGVjMi1oMjY0LmMg fCAgNzM5ICsrKysrKysrKysrCj4+Pj4+ICAgICBkcml2ZXJzL3N0YWdpbmcvbWVkaWEvcmt2ZGVj Mi9ya3ZkZWMyLXJlZ3MuaCB8ICAzNDUgKysrKysKPj4+Pj4gICAgIGRyaXZlcnMvc3RhZ2luZy9t ZWRpYS9ya3ZkZWMyL3JrdmRlYzIuYyAgICAgIHwgMTI1MyArKysrKysrKysrKysrKysrKysKPj4+ Pj4gICAgIGRyaXZlcnMvc3RhZ2luZy9tZWRpYS9ya3ZkZWMyL3JrdmRlYzIuaCAgICAgIHwgIDEz MCArKwo+Pj4+PiAgICAgOSBmaWxlcyBjaGFuZ2VkLCAyNDk2IGluc2VydGlvbnMoKykKPj4+Pj4g ICAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL3N0YWdpbmcvbWVkaWEvcmt2ZGVjMi9LY29u ZmlnCj4+Pj4+ICAgICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9zdGFnaW5nL21lZGlhL3Jr dmRlYzIvTWFrZWZpbGUKPj4+Pj4gICAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL3N0YWdp bmcvbWVkaWEvcmt2ZGVjMi9UT0RPCj4+Pj4+ICAgICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVy cy9zdGFnaW5nL21lZGlhL3JrdmRlYzIvcmt2ZGVjMi1oMjY0LmMKPj4+Pj4gICAgIGNyZWF0ZSBt b2RlIDEwMDY0NCBkcml2ZXJzL3N0YWdpbmcvbWVkaWEvcmt2ZGVjMi9ya3ZkZWMyLXJlZ3MuaAo+ Pj4+PiAgICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvc3RhZ2luZy9tZWRpYS9ya3ZkZWMy L3JrdmRlYzIuYwo+Pj4+PiAgICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvc3RhZ2luZy9t ZWRpYS9ya3ZkZWMyL3JrdmRlYzIuaAo+Pj4+IC4uLgo+Pj4+Cj4+Pj4+ICtzdGF0aWMgaW5saW5l IHZvaWQgcmt2ZGVjMl9tZW1jcHlfdG9pbyh2b2lkIF9faW9tZW0gKmRzdCwgdm9pZCAqc3JjLAo+ Pj4+PiBzaXplX3QgbGVuKSArewo+Pj4+PiArI2lmZGVmIENPTkZJR19BUk02NAo+Pj4+PiArCV9f aW93cml0ZTMyX2NvcHkoZHN0LCBzcmMsIGxlbik7Cj4+Pj4+ICsjZWxpZiBkZWZpbmVkKENPTkZJ R19BUk0pCj4+Pj4gSSBndWVzcyB0aGF0IGNhbiBnZXQgYW4gIiNlbHNlIiBzaW5jZSBtZW1jcHlf dG9pbyBleGlzdHMgZm9yIGFsbCBhcmNocy4KPj4+Pgo+Pj4+PiArCW1lbWNweV90b2lvKGRzdCwg c3JjLCBsZW4pOwo+Pj4+PiArI2VuZGlmCj4+Pj4+ICt9Cj4+Pj4+ICsKPj4+PiAuLi4KPj4+Pgo+ Pj4+PiArCS8qIFNldCB0aW1lb3V0IHRocmVzaG9sZCAqLwo+Pj4+PiArCWlmIChwaXhlbHMgPCBS S1ZERUMyXzEwODBQX1BJWEVMUykKPj4+Pj4gKwkJcmVncy0+Y29tbW9uLnRpbWVvdXRfdGhyZXNo b2xkID0gUktWREVDMl9USU1FT1VUXzEwODBwOwo+Pj4+PiArCWVsc2UgaWYgKHBpeGVscyA8IFJL VkRFQzJfNEtfUElYRUxTKQo+Pj4+PiArCQlyZWdzLT5jb21tb24udGltZW91dF90aHJlc2hvbGQg PSBSS1ZERUMyX1RJTUVPVVRfNEs7Cj4+Pj4+ICsJZWxzZSBpZiAocGl4ZWxzIDwgUktWREVDMl84 S19QSVhFTFMpCj4+Pj4+ICsJCXJlZ3MtPmNvbW1vbi50aW1lb3V0X3RocmVzaG9sZCA9IFJLVkRF QzJfVElNRU9VVF84SzsKPj4+Pj4gKwo+Pj4+IERpZCB5b3UgdGVzdCBpZiBpdCB3b3JrcyB3aXRo IGFueXRoaW5nID4gOEs/IElmIHNvLCB5b3UgcHJvcGFibHkgd2FudCB0bwo+Pj4+IG1ha2UgdGhl IGNoZWNrIGFib3ZlCj4+Pj4KPj4+PiArCWVsc2UKPj4+PiArCQlyZWdzLT5jb21tb24udGltZW91 dF90aHJlc2hvbGQgPSBSS1ZERUMyX1RJTUVPVVRfOEs7Cj4+Pj4KPj4+PiBPdGhlcndpc2UgdGhl IHRpbWVvdXQgbWF5IG5vdCBiZSBzZXQvY29udGFpbiBpbnZhbGlkIHZhbHVlcyBmcm9tIGFueSBm b3JtZXIKPj4+PiBzdHJlYW0uCj4+PiBUaGF0J3MgcmlnaHQsIGJ1dCBpdCB3b3VsZCBiZSBzZXQg dG8gMCBiZWNhdXNlIG9mIHRoZSBtZW1zZXQuCj4+PiBSS1ZERUMyX1RJTUVPVVRfOEsgbWlnaHQg bm90IGJlIGVub3VnaCBmb3IgYmlnZ2VyIGZyYW1lIHNpemVzLCBzbyBJJ2xsIHNldCBpdAo+Pj4g dG8gdGhlIG1heGltdW0gdmFsdWUgKDB4ZmZmZmZmZmYpIHdoZW4gZnJhbWVzIGFyZSBiaWdnZXIg dGhhbiA4SyBhbmQgYWxzbyBhZGFwdAo+Pj4gdGhlIHdhdGNoZG9nIHRpbWU6IFJLVkRFQzJfVElN RU9VVF84SyBpcyBhcm91bmQgMTAwIG1zLCBidXQgMHhmZmZmZmZmZiBpcyBhcm5vdWQKPj4+IDUu MyBzZWNvbmRzIChyZWcwMzIvYXhpX2Nsb2NrX2ZyZXEpCj4+Pgo+Pj4gSSdsbCBkbyBtb3JlIHRl c3RzIHdpdGggdGhpcyBhcyB3ZWxsLgo+Pj4KPj4+PiAuLi4KPj4+Pgo+Pj4+PiArCj4+Pj4+ICtz dGF0aWMgY29uc3Qgc3RydWN0IHJrdmRlYzJfY29kZWRfZm10X2Rlc2Mgcmt2ZGVjMl9jb2RlZF9m bXRzW10gPSB7Cj4+Pj4+ICsJewo+Pj4+PiArCQkuZm91cmNjID0gVjRMMl9QSVhfRk1UX0gyNjRf U0xJQ0UsCj4+Pj4+ICsJCS5mcm1zaXplID0gewo+Pj4+PiArCQkJLm1pbl93aWR0aCA9IDE2LAo+ Pj4+PiArCQkJLm1heF93aWR0aCA9ICA2NTUyMCwKPj4+Pj4gKwkJCS5zdGVwX3dpZHRoID0gMTYs Cj4+Pj4+ICsJCQkubWluX2hlaWdodCA9IDE2LAo+Pj4+PiArCQkJLm1heF9oZWlnaHQgPSAgNjU1 MjAsCj4+Pj4+ICsJCQkuc3RlcF9oZWlnaHQgPSAxNiwKPj4+Pj4gKwkJfSwKPj4+Pj4gKwkJLmN0 cmxzID0gJnJrdmRlYzJfaDI2NF9jdHJscywKPj4+Pj4gKwkJLm9wcyA9ICZya3ZkZWMyX2gyNjRf Zm10X29wcywKPj4+Pj4gKwkJLm51bV9kZWNvZGVkX2ZtdHMgPQo+Pj4gQVJSQVlfU0laRShya3Zk ZWMyX2gyNjRfZGVjb2RlZF9mbXRzKSwKPj4+Pj4gKwkJLmRlY29kZWRfZm10cyA9IHJrdmRlYzJf aDI2NF9kZWNvZGVkX2ZtdHMsCj4+Pj4+ICsJCS5zdWJzeXN0ZW1fZmxhZ3MgPQo+Pj4gVkIyX1Y0 TDJfRkxfU1VQUE9SVFNfTTJNX0hPTERfQ0FQVFVSRV9CVUYsCj4+Pj4+ICsJfSwKPj4+Pj4gK307 Cj4+Pj4+ICsKPj4+PiBOb3RlLCB0aGF0IHRoaXMgaXMgYWxzbyBnaXZlbiB0byB1c2Vyc3BhY2Ug KFZJRElPQ19FTlVNX0ZSQU1FU0laRVMpIGFuZAo+Pj4+IHRoaXMgaXMgYWxyZWFkeSBpbmNvcnJl Y3QgaW4gdGhlIG9sZCBya3ZkZWMgZHJpdmVyIChhbmQgaGFudHJvKTogRnJvbQo+Pj4+IHVzZXJz cGFjZSBwZXJzcGVjdGl2ZSB3ZSBkbyBub3QgaGF2ZSBhIHJlc3RyaWN0aW9uIGluCj4+Pj4gc3Rl cF93aWR0aC9zdGVwX3dpZHRoLCBhcyB3ZSBhcmUgYWxpZ25pbmcgYW55IGdpdmVuIHdpZHRoL2hl aWdodCB0byBIVwo+Pj4+IHJlcXVpcmVtZW50cyBpbiB0aGUgZHJpdmVyIC0gd2hhdCB3ZSBzaG91 bGQgZ2l2ZSB0byB1c2Vyc3BhY2UgaXMKPj4+PiBmc2l6ZS0+dHlwZSA9IFY0TDJfRlJNU0laRV9U WVBFX0NPTlRJTlVPVVM7IGZzaXplLT5zdGVwd2lzZS5taW5faGVpZ2h0ID0KPj4+PiAxOyBmc2l6 ZS0+c3RlcHdpc2UubWluX3dpZHRoID0gMTsgZnNpemUtPnN0ZXB3aXNlLm1heF9oZWlnaHQgPSA2 NTUyMDsKPj4+PiBmc2l6ZS0+c3RlcHdpc2UubWF4X3dpZHRoID0gNjU1MjA7Cj4+PiBJcyBmc2l6 ZS0+c3RlcHdpc2UubWluX2hlaWdodCA9IDE7IGFuZCBmc2l6ZS0+c3RlcHdpc2UubWluX3dpZHRo ID0gMSBjb3JyZWN0ID8KPj4+IE9yIGRvIHlvdSBtZWFuIGZzaXplLT5zdGVwd2lzZS5zdGVwX2hl aWdodCA9IDE7IGFuZCBmc2l6ZS0+c3RlcHdpc2Uuc2V0cF93aWR0aAo+Pj4gPSAxID8KPj4+Cj4+ PiBJdCB3b3VsZCBnaXZlIHRoaXMgaW5zdGVhZDoKPj4+Cj4+PiAuZnJtc2l6ZSA9IHsKPj4+IAku bWluX3dpZHRoID0gMTYsCj4+PiAJLm1heF93aWR0aCA9ICA2NTUyMCwKPj4+IAkuc3RlcF93aWR0 aCA9IDEsCj4+PiAJLm1pbl9oZWlnaHQgPSAxNiwKPj4+IAkubWF4X2hlaWdodCA9ICA2NTUyMCwK Pj4+IAkuc3RlcF9oZWlnaHQgPSAxLAo+Pj4gfSwKPj4+Cj4+PiBhbmQgLnZpZGlvY19lbnVtX2Zy YW1lc2l6ZXMgc2V0cyBmc2l6ZS0+dHlwZSA9IFY0TDJfRlJNU0laRV9UWVBFX0NPTlRJTlVPVVM7 Cj4+IFlvdSBjYW4ndCBhZGFwdCB0aGlzIGhlcmUsIGJlY2F1c2UgdGhpcyAuZnJtc2l6ZSBpcyBh bHNvIGdpdmVuIHRvIHRoZQo+PiB2NGwyX2FwcGx5X2ZybXNpemVfY29uc3RyYWludHMgaGVscGVy LCB3aGljaCBkb2VzIHRoZSBhY3R1YWwgYWxpZ25tZW50IHRvCj4+IEhXIHJlcXVpcmVtZW50cyBh bmQgcmVxdWlyZXMgdGhlIEhXIHN0ZXBfd2l0aCBhbmQgc3RlcF9oZWlnaHQuCj4+IElJUkMsIHdl IGFsc28gYWxpZ24gZnJhbWVzaXplcyB3aGljaCBhcmUgYmVsb3cgbWluaW11bSBIVyByZXF1aXJl bWVudCwgYXQKPj4gbGVhc3QgaW4gcmt2ZGVjMSBkcml2ZXIgYW5kIGl0IGxvb2tzIGEgbG90IGxp a2UgdGhpcyBpcyBkb25lIGhlcmUgdGhlIHNhbWU6Cj4+IHNvIHRoaXMgc2hvdWxkIGJlIC5taW5f aGVpZ2h0ID0gMSBhbmQgLm1pbl93aWR0aCA9IDEuIChJIHJlbWVtYmVyIGJlY2F1c2UKPj4gdGhl cmUgYXJlIFZQOSBjb25mb3JtYW5jZSB0ZXN0cyB3aXRoIHZlcnkgc21hbGwgZnJhbWVzaXplcyku IEFuZCB5ZXMsIGl0Cj4+IGxvb2tzIGxpa2UgeW91J3ZlIGhhZCB0byBzZXQgLnN0ZXBfd2lkdGgg YW5kIC5zdGVwX2hlaWdodCB0byAxIGZvcgo+PiBWNEwyX0ZSTVNJWkVfVFlQRV9DT05USU5VT1VT LCBub3Qgc3VyZSB3aHkgdGhhdCBpcyByZXF1aXJlZC4KPj4KPj4gU28sIGltaG8sIHRoZSBmaW5h bCBya3ZkZWMyX2VudW1fZnJhbWVzaXplcyBzaG91bGQgbG9vayBsaWtlCj4+Cj4+ICtzdGF0aWMg aW50IHJrdmRlYzJfZW51bV9mcmFtZXNpemVzKHN0cnVjdCBmaWxlICpmaWxlLCB2b2lkICpwcml2 LAo+PiArwqDCoMKgIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgwqAgc3RydWN0IHY0bDJfZnJtc2l6 ZWVudW0gKmZzaXplKQo+PiAuLi4uCj4+ICvCoMKgwqAgZm10ID0gcmt2ZGVjMl9maW5kX2NvZGVk X2ZtdF9kZXNjKGZzaXplLT5waXhlbF9mb3JtYXQpOwo+PiArwqDCoMKgIGlmICghZm10KQo+PiAr wqDCoMKgIMKgwqDCoCByZXR1cm4gLUVJTlZBTDsKPj4gKwo+PiArwqDCoMKgIGZzaXplLT50eXBl ID0gVjRMMl9GUk1TSVpFX1RZUEVfQ09OVElOVU9VUzsKPj4gK8KgwqDCoCBmc2l6ZS0+c3RlcHdp c2UubWluX2hlaWdodCA9IDE7Cj4+ICvCoMKgwqAgZnNpemUtPnN0ZXB3aXNlLm1heF9oZWlnaHQg PSBmbXQtPmZybXNpemUubWF4X2hlaWdodDsKPj4gK8KgwqDCoCBmc2l6ZS0+c3RlcHdpc2UubWlu X3dpZHRoID0gMTsKPj4gK8KgwqDCoCBmc2l6ZS0+c3RlcHdpc2UubWF4X3dpZHRoID0gZm10LT5m cm1zaXplLm1heF93aWR0aDsKPj4gK8KgwqDCoCBmc2l6ZS0+c3RlcHdpc2UubWluX3dpZHRoID0g MTsKPj4gK8KgwqDCoCBmc2l6ZS0+c3RlcHdpc2Uuc3RlcF9oZWlnaHQgPSAxOwo+PiArwqDCoMKg IGZzaXplLT5zdGVwd2lzZS5zdGVwX3dpZHRoID0gMTsKPj4gK8KgwqDCoCByZXR1cm4gMDsKPj4g K30KPj4KPj4gTm90ZTogTm90IGV2ZW4gYnVpbGQgdGVzdGVkIDopCj4+IEpvbmFzOiBtYXliZSB5 b3UgY2FuIGFkZCBhIGZpeHVwIHBhdGNoIHRvIHlvdXIgcmt2ZGVjIHBhdGNoZXMgYXMgd2VsbC4K PiBUaGFua3MsIHdpbGwgdGFrZSBhIGNsb3NlciBsb29rIGFuZCBpbmNsdWRlIHNvbWV0aGluZyBm b3Igcmt2ZGVjIGhpZ2gxMAo+IHY2IGxhdGVyIHRvZGF5L3RvbW9ycm93LgpHcmVhdCwgdGhhbmtz LgoKVG8gYmFjayB1cCB0aGUgIklJUkMiIHBhcnQgb2YgbXkgcHJldmlvdXMgcmVwbHkgYWJvdXQg Lm1pbl93aWR0aCBhbmQKLm1pbl9oZWlnaHQ6IHY0bDJfYXBwbHlfZnJtc2l6ZV9jb25zdHJhaW50 cyBkb2VzIGNsYW1wX3JvdW5kdXAgb24gd2lkdGggYW5kCmhlaWdodCwgd2hpY2ggbWVhbnMgaXQg c2V0cyBoZWlnaHQgPSBod19taW5faGVpZ2h0IGFuZC9vciB3aWR0aCA9Cmh3X21pbl93aWR0aCBp ZiB0aGUgZ2l2ZW4gd2lkdGgvaGVpZ2h0IGlzIHNtYWxsZXIuIFRodXMgdXNlcnNwYWNlIGRvZXNu J3QKbmVlZCB0byBjYXJlIGFib3V0IHdpZHRoL2hlaWdodCBhcyBsb25nIGFzIGl0J3MgMSA8PQpo d19tYXhfaGVpZ2h0L2h3X21heF93aWR0aC4KCkFsZXgKCj4gUmVnYXJkcywKPiBKb25hcwo+Cj4+ IFJlZ2FyZHMsCj4+Cj4+IEFsZXgKPj4KPj4+PiBJIGd1ZXNzIHRoaXMgbmV3IGRyaXZlciBzaG91 bGQgYmUgYW4KPj4+PiBvcHBvcnR1bml0eSB0byBmaXggdGhhdCBhbmQgZGlzdGluZ3Vpc2ggYmV0 d2VlbiBpbnRlcm5hbCBhbmQgZXh0ZXJuYWwKPj4+PiBmcmFtZSBzaXplIHJlcXVpcmVtZW50cyBh bmQgdGhlIC52aWRpb2NfZW51bV9mcmFtZXNpemVzIGNhbGxiYWNrIHNob3VsZAo+Pj4+IGFkYXB0 ZWQgYWNjb3JkaW5nbHkuIFJlZ2FyZHMsIEFsZXgKPj4+IERldGxldi4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcg bGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C8BF146D7F for ; Thu, 27 Jun 2024 11:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719486644; cv=none; b=EqPnsgAjdheLJSrzVxsZHB4UQhejPVWYGmt4E1IsjboiYUgFBWi+T9x6Fv1e460saTMeS927vJRMMaeG4LnUl3VycTbMTO697UjBbZFzUUJQ2cVRWgp5NxLKe3ZQcQv2wHAn+mOpof2AyXghQh3f5wqwmEeCvcqTqNO85ZS9d8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719486644; c=relaxed/simple; bh=UbKp9LUghCiCU/BUAdg2EMYa4NybHUKKdju3cq3QKZg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lLhsRVdPrTIeyEUbwVbHaP8Fyq2Vq5lRLyVB+EcvwETLznQd9pBDODspHA/toGZRTLAOMyjm2X34B50Ll6OjrCu8D/PKGxkiTqp++WdP2Tik5KQJfcMZspV3T6O6pYJ0gHVOo6bZI+qaegysptoSPDaYrPCBz3O3uRaZfzpDyeM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BUuw4Alx; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BUuw4Alx" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-57d20d89748so1402754a12.0 for ; Thu, 27 Jun 2024 04:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719486641; x=1720091441; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RjG4NvLPZHP15XSF73Un+NgkQkULbEPKorgzxgkPLfo=; b=BUuw4AlxJpQIPFJB9T0wY1528OmrymeJ2oghMreKzj3/AxWtPQShFVEVb1tJu6iVM/ 5eAX9pUhbbJ26H159+XMmZN82Zmkg6GilRkww3W7NBZziuv3QUu/fiRxvcZ9+v5u5ZYc d4SczRsu1sXiRJYu6+WFtcfTX45M7WdHxhuoan3wmdNnn6yclsDiSm1nHb/otYo9LE9h Q6O1K3mmSkqIT6nuOj5XszDJw9gKeB4BSGy1hhKwjBomLUzI42/EZvoSur4kfKUjUdrH biJA+V+yErNVrQycEUaHevGnLDmuQWHU9gxFBXU9Lvlh9/TvbQviIoHeNW4ckJ7545pj ivdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719486641; x=1720091441; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RjG4NvLPZHP15XSF73Un+NgkQkULbEPKorgzxgkPLfo=; b=RYiYaI+e5AkwuufviS+WXoaD0Acyr9GB03eC0HkxaQ1KjFrE9QAiXmumY3T/3Ccs/V Nx9P74JYMlqfFtgMoRZ/sEELW7HzxcqLyv/rTrCw/sKHjQfNx//fbnYFqVMHjkPZokej o7lLPPeN5EnCuD2pTaWJ+rLw0/T+HeM84SpFEWTLD2jsR/rgCs/PLG4QN945XYYLq6vd x6Fd9tYxVSlkpwzuCM+gdkdAU3YCbF69uWiun39bNzRk33OlPYi6K7txTmDMNKys3ls5 nvYGYI1UXg9LpKTFJQS0bZE5W9XHBIJbgIP0hC3eednf7AyZTQ2oiBdrUl4Kxb2ZUGBU Whow== X-Forwarded-Encrypted: i=1; AJvYcCVwX6D2vtuQJMP1M4QhGbZjR+T9qidL9XogOI0XMFlbQcYZ8G9DuepH4LQRU6tjsY65PJgd3Cvr169WdsDJgj9C8+3Rdq8wJ/Ipt7/FpQ== X-Gm-Message-State: AOJu0YwzyqFEq0gKg7hKOaAnEVsnu5O12wIKBWs8E39xFGAMgMkIeCWz uIHHeAoUyOOlJZs3652ull0zSFD1kNDkU1yaiXEOF1tNq0d4cWo= X-Google-Smtp-Source: AGHT+IH4fbvY1cFOwHHzrwt3dVlavsf75UZvpMeelUbWWYiwXGXJ5CcSyvDpzggFY+YcW3P4/NbQ2g== X-Received: by 2002:a05:6402:520c:b0:582:1f66:1472 with SMTP id 4fb4d7f45d1cf-5821f661646mr6043539a12.31.1719486640245; Thu, 27 Jun 2024 04:10:40 -0700 (PDT) Received: from ?IPV6:2a02:810b:f40:4600:2023:48bf:6b4:88a4? ([2a02:810b:f40:4600:2023:48bf:6b4:88a4]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-584d16bbf1csm733229a12.44.2024.06.27.04.10.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jun 2024 04:10:39 -0700 (PDT) Message-ID: Date: Thu, 27 Jun 2024 13:10:38 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] media: rockchip: Introduce the rkvdec2 driver To: Jonas Karlman , Detlev Casanova Cc: Ezequiel Garcia , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Greg Kroah-Hartman , Sebastian Reichel , Dragan Simic , Diederik de Haas , Andy Yan , Boris Brezillon , Hans Verkuil , Daniel Almeida , Paul Kocialkowski , Nicolas Dufresne , Benjamin Gaignard , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20240620142532.406564-1-detlev.casanova@collabora.com> <20240620142532.406564-3-detlev.casanova@collabora.com> <3815203.kQq0lBPeGt@arisu> <5a15b138-4e03-4487-8a53-b7ff3527701f@gmail.com> <66e56996-4b56-4262-973f-672121071391@kwiboo.se> Content-Language: en-US From: Alex Bee In-Reply-To: <66e56996-4b56-4262-973f-672121071391@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Am 27.06.24 um 11:41 schrieb Jonas Karlman: > Hi Alex, > > On 2024-06-26 11:12, Alex Bee wrote: >> Hi Detlev, >> >> Am 25.06.24 um 18:56 schrieb Detlev Casanova: >>> Hi Alex, >>> >>> On Sunday, June 23, 2024 5:33:28 A.M. EDT you wrote: >>>> Hi Detlev, >>>> >>>> Am 20.06.24 um 16:19 schrieb Detlev Casanova: >>>>> This driver supports the second generation of the Rockchip Video >>>>> decoder, also known as vdpu34x. >>>>> It is currently only used on the RK3588(s) SoC. >>>>> >>>>> There are 2 decoders on the RK3588 SoC that can work in pair to decode >>>>> 8K video at 30 FPS but currently, only using one core at a time is >>>>> supported. >>>>> >>>>> Scheduling requests between the two cores will be implemented later. >>>>> >>>>> The core supports H264, HEVC, VP9 and AVS2 decoding but this driver >>>>> currently only supports H264. >>>>> >>>>> The driver is based on rkvdec and they may share some code in the >>>>> future. >>>>> The decision to make a different driver is mainly because rkvdec2 has >>>>> more features and can work with multiple cores. >>>>> >>>>> The registers are mapped in a struct in RAM using bitfields. It is IO >>>>> copied to the HW when all values are configured. >>>>> The decision to use such a struct instead of writing buffers one by one >>>>> >>>>> is based on the following reasons: >>>>> - Rockchip cores are known to misbehave when registers are not written >>>>> >>>>> in address order, >>>>> >>>>> - Those cores also need the software to write all registers, even if >>>>> >>>>> they are written their default values or are not related to the task >>>>> (this core will not start decoding some H264 frames if some VP9 >>>>> registers are not written to 0) >>>>> >>>>> - In the future, to support multiple cores, the scheduler could be >>>>> >>>>> optimized by storing the precomputed registers values and copy them >>>>> to the HW as soos as a core becomes available. >>>>> >>>>> This makes the code more readable and may bring performance improvements >>>>> in future features. >>>>> >>>>> Signed-off-by: Detlev Casanova >>>>> --- >>>>> >>>>> drivers/staging/media/Kconfig | 1 + >>>>> drivers/staging/media/Makefile | 1 + >>>>> drivers/staging/media/rkvdec2/Kconfig | 15 + >>>>> drivers/staging/media/rkvdec2/Makefile | 3 + >>>>> drivers/staging/media/rkvdec2/TODO | 9 + >>>>> drivers/staging/media/rkvdec2/rkvdec2-h264.c | 739 +++++++++++ >>>>> drivers/staging/media/rkvdec2/rkvdec2-regs.h | 345 +++++ >>>>> drivers/staging/media/rkvdec2/rkvdec2.c | 1253 ++++++++++++++++++ >>>>> drivers/staging/media/rkvdec2/rkvdec2.h | 130 ++ >>>>> 9 files changed, 2496 insertions(+) >>>>> create mode 100644 drivers/staging/media/rkvdec2/Kconfig >>>>> create mode 100644 drivers/staging/media/rkvdec2/Makefile >>>>> create mode 100644 drivers/staging/media/rkvdec2/TODO >>>>> create mode 100644 drivers/staging/media/rkvdec2/rkvdec2-h264.c >>>>> create mode 100644 drivers/staging/media/rkvdec2/rkvdec2-regs.h >>>>> create mode 100644 drivers/staging/media/rkvdec2/rkvdec2.c >>>>> create mode 100644 drivers/staging/media/rkvdec2/rkvdec2.h >>>> ... >>>> >>>>> +static inline void rkvdec2_memcpy_toio(void __iomem *dst, void *src, >>>>> size_t len) +{ >>>>> +#ifdef CONFIG_ARM64 >>>>> + __iowrite32_copy(dst, src, len); >>>>> +#elif defined(CONFIG_ARM) >>>> I guess that can get an "#else" since memcpy_toio exists for all archs. >>>> >>>>> + memcpy_toio(dst, src, len); >>>>> +#endif >>>>> +} >>>>> + >>>> ... >>>> >>>>> + /* Set timeout threshold */ >>>>> + if (pixels < RKVDEC2_1080P_PIXELS) >>>>> + regs->common.timeout_threshold = RKVDEC2_TIMEOUT_1080p; >>>>> + else if (pixels < RKVDEC2_4K_PIXELS) >>>>> + regs->common.timeout_threshold = RKVDEC2_TIMEOUT_4K; >>>>> + else if (pixels < RKVDEC2_8K_PIXELS) >>>>> + regs->common.timeout_threshold = RKVDEC2_TIMEOUT_8K; >>>>> + >>>> Did you test if it works with anything > 8K? If so, you propably want to >>>> make the check above >>>> >>>> + else >>>> + regs->common.timeout_threshold = RKVDEC2_TIMEOUT_8K; >>>> >>>> Otherwise the timeout may not be set/contain invalid values from any former >>>> stream. >>> That's right, but it would be set to 0 because of the memset. >>> RKVDEC2_TIMEOUT_8K might not be enough for bigger frame sizes, so I'll set it >>> to the maximum value (0xffffffff) when frames are bigger than 8K and also adapt >>> the watchdog time: RKVDEC2_TIMEOUT_8K is around 100 ms, but 0xffffffff is arnoud >>> 5.3 seconds (reg032/axi_clock_freq) >>> >>> I'll do more tests with this as well. >>> >>>> ... >>>> >>>>> + >>>>> +static const struct rkvdec2_coded_fmt_desc rkvdec2_coded_fmts[] = { >>>>> + { >>>>> + .fourcc = V4L2_PIX_FMT_H264_SLICE, >>>>> + .frmsize = { >>>>> + .min_width = 16, >>>>> + .max_width = 65520, >>>>> + .step_width = 16, >>>>> + .min_height = 16, >>>>> + .max_height = 65520, >>>>> + .step_height = 16, >>>>> + }, >>>>> + .ctrls = &rkvdec2_h264_ctrls, >>>>> + .ops = &rkvdec2_h264_fmt_ops, >>>>> + .num_decoded_fmts = >>> ARRAY_SIZE(rkvdec2_h264_decoded_fmts), >>>>> + .decoded_fmts = rkvdec2_h264_decoded_fmts, >>>>> + .subsystem_flags = >>> VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF, >>>>> + }, >>>>> +}; >>>>> + >>>> Note, that this is also given to userspace (VIDIOC_ENUM_FRAMESIZES) and >>>> this is already incorrect in the old rkvdec driver (and hantro): From >>>> userspace perspective we do not have a restriction in >>>> step_width/step_width, as we are aligning any given width/height to HW >>>> requirements in the driver - what we should give to userspace is >>>> fsize->type = V4L2_FRMSIZE_TYPE_CONTINUOUS; fsize->stepwise.min_height = >>>> 1; fsize->stepwise.min_width = 1; fsize->stepwise.max_height = 65520; >>>> fsize->stepwise.max_width = 65520; >>> Is fsize->stepwise.min_height = 1; and fsize->stepwise.min_width = 1 correct ? >>> Or do you mean fsize->stepwise.step_height = 1; and fsize->stepwise.setp_width >>> = 1 ? >>> >>> It would give this instead: >>> >>> .frmsize = { >>> .min_width = 16, >>> .max_width = 65520, >>> .step_width = 1, >>> .min_height = 16, >>> .max_height = 65520, >>> .step_height = 1, >>> }, >>> >>> and .vidioc_enum_framesizes sets fsize->type = V4L2_FRMSIZE_TYPE_CONTINUOUS; >> You can't adapt this here, because this .frmsize is also given to the >> v4l2_apply_frmsize_constraints helper, which does the actual alignment to >> HW requirements and requires the HW step_with and step_height. >> IIRC, we also align framesizes which are below minimum HW requirement, at >> least in rkvdec1 driver and it looks a lot like this is done here the same: >> so this should be .min_height = 1 and .min_width = 1. (I remember because >> there are VP9 conformance tests with very small framesizes). And yes, it >> looks like you've had to set .step_width and .step_height to 1 for >> V4L2_FRMSIZE_TYPE_CONTINUOUS, not sure why that is required. >> >> So, imho, the final rkvdec2_enum_framesizes should look like >> >> +static int rkvdec2_enum_framesizes(struct file *file, void *priv, >> +                   struct v4l2_frmsizeenum *fsize) >> .... >> +    fmt = rkvdec2_find_coded_fmt_desc(fsize->pixel_format); >> +    if (!fmt) >> +        return -EINVAL; >> + >> +    fsize->type = V4L2_FRMSIZE_TYPE_CONTINUOUS; >> +    fsize->stepwise.min_height = 1; >> +    fsize->stepwise.max_height = fmt->frmsize.max_height; >> +    fsize->stepwise.min_width = 1; >> +    fsize->stepwise.max_width = fmt->frmsize.max_width; >> +    fsize->stepwise.min_width = 1; >> +    fsize->stepwise.step_height = 1; >> +    fsize->stepwise.step_width = 1; >> +    return 0; >> +} >> >> Note: Not even build tested :) >> Jonas: maybe you can add a fixup patch to your rkvdec patches as well. > Thanks, will take a closer look and include something for rkvdec high10 > v6 later today/tomorrow. Great, thanks. To back up the "IIRC" part of my previous reply about .min_width and .min_height: v4l2_apply_frmsize_constraints does clamp_roundup on width and height, which means it sets height = hw_min_height and/or width = hw_min_width if the given width/height is smaller. Thus userspace doesn't need to care about width/height as long as it's 1 <= hw_max_height/hw_max_width. Alex > Regards, > Jonas > >> Regards, >> >> Alex >> >>>> I guess this new driver should be an >>>> opportunity to fix that and distinguish between internal and external >>>> frame size requirements and the .vidioc_enum_framesizes callback should >>>> adapted accordingly. Regards, Alex >>> Detlev.