Re: [PATCH] tests/vm/freebsd: Increase code coverage

[Wainer dos Santos Moschetta <wainersm@redhat.com>]

Hi,

On 5/31/21 7:03 AM, Philippe Mathieu-Daudé wrote:
> Install more dependencies to increase code coverage.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   tests/vm/freebsd | 5 +++++
>   1 file changed, 5 insertions(+)

With or without this patch I got an error when `make vm-build-freebsd`. 
It fails to install packages.

For example, with this patch I got:

< Output omitted>

### Installing packages ...
Failed to prepare guest environment
Traceback (most recent call last):
   File "/home/wmoschet/src/qemu/tests/vm/basevm.py", line 634, in main
     return vm.build_image(args.image)
   File "/home/wmoschet/src/qemu/tests/vm/freebsd", line 206, in build_image
     self.ssh_root_check("pkg install -y %s\n" % " ".join(self.pkgs))
   File "/home/wmoschet/src/qemu/tests/vm/basevm.py", line 255, in 
ssh_root_check
     self._ssh_do(self._config["root_user"], cmd, True)
   File "/home/wmoschet/src/qemu/tests/vm/basevm.py", line 242, in _ssh_do
     raise Exception("SSH command failed: %s" % cmd)
Exception: SSH command failed: pkg install -y git pkgconf bzip2 python37 
ninja bash gmake gsed gettext cyrus-sasl gnutls nettle jpeg-turbo png 
sdl2 gtk3 libxkbcommon pixman libepoxy mesa-libs zstd usbredir

Is it a known issue?

>
> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index 6e20e843228..85049b43136 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -46,7 +46,9 @@ class FreeBSDVM(basevm.BaseVM):
>           "gettext",
>   
>           # libs: crypto
> +        "cyrus-sasl",
>           "gnutls",
> +        "nettle",
>   
>           # libs: images
>           "jpeg-turbo",
> @@ -56,6 +58,7 @@ class FreeBSDVM(basevm.BaseVM):
>           "sdl2",
>           "gtk3",
>           "libxkbcommon",
> +        "pixman",
>   
>           # libs: opengl
>           "libepoxy",
> @@ -63,6 +66,8 @@ class FreeBSDVM(basevm.BaseVM):
>   
>           # libs: migration
>           "zstd",
> +
> +        "usbredir",
>       ]
>   
>       # TODO: Enable gnutls again once FreeBSD's libtasn1 got fixed