From: Jesper Dangaard Brouer <hawk@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>,
Johannes Berg <johannes@sipsolutions.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: hawk@kernel.org, "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"jiawenwu@trustnetic.com" <jiawenwu@trustnetic.com>,
"mengyuanlou@net-swift.com" <mengyuanlou@net-swift.com>,
"yang.lee@linux.alibaba.com" <yang.lee@linux.alibaba.com>,
"error27@gmail.com" <error27@gmail.com>,
"linyunsheng@huawei.com" <linyunsheng@huawei.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"kys@microsoft.com" <kys@microsoft.com>,
"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"decui@microsoft.com" <decui@microsoft.com>,
"longli@microsoft.com" <longli@microsoft.com>,
"shradhagupta@linux.microsoft.com"
<shradhagupta@linux.microsoft.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"michael.chan@broadcom.com" <michael.chan@broadcom.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>,
"salil.mehta@huawei.com" <salil.mehta@huawei.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"nbd@nbd.name" <nbd@nbd.name>,
"john@phrozen.org" <john@phrozen.org>,
"sean.wang@mediatek.com" <sean.wang@mediatek.com>,
"Mark-MC.Lee@mediatek.com" <Mark-MC.Lee@mediatek.com>,
"lorenzo@kernel.org" <lorenzo@kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"saeedm@nvidia.com" <saeedm@nvidia.com>,
"leon@kernel.org" <leon@kernel.org>,
"gerhard@engleder-embedded.com" <gerhard@engleder-embedded.com>,
"maciej.fijalkowski@intel.com" <maciej.fijalkowski@intel.com>,
"alexanderduyck@fb.com" <alexanderduyck@fb.com>,
"wei.fang@nxp.com" <wei.fang@nxp.com>,
"shenwei.wang@nxp.com" <shenwei.wang@nxp.com>,
"xiaoning.wang@nxp.com" <xiaoning.wang@nxp.com>,
"linux-imx@nxp.com" <linux-imx@nxp.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"jaswinder.singh@linaro.org" <jaswinder.singh@linaro.org>,
"ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"horatiu.vultur@microchip.com" <horatiu.vultur@microchip.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
"simon.horman@corigine.com" <simon.horman@corigine.com>,
"vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
"aleksander.lobakin@intel.com" <aleksander.lobakin@intel.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
"mw@semihalf.com" <mw@semihalf.com>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"jgross@suse.com" <jgross@suse.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"oleksandr_tyshchenko@epam.com" <oleksandr_tyshchenko@epam.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ryder.lee@mediatek.com" <ryder.lee@mediatek.com>,
"shayne.chen@mediatek.com" <shayne.chen@mediatek.com>,
"kvalo@kernel.org" <kvalo@kernel.org>,
"andrii@kernel.org" <andrii@kernel.org>,
"martin.lau@linux.dev" <martin.lau@linux.dev>,
"song@kernel.org" <song@kernel.org>,
"yonghong.song@linux.dev" <yonghong.song@linux.dev>,
"kpsingh@kernel.org" <kpsingh@kernel.org>,
"sdf@google.com" <sdf@google.com>,
"haoluo@google.com" <haoluo@google.com>,
"jolsa@kernel.org" <jolsa@kernel.org>
Subject: Re: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k.
Date: Mon, 14 Aug 2023 10:45:42 +0200 [thread overview]
Message-ID: <cceef8a4-6f38-bfd4-4f77-5dffa558b287@kernel.org> (raw)
In-Reply-To: <MWHPR1801MB1918230E007D7B2C5A768B37D317A@MWHPR1801MB1918.namprd18.prod.outlook.com>
On 14/08/2023 10.05, Ratheesh Kannoth wrote:
>> From: Johannes Berg <johannes@sipsolutions.net>
>> Subject: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k.
>>> Please find discussion at
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_l
>>>
>> I'm not the one who's going to apply this, but honestly, I don't think that will
>> work as a commit message for such a change ...
>> Sure, link to it by all means, but also summarize it and make sense of it for
>> the commit message?
>
> Why do you think it will not work ?. There is a long discussion about pros and cons of different approaches by
> Page pool maintainers in the discussion link. However I summarize it here, as commit message, it will
> Lead to some more questions by reviewers.
>
I agree with Johannes, this commit message is too thin.
It makes sense to give a summary of the discussion, because it show us
(page_pool maintainers) what you concluded for the discussion.
Further more, you also send another patch:
- "[PATCH net-next] page_pool: Set page pool size"
-
https://lore.kernel.org/all/20230809021920.913324-1-rkannoth@marvell.com/
That patch solves the issue for your driver marvell/octeontx2 and I like
than change.
Why did you conclude that PP core should also change?
--Jesper
(p.s. Cc/To list have gotten excessive with 89 recipients)
next prev parent reply other threads:[~2023-08-14 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 6:04 [PATCH v1 net] page_pool: Cap queue size to 32k Ratheesh Kannoth
2023-08-14 7:54 ` Johannes Berg
2023-08-14 8:05 ` [EXT] " Ratheesh Kannoth
2023-08-14 8:45 ` Jesper Dangaard Brouer [this message]
2023-08-14 8:55 ` Ratheesh Kannoth
2023-09-05 9:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cceef8a4-6f38-bfd4-4f77-5dffa558b287@kernel.org \
--to=hawk@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrii@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ast@kernel.org \
--cc=broonie@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=gakula@marvell.com \
--cc=gerhard@engleder-embedded.com \
--cc=grygorii.strashko@ti.com \
--cc=haiyangz@microsoft.com \
--cc=haoluo@google.com \
--cc=hkelam@marvell.com \
--cc=horatiu.vultur@microchip.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=jdelvare@suse.com \
--cc=jgross@suse.com \
--cc=jiawenwu@trustnetic.com \
--cc=joabreu@synopsys.com \
--cc=johannes@sipsolutions.net \
--cc=john.fastabend@gmail.com \
--cc=john@phrozen.org \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=linyunsheng@huawei.com \
--cc=longli@microsoft.com \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=martin.lau@linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mengyuanlou@net-swift.com \
--cc=michael.chan@broadcom.com \
--cc=mw@semihalf.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rkannoth@marvell.com \
--cc=ryder.lee@mediatek.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=sbhatta@marvell.com \
--cc=sdf@google.com \
--cc=sean.wang@mediatek.com \
--cc=sgoutham@marvell.com \
--cc=shayne.chen@mediatek.com \
--cc=shenwei.wang@nxp.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=simon.horman@corigine.com \
--cc=song@kernel.org \
--cc=sstabellini@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=wei.liu@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiaoning.wang@nxp.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yisen.zhuang@huawei.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.