All of lore.kernel.org
 help / color / mirror / Atom feed
From: Changqing Li <changqing.li@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] icu: Add coreutils-native as DEPENDS
Date: Tue, 22 Apr 2025 21:07:30 +0800	[thread overview]
Message-ID: <ccf80247-a187-4f55-9ffb-6fe0751187bb@windriver.com> (raw)
In-Reply-To: <0bf48ef944adc7ba879149b5c9427bc770fa86f4.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]


On 4/21/25 20:26, Richard Purdie wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Fri, 2025-04-18 at 16:19 +0800, Changqing Li via lists.openembedded.org wrote:
>> From: Changqing Li<changqing.li@windriver.com>
>>
>> icu will check program install path during do_configure, eg:
>> checking for a BSD-compatible install... /path/to/install -c
>>
>> And this path will be writen into pkgdata.inc:
>> INSTALL_CMD=$(INSTALL-L)
>>
>> Decided by if install is installed into recipe-sysroot-native during
>> do_configure stage, the INSTALL_CMD could be
>> /build/tmp/work/corei7-64-wrs-linux/icu/76-1/recipe-sysroot-native/usr/bin/install
>> or /build/tmp/hosttools/install
>>
>> Add coreutils-native as DEPENDS to make a determined result of
>> INSTALL_CMD, avoid vary caused by the execute sequence of another task
>> which DEPENDS on coreutils-native and also independent with do_configure
>>
>> Signed-off-by: Changqing Li<changqing.li@windriver.com>
>> ---
>>   meta/recipes-support/icu/icu_76-1.bb | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> This needs to be fixed differently, we should be forcing it to use PATH
> and set the value to just "install". We don't want to add dependencies
> unless we really need them, they slow the builds down and add
> inefficiencies.

Thanks Richard. Currently, it will find "install" in PATH,  but 
STAGING_BINDIR_NATIVE is before HOSTTOOLS_DIR,

so when there is install under STAGING_BINDIR_NATIVE, it will use this 
one,  if not,  it will use the one under

HOSTTOOLS_DIR.  According to your comments,  I send a V3,  force it to 
use HOSTTOOLS_DIR/install directly,

please help to review.

Regards

//Changqing

>
> Cheers,
>
> Richard

[-- Attachment #2: Type: text/html, Size: 2800 bytes --]

  reply	other threads:[~2025-04-22 13:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18  8:19 [PATCH] icu: Add coreutils-native as DEPENDS changqing.li
2025-04-18 16:26 ` [OE-core] " Mathieu Dubois-Briand
2025-04-21  1:55   ` Changqing Li
2025-04-21 12:26 ` Richard Purdie
2025-04-22 13:07   ` Changqing Li [this message]
2025-04-24  3:28   ` Changqing Li
2025-04-24 12:10     ` Mathieu Dubois-Briand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccf80247-a187-4f55-9ffb-6fe0751187bb@windriver.com \
    --to=changqing.li@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.