From: Andrew Lunn <andrew@lunn.ch>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Elad Nachman <enachman@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: prestera: avoid overreading a short firmware tail
Date: Sun, 30 Aug 2026 16:28:10 +0200 [thread overview]
Message-ID: <ccfa4dd8-7b5c-4417-86a7-14638dfd2aa4@lunn.ch> (raw)
In-Reply-To: <20260830142404.37663-1-pengpeng@iscas.ac.cn>
On Sun, Aug 30, 2026 at 10:24:03PM +0800, Pengpeng Hou wrote:
> prestera_ldr_send() writes the firmware in 32-bit words even when the final
> chunk is not four-byte aligned. The last iteration then reads a full u32
> from a one-to-three-byte tail.
>
> Reserve the aligned ring space, use unaligned-safe full-word loads, and
> zero-pad a partial final word without reading beyond the firmware image.
"What?" a patch does i can see by reading the code. So the commit
message should explain "Why?" you want to make this change.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-08-30 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 14:24 [PATCH] net: prestera: avoid overreading a short firmware tail Pengpeng Hou
2026-08-30 14:28 ` Andrew Lunn [this message]
2026-09-02 13:06 ` kernel test robot
2026-09-03 14:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccfa4dd8-7b5c-4417-86a7-14638dfd2aa4@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enachman@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.