From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org,
fw@strlen.de, coreteam@netfilter.org
Subject: Re: [PATCH nf v2 0/3] netfilter: nft_fib_ipv6: handle routes via external nexthop
Date: Wed, 20 May 2026 17:39:48 +0800 [thread overview]
Message-ID: <ccfd7143-0f0a-4578-a195-65b84ec00cfb@linux.dev> (raw)
In-Reply-To: <ag1-KRkLjQXHa6aJ@orbyte.nwl.cc>
On 5/20/26 5:26 PM, Phil Sutter wrote:
> Hi,
>
> On Wed, May 20, 2026 at 10:34:08AM +0800, Jiayuan Chen wrote:
>> Patch 1 switches the fib6_siblings walk in nft_fib6_info_nh_uses_dev()
>> to list_for_each_entry_rcu().
>>
>> Patch 2 fixes the slab-out-of-bounds when the matched route uses an
>> external nexthop object.
>>
>> Patch 3 adds a selftest covering single nh, nh group and old-style
>> multipath.
>>
>> v1: https://lore.kernel.org/netfilter-devel/20260519041431.396218-1-jiayuan.chen@linux.dev/
>>
>> Changes since v1:
>> - new patch 1: list_for_each_entry_rcu() conversion split out
>> (Suggested-by: Phil Sutter)
>> - patch 2:
>> * drop redundant ternary in nft_fib6_nh_match_dev_cb (Phil)
>> * drop redundant "!= 0" on nexthop_for_each_fib6_nh return (Phil)
>> * use READ_ONCE() for rt->fib6_nsiblings (Phil)
> Will you send a v3 addressing Florian's concerns regarding the test case
> in patch 3?
In the current version, the selftest has already incorporated Florian's
suggestion,that is,
to verify functionality rather than just serving as a bug reproducer
(using nf_ok/nf_bad counter).
Sorry for not making this clear in the changelog : ).
> Patches 1 and 2 look good to me, thanks for the respin!
Thank for your review.
> Cheers, Phil
next prev parent reply other threads:[~2026-05-20 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 2:34 [PATCH nf v2 0/3] netfilter: nft_fib_ipv6: handle routes via external nexthop Jiayuan Chen
2026-05-20 2:34 ` [PATCH nf v2 1/3] netfilter: nft_fib_ipv6: walk fib6_siblings under RCU Jiayuan Chen
2026-05-20 2:34 ` [PATCH nf v2 2/3] netfilter: nft_fib_ipv6: handle routes via external nexthop Jiayuan Chen
2026-05-20 2:34 ` [PATCH nf v2 3/3] selftests: netfilter: add nft_fib_nexthop test Jiayuan Chen
2026-05-20 9:26 ` [PATCH nf v2 0/3] netfilter: nft_fib_ipv6: handle routes via external nexthop Phil Sutter
2026-05-20 9:39 ` Jiayuan Chen [this message]
2026-05-20 10:48 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccfd7143-0f0a-4578-a195-65b84ec00cfb@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.