All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernd Kuhls <bernd.kuhls@t-online.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 06/18] package/opencv3: bump version to	3.1.0
Date: Mon, 28 Mar 2016 16:40:44 +0200	[thread overview]
Message-ID: <ccsnscxfrm.ln2@ID-313208.user.individual.net> (raw)
In-Reply-To: CAHXCMMKvEgV2MbMZFpUJVOad5D+Z_qszNkwKMe6D=RzL5Gp9sQ@mail.gmail.com

Am Sun, 27 Mar 2016 19:01:12 +0200 schrieb Samuel Martin:

> On Sun, Mar 27, 2016 at 5:53 PM, Bernd Kuhls
> <bernd.kuhls@t-online.de> wrote:
>> Hi Samuel,
>>
>> Am Sun, 27 Mar 2016 15:05:42 +0200 schrieb Samuel Martin:
>>
>>>> -       -DWITH_OPENGL=OFF \
>>>> -       -DWITH_OPENMP=OFF \
>>> AFAICS, these 2 options still exist (see [2,3]).
>>
>> Yes, and they are used later on in opencv3.mk:
>>
>> ifeq ($(BR2_PACKAGE_OPENCV3_WITH_OPENGL),y)
>> OPENCV3_CONF_OPTS += -DWITH_OPENGL=ON OPENCV3_DEPENDENCIES += libgl
>> else OPENCV3_CONF_OPTS += -DWITH_OPENGL=OFF endif
>>
>> OPENCV3_CONF_OPTS += -DWITH_OPENMP=$(if
>> $(BR2_GCC_ENABLE_OPENMP),ON,OFF)
>>
>> Is there a reason why they are disabled in the first place?
> Yes, there is reason ;-)
> 
> Opencv3 has been done correctly when upgrading from opencv2 [1] (as a
> replacement), then opencv has been renamed opencv3 [2] and opencv
> reverted back [3]... hence the desync. between these 2 packages...
> And since this, I have not taken the time to sync. opencv and opencv3
> packages... :-/

Hi Samuel,

even after your last explanation I do not understand why -DWITH_OPENGL
and -DWITH_OPENMP are present twice in opencv3.mk so I am going to repeat 
my question based on current buildroot git master:

In line 207 opengl support is disabled:
https://git.busybox.net/buildroot/tree/package/opencv3/opencv3.mk#n207
> 	-DWITH_OPENGL=OFF \

In line 271 this command is repeated
https://git.busybox.net/buildroot/tree/package/opencv3/opencv3.mk#n271
>OPENCV3_CONF_OPTS += -DWITH_OPENGL=OFF

  reply	other threads:[~2016-03-28 14:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-27  9:16 [Buildroot] [PATCH v2 00/18] Bump ffmpeg to 3.0 Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 01/18] package/kodi: add support for ffmpeg 3.0 Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 02/18] package/libdcadec: bump version to v0.2.0 Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 03/18] package/ortp: bump version to 0.25.0 Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 04/18] package/mediastreamer: bump version to 2.12.1 Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 05/18] package/opencv: bump version to 2.4.12.3 Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 06/18] package/opencv3: bump version to 3.1.0 Bernd Kuhls
2016-03-27 13:05   ` Samuel Martin
2016-03-27 15:53     ` Bernd Kuhls
2016-03-27 17:01       ` Samuel Martin
2016-03-28 14:40         ` Bernd Kuhls [this message]
2016-03-28 14:45           ` Bernd Kuhls
2016-03-28 14:49         ` Bernd Kuhls
2016-03-28 15:31           ` Samuel Martin
2016-03-27  9:16 ` [Buildroot] [PATCH v2 07/18] package/squeezelite: fix compilation with ffmpeg >= 2.9 Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 08/18] package/freerdp: bump version Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 09/18] package/vlc: mark as broken due to incompatibility with ffmpeg 3.0 Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 10/18] package/ffmpeg: bump to version 3.0 Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 11/18] package/ffmpeg: cosmetic change for the mips fpu option Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 12/18] package/ffmpeg: default to --cpu=generic for MIPS architecture Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 13/18] package/ffmpeg: Add patch required by Kodi 16.0-Jarvis Bernd Kuhls
2016-03-27  9:16 ` [Buildroot] [PATCH v2 14/18] package/x264: bump version Bernd Kuhls
2016-03-27  9:17 ` [Buildroot] [PATCH v2 15/18] package/x265: bump version to 1.9 Bernd Kuhls
2016-03-27  9:17 ` [Buildroot] [PATCH v2 16/18] package/dtv-scan-tables: bump version Bernd Kuhls
2016-03-27  9:17 ` [Buildroot] [PATCH v2 17/18] package/tvheadend: " Bernd Kuhls
2016-03-27  9:17 ` [Buildroot] [PATCH v2 18/18] package/live555: bump version to 2016.03.16 Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccsnscxfrm.ln2@ID-313208.user.individual.net \
    --to=bernd.kuhls@t-online.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.