From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 11/16] blk-mq: fold __blk_mq_try_issue_directly into its two callers
Date: Tue, 11 Apr 2023 11:04:22 -0700 [thread overview]
Message-ID: <cd010467-8ea6-3949-bd2e-e22252854668@acm.org> (raw)
In-Reply-To: <20230411133329.554624-12-hch@lst.de>
On 4/11/23 06:33, Christoph Hellwig wrote:
> Due the wildly different behavior beased on the bypass_insert
beased -> based
> argument not a whole lot of code in __blk_mq_try_issue_directly is
> actually shared between blk_mq_try_issue_directly and
> blk_mq_request_issue_directly. Remove __blk_mq_try_issue_directly and
> fold the code into the two callers instead.
Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2023-04-11 18:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 13:33 cleanup request insertation parameters Christoph Hellwig
2023-04-11 13:33 ` [PATCH 01/16] blk-mq: don't plug for head insertations in blk_execute_rq_nowait Christoph Hellwig
2023-04-11 17:41 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 02/16] blk-mq: move more logic into blk_mq_insert_requests Christoph Hellwig
2023-04-11 17:44 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 03/16] blk-mq: fold blk_mq_sched_insert_requests into blk_mq_dispatch_plug_list Christoph Hellwig
2023-04-11 17:45 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 04/16] blk-mq: move blk_mq_sched_insert_request to blk-mq.c Christoph Hellwig
2023-04-11 17:46 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 05/16] blk-mq: fold __blk_mq_insert_request into blk_mq_insert_request Christoph Hellwig
2023-04-11 17:49 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 06/16] blk-mq: fold __blk_mq_insert_req_list " Christoph Hellwig
2023-04-11 18:18 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 07/16] blk-mq: remove blk_flush_queue_rq Christoph Hellwig
2023-04-11 17:51 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 08/16] blk-mq: refactor passthrough vs flush handling in blk_mq_insert_request Christoph Hellwig
2023-04-11 17:54 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 09/16] blk-mq: refactor the DONTPREP/SOFTBARRIER andling in blk_mq_requeue_work Christoph Hellwig
2023-04-11 17:56 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 10/16] blk-mq: factor out a blk_mq_get_budget_and_tag helper Christoph Hellwig
2023-04-11 17:57 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 11/16] blk-mq: fold __blk_mq_try_issue_directly into its two callers Christoph Hellwig
2023-04-11 18:04 ` Bart Van Assche [this message]
2023-04-11 13:33 ` [PATCH 12/16] blk-mq: don't run the hw_queue from blk_mq_insert_request Christoph Hellwig
2023-04-11 18:07 ` Bart Van Assche
2023-04-11 13:33 ` [PATCH 13/16] blk-mq: don't run the hw_queue from blk_mq_request_bypass_insert Christoph Hellwig
2023-04-11 18:09 ` Bart Van Assche
2023-04-12 5:02 ` Christoph Hellwig
2023-04-11 13:33 ` [PATCH 14/16] blk-mq: pass a flags argument to blk_mq_insert_request Christoph Hellwig
2023-04-11 18:11 ` Bart Van Assche
2023-04-12 5:02 ` Christoph Hellwig
2023-04-11 13:33 ` [PATCH 15/16] blk-mq: pass a flags argument to blk_mq_request_bypass_insert Christoph Hellwig
2023-04-11 18:16 ` Bart Van Assche
2023-04-12 5:04 ` Christoph Hellwig
2023-04-11 13:33 ` [PATCH 16/16] blk-mq: pass the flags argument to elevator_type->insert_requests Christoph Hellwig
2023-04-11 18:13 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd010467-8ea6-3949-bd2e-e22252854668@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.