From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Li Han <han.li1@zte.com.cn>, thomas@monjalon.net
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue
Date: Wed, 23 Oct 2019 18:46:50 +0100 [thread overview]
Message-ID: <cd3129c8-7d08-a8b0-35f0-c028e99c8361@intel.com> (raw)
In-Reply-To: <1571827361-30578-1-git-send-email-han.li1@zte.com.cn>
On 23-Oct-19 11:42 AM, Li Han wrote:
> In rte_eal_config_reattach(),the secondary mmap may fail
> due to the rte_mem_cfg_addr already be used by others.do
> the change just as the rte_fbarray_init() do.if no
> base_virtaddr,use the default 0x100000000.
>
> v2/v3:
> -fix code style issues
>
> Signed-off-by: Li Han <han.li1@zte.com.cn>
> ---
Nack. There's a reason why we map it at the same address, and it's to
have all pointers working across processes. Remapping it at a different
address has potential to break things.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-10-23 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 10:42 [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue Li Han
2019-10-23 17:46 ` Burakov, Anatoly [this message]
2019-10-24 7:37 ` David Marchand
2019-10-24 8:30 ` [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime configmmap issue han.li1
2019-10-24 11:13 ` [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue Burakov, Anatoly
2019-10-24 11:23 ` David Marchand
2019-10-24 12:22 ` Burakov, Anatoly
2019-10-24 12:39 ` Burakov, Anatoly
2019-10-25 11:37 ` [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime configmmap issue han.li1
2019-10-25 12:20 ` Burakov, Anatoly
2019-10-26 16:07 ` David Marchand
2019-11-05 14:14 ` David Marchand
2019-11-13 7:38 ` David Marchand
2019-10-24 11:13 ` [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue Burakov, Anatoly
2019-10-24 12:38 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd3129c8-7d08-a8b0-35f0-c028e99c8361@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=han.li1@zte.com.cn \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.