All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm: socfpga: Remove static declaration on spl_mmc_find_device function
Date: Mon, 11 Dec 2017 12:03:56 +0100	[thread overview]
Message-ID: <cd352fce-eef0-22fd-c253-1f72cc90fa5d@denx.de> (raw)
In-Reply-To: <1512989626-4303-2-git-send-email-tien.fong.chee@intel.com>

On 12/11/2017 11:53 AM, tien.fong.chee at intel.com wrote:
> From: Tien Fong Chee <tien.fong.chee@intel.com>

So the tags would imply this has a lot to do with SoCFPGA, but this is
not touching any file in the SoCFPGA. The tags are thus completely bogus.

> This patch removes the static declation on spl_mmc_find_device_function
> so this function is accessible by the caller from other file. This patch
> is required for later patch.
> 
> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> ---
>  common/spl/spl_mmc.c | 2 +-
>  include/spl.h        | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
> index b57e0b0..183d05a 100644
> --- a/common/spl/spl_mmc.c
> +++ b/common/spl/spl_mmc.c
> @@ -114,7 +114,7 @@ static int spl_mmc_get_device_index(u32 boot_device)
>  	return -ENODEV;
>  }
>  
> -static int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device)
> +int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device)
>  {
>  #if CONFIG_IS_ENABLED(DM_MMC)
>  	struct udevice *dev;
> diff --git a/include/spl.h b/include/spl.h
> index 308ce7b..912983a 100644
> --- a/include/spl.h
> +++ b/include/spl.h
> @@ -10,6 +10,7 @@
>  /* Platform-specific defines */
>  #include <linux/compiler.h>
>  #include <asm/spl.h>
> +#include <mmc.h>
>  
>  /* Value in r0 indicates we booted from U-Boot */
>  #define UBOOT_NOT_LOADED_FROM_SPL	0x13578642
> @@ -72,6 +73,7 @@ void preloader_console_init(void);
>  u32 spl_boot_device(void);
>  u32 spl_boot_mode(const u32 boot_device);
>  void spl_set_bd(void);
> +int spl_mmc_find_device(struct mmc **mmcp, u32 boot_device);
>  
>  /**
>   * spl_set_header_raw_uboot() - Set up a standard SPL image structure
> 


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2017-12-11 11:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 10:53 [U-Boot] [PATCH 0/2] Generic firmware loader tien.fong.chee at intel.com
2017-12-11 10:53 ` [U-Boot] [PATCH 1/2] arm: socfpga: Remove static declaration on spl_mmc_find_device function tien.fong.chee at intel.com
2017-12-11 11:03   ` Marek Vasut [this message]
2017-12-12  4:49     ` Chee, Tien Fong
2017-12-11 10:53 ` [U-Boot] [PATCH 2/2] common: Generic firmware loader for file system tien.fong.chee at intel.com
2017-12-11 12:16   ` Lothar Waßmann
2017-12-12  4:51     ` Chee, Tien Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd352fce-eef0-22fd-c253-1f72cc90fa5d@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.