From: Steve Longerbeam <slongerbeam@gmail.com>
To: jacopo mondi <jacopo@jmondi.org>,
Steve Longerbeam <slongerbeam@gmail.com>
Cc: mchehab@kernel.org, laurent.pinchart@ideasonboard.com,
maxime.ripard@bootlin.com, sam@elite-embedded.com,
jagan@amarulasolutions.com, festevam@gmail.com,
pza@pengutronix.de, hugues.fruchet@st.com,
loic.poulain@linaro.org, daniel@zonque.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 0/2] media: i2c: ov5640: Re-work MIPI startup sequence
Date: Tue, 14 Aug 2018 09:51:04 -0700 [thread overview]
Message-ID: <cd3e2e96-0968-99cd-1417-05ffdd771341@gmail.com> (raw)
In-Reply-To: <20180814153559.GA16428@w540>
Hi Jacopo,
On 08/14/2018 08:35 AM, jacopo mondi wrote:
> Hi Steve,
> sorry for resurecting this.
>
> <snip>
>>> I'm sorry I'm not sur I'm following. Does this mean that with that bug
>>> you are referring to up here fixed by my last patch you have capture
>>> working?
>> No, capture still not working for me on SabreSD, even after fixing
>> the bug in 476dec0 "media: ov5640: Add horizontal and vertical totals",
>> by either using your patchset, or by running version 476dec0 of ov5640.c
>> with the call to ov5640_set_timings() moved to the correct places as
>> described below.
>>
> I've been reported a bug on exposure handling that makes the first
> captured frames all black. Both me and Hugues have tried to fix the
> issue (him with a more complete series, but that's another topic).
> See [1] and [2]
>
> It might be possible that you're getting blank frames with this series
> applied? I never seen them as I'm skipping the first frames when
> capturing, but I've now tested and without the exposure fixes (either
> [1] or [2]) I actually have blank frames.
>
> If that's the case for you too (which I hope so much) would you be
> available to test again this series with exposure fixes on top?
> On my platform that actually makes all frames correct.
>
> Thanks
> j
>
> [1] [PATCH 0/2] media: ov5640: Fix set_timings and auto-exposure
> [2] [PATCH v2 0/5] Fix OV5640 exposure & gain
>
It's not clear to me which patch sets you would like me to test.
Just [1] and [2], or [1], [2], and "media: i2c: ov5640: Re-work MIPI
startup sequence"?
Steve
next prev parent reply other threads:[~2018-08-14 19:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 18:36 [PATCH v2 0/2] media: i2c: ov5640: Re-work MIPI startup sequence Jacopo Mondi
2018-07-10 18:36 ` [PATCH v2 1/2] " Jacopo Mondi
2018-07-10 18:36 ` [PATCH v2 2/2] media: ov5640: Fix timings setup code Jacopo Mondi
2018-07-10 21:10 ` [PATCH v2 0/2] media: i2c: ov5640: Re-work MIPI startup sequence Steve Longerbeam
2018-07-11 7:21 ` jacopo mondi
2018-07-14 18:57 ` Steve Longerbeam
2018-07-14 19:41 ` Steve Longerbeam
2018-07-14 20:02 ` Steve Longerbeam
2018-07-16 8:29 ` jacopo mondi
2018-07-16 16:26 ` Steve Longerbeam
2018-08-14 15:35 ` jacopo mondi
2018-08-14 16:51 ` Steve Longerbeam [this message]
2018-08-14 17:38 ` jacopo mondi
2018-08-14 23:53 ` Steve Longerbeam
2018-08-15 9:00 ` jacopo mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd3e2e96-0968-99cd-1417-05ffdd771341@gmail.com \
--to=slongerbeam@gmail.com \
--cc=daniel@zonque.org \
--cc=festevam@gmail.com \
--cc=hugues.fruchet@st.com \
--cc=jacopo@jmondi.org \
--cc=jagan@amarulasolutions.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=pza@pengutronix.de \
--cc=sam@elite-embedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.