Re: [OE-core] [PATCH] cargo-update-recipe-crates: Don't fail for partially empty Cargo.lock

[Martin Schwan <M.Schwan@phytec.de>]

On Tue, 2025-11-25 at 11:23 +0100, Alexander Kanavin wrote:
> On Tue, 25 Nov 2025 at 10:01, Martin Schwan via
> lists.openembedded.org
> <m.schwan=phytec.de@lists.openembedded.org> wrote:
> > 
> > Do not fail if only some Cargo.lock files are empty. Only fail, if
> > there
> > are absolutely no dependencies found in any Cargo.lock.
> 
> ...
> 
> > While at it, restructure do_update_crates() to be a real Python
> > function
> > and use the corresponding code directly inline.
> 
> This, as a diff on the mailing list, is incredibly hard to review,
> and
> needs to be split up. Refactoring in one commit (explaining the
> benefits), functional changes in another please. Even better if you
> can split things further, and explain what the particular
> modifications are (rather than use terms like 'restructure').

Thanks for the feedback. Admittedly, I was a bit lazy with this one, as
the changes were quite interwoven. I'll send a v2 and split things up,
as best as I can.

Regards,
Martin

> 
> Aelx