All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>
Cc: dev@dpdk.org, ciara.power@intel.com
Subject: Re: [PATCH v2] doc: update guideline for fix commit messages
Date: Wed, 31 Jan 2024 02:14:06 +0000	[thread overview]
Message-ID: <cd48fb5e-fa88-4e6c-9dd9-458ef30fcf35@amd.com> (raw)
In-Reply-To: <20240130140925.2045961-1-venkatx.sivaramakrishnan@intel.com>

On 1/30/2024 2:09 PM, Sivaramakrishnan Venkat wrote:
> Maintainers remove the Cc author line when merging the patch.
> So, the guidelines is updated with a suggestion for the placement
> of Cc lines in a commit message for easy merging.
> 
> Signed-off-by: Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>
> ---
> v2:
>    - Samples updated to the desired format for the "Cc:" line in the commit message
> ---
>  doc/guides/contributing/patches.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
> index e286d9e6d5..5687b5fa27 100644
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> @@ -271,9 +271,10 @@ Here are some guidelines for the body of a commit message:
>       Update the docs, fixing description of some parameter.
>  
>       Fixes: abcdefgh1234 ("doc: add some parameter")
> -     Cc: author@example.com
>  
>       Signed-off-by: Alex Smith <alex.smith@example.com>
> +     ---
> +     Cc: author@example.com
>  
>  * When fixing an error or warning it is useful to add the error message and instructions on how to reproduce it.
>  

There are multiple sample that has "Cc: author@example.com" line, can
you please update all for consistency?


  reply	other threads:[~2024-01-31  2:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25  3:39 [PATCH v1] doc: update guideline for fix commit messages Sivaramakrishnan Venkat
2024-01-25 11:24 ` Ferruh Yigit
2024-01-30 14:09 ` [PATCH v2] " Sivaramakrishnan Venkat
2024-01-31  2:14   ` Ferruh Yigit [this message]
2024-02-01 13:48 ` [PATCH v3] " Sivaramakrishnan Venkat
2024-02-06 15:12   ` Ferruh Yigit
2024-02-08 10:51 ` [PATCH v4] " Sivaramakrishnan Venkat
2024-02-08 11:36   ` Ferruh Yigit
2024-03-20  9:59     ` Power, Ciara
2024-03-24 23:38       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd48fb5e-fa88-4e6c-9dd9-458ef30fcf35@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    --cc=venkatx.sivaramakrishnan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.