All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Garg, Shivank" <shivankg@amd.com>
To: "pbonzini@redhat.com" <pbonzini@redhat.com>,
	"seanjc@google.com" <seanjc@google.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] KVM: selftests: Skip xAPIC IPI migration test when forced but unsupported
Date: Sun, 6 Sep 2026 18:13:47 +0000	[thread overview]
Message-ID: <cd4e0e3e149b41887d0350845016743f5f24065c.camel@amd.com> (raw)
In-Reply-To: <20260903001625.2792367-8-seanjc@google.com>

On Wed, 2026-09-02 at 17:16 -0700, Sean Christopherson wrote:
> Skip the xAPIC IPI migration test instead of failing outright if migration
> is forced by the user, but is unsupported due to lack of NUMA support.
> Failing the test is arguably "fine" for opt-in behavior, but in practice
> doesn't allow running the test in forced-migration mode in any kind of
> automated test environment.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  tools/testing/selftests/kvm/x86/xapic_ipi_test.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/x86/xapic_ipi_test.c b/tools/testing/selftests/kvm/x86/xapic_ipi_test.c
> index c5b506eb5e7f..2362bf272e80 100644
> --- a/tools/testing/selftests/kvm/x86/xapic_ipi_test.c
> +++ b/tools/testing/selftests/kvm/x86/xapic_ipi_test.c
> @@ -469,8 +469,9 @@ int main(int argc, char *argv[])
>  	if (kvm_get_numa_memory_nodes(&nodemask) > 1)
>  		test_xapic_ipi(run_secs, delay_usecs, true);
>  	else
> -		TEST_ASSERT(!force_migrate,
> -			    "Did not find at least 2 numa nodes. Can't do migration");
> +		__TEST_REQUIRE(!force_migrate,
> +			       "Need at least 2 NUMA nodes to do migration (nodemask = 0x%lx)",
> +			       nodemask);
>  
>  	return 0;
>  }


Reviewed-by: Shivank Garg <shivankg@amd.com>

Thanks,
Shivank


  reply	other threads:[~2026-09-06 18:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  0:16 [PATCH 0/7] KVM: selftests: Fix maxnodes bugs and cleanup related code Sean Christopherson
2026-09-03  0:16 ` [PATCH 1/7] KVM: selftests: Account for kernel's off-by-one bug in NUMA node syscalls Sean Christopherson
2026-09-06 10:08   ` Garg, Shivank
2026-09-03  0:16 ` [PATCH 2/7] KVM: selftests: Fix maxnode argument to migrate_pages() in xapic_ipi_test Sean Christopherson
2026-09-03  0:16 ` [PATCH 3/7] KVM: selftests: use BITS_PER_TYPE() for NUMA masks Sean Christopherson
2026-09-03  0:16 ` [PATCH 4/7] KVM: selftests: Compute node masks on-demand in xAPIC IPI test Sean Christopherson
2026-09-06 17:05   ` Garg, Shivank
2026-09-03  0:16 ` [PATCH 5/7] KVM: selftests: Add common helper to get mask+number of usable memory NUMA nodes Sean Christopherson
2026-09-06 17:53   ` Garg, Shivank
2026-09-03  0:16 ` [PATCH 6/7] KVM: selftests: Automatically run xAPIC IPI migration test when possible Sean Christopherson
2026-09-06 18:01   ` Garg, Shivank
2026-09-03  0:16 ` [PATCH 7/7] KVM: selftests: Skip xAPIC IPI migration test when forced but unsupported Sean Christopherson
2026-09-06 18:13   ` Garg, Shivank [this message]
2026-09-21 14:05 ` [PATCH 0/7] KVM: selftests: Fix maxnodes bugs and cleanup related code Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd4e0e3e149b41887d0350845016743f5f24065c.camel@amd.com \
    --to=shivankg@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.