From: Joonwoo Park <joonwoop@codeaurora.org>
To: Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL] Re: [PATCH 08/15] perf tools: Introduce timestamp_in_usec()
Date: Fri, 28 Oct 2016 10:46:42 -0700 [thread overview]
Message-ID: <cd4fbbd6-9250-4f21-2faf-1503ceef2f36@codeaurora.org> (raw)
In-Reply-To: <20161028173955.GA24588@gmail.com>
On 10/28/2016 10:39 AM, Ingo Molnar wrote:
>
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
>> Em Fri, Oct 28, 2016 at 11:30:41AM -0200, Arnaldo Carvalho de Melo escreveu:
>>> Em Fri, Oct 28, 2016 at 10:53:38AM -0200, Arnaldo Carvalho de Melo escreveu:
>>>> Em Thu, Oct 27, 2016 at 04:14:55PM -0700, Joonwoo Park escreveu:
>>>>> Hmm.. I didn't ACK this patch because of bug I commented at
>>>>> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256724.html
>>
>>>>> s/work_list->max_lat/work_list->max_lat_at/
>>
>>>> Sorry about that, I took the "thanks for taking care of this" as an ack,
>>>> now that I re-read that message I saw your points later on in that
>>>> e-mail.
No worries. I think I could be more specific with the first part of
comment by mentioning about the bug.
>>
>>>> Since Ingo hasn't pulled this, I'll try fixing it, will check that other
>>>> naming issue,
>>
>>> So, here is how it ended up, it fixes the problem you pointed out and
>>> renames the function to follow the scnprintf() convention, as used
>>> elsewhere in tools/perf (tools/perf/util/annotate.h has several
>>> examples).
>>
>> Ingo, I've just signed a perf-core-for-mingo-20161028 with the only
>> change being the patch below, re-run my tests, I think this doesn't
>> introduce any bugs and addresses Joonwoo's concerns, please consider
>> pulling.
>
> Pulled, thanks a lot Arnaldo!
Thanks!
Joonwoo
>
> Ingo
>
next prev parent reply other threads:[~2016-10-28 17:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 01/15] perf bench futex: Avoid worker cacheline bouncing Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 02/15] perf bench futex: Sanitize numeric parameters Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 03/15] perf hist browser: Fix hierarchy column counts Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 04/15] tools lib subcmd: Suppport cascading options Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 05/15] perf sched: Make common options cascading Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 06/15] perf sched map: Apply cpu color when there's an activity Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 07/15] perf sched map: Always show task comm with -v Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 08/15] perf tools: Introduce timestamp_in_usec() Arnaldo Carvalho de Melo
2016-10-27 23:14 ` Joonwoo Park
2016-10-28 12:53 ` Arnaldo Carvalho de Melo
2016-10-28 13:30 ` Arnaldo Carvalho de Melo
2016-10-28 14:42 ` [GIT PULL] " Arnaldo Carvalho de Melo
2016-10-28 17:39 ` Ingo Molnar
2016-10-28 17:46 ` Joonwoo Park [this message]
2016-10-27 20:40 ` [PATCH 09/15] perf list: Support matching by topic Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 10/15] perf bench mem: Ignore export.h related changes to mem{cpy,set}.S Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 11/15] tools: Update asm-generic/mman-common.h copy from the kernel Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 12/15] perf tools: Update x86's syscall_64.tbl, adding pkey_(alloc,free,mprotect) Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 13/15] perf scripting: Avoid leaking the scripting_context variable Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 14/15] perf scripting: Don't die if scripting can't be setup, disable it Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 15/15] perf tools: Add missing object file to the python binding linkage list Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd4fbbd6-9250-4f21-2faf-1503ceef2f36@codeaurora.org \
--to=joonwoop@codeaurora.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.