From: vgarodia@codeaurora.org
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexandre Courbot <acourbot@chromium.org>,
Mansur Alisha Shaik <mansur@codeaurora.org>
Subject: Re: [PATCH 0/3] Venus dynamic resolution change fixes
Date: Thu, 08 Oct 2020 01:33:56 +0530 [thread overview]
Message-ID: <cd91071c76f8f2151fdcd70a16c19edf@codeaurora.org> (raw)
In-Reply-To: <20200928164431.21884-1-stanimir.varbanov@linaro.org>
Hi Stan,
On 2020-09-28 22:14, Stanimir Varbanov wrote:
> Hi all,
>
> Those three patches are needed to fix setting of LAST buffer flag
> during
> dynamic-resolution-change state.
>
> The first patch in this series fix the LAST buffer flag setting, the
> second
> unify the driver behavior no matter the event from firmware is
> sufficient or
> insufficient resources and the third one is moving the locking from
> buf_queue
> helper function to encoder and decoder buf_queue vb2 ops.
>
> Comments are welcome!
>
> Stanimir Varbanov (3):
> venus: vdec: Fix non reliable setting of LAST flag
> venus: vdec: Make decoder return LAST flag for sufficient event
> venus: helpers: Lock outside of buffer queue helper
>
> drivers/media/platform/qcom/venus/core.h | 5 +-
> drivers/media/platform/qcom/venus/helpers.c | 15 ++--
> drivers/media/platform/qcom/venus/vdec.c | 92 +++++++++++++--------
> drivers/media/platform/qcom/venus/venc.c | 11 ++-
> 4 files changed, 76 insertions(+), 47 deletions(-)
I have made some comments which are more towards optimizing the reconfig
event
handling in the driver. I would leave that up to you to either update in
this series
or take it separately. Either way, i am good with this series.
Reviewed-by: Vikash Garodia <vgarodia@codeaurora.org>
prev parent reply other threads:[~2020-10-07 20:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 16:44 [PATCH 0/3] Venus dynamic resolution change fixes Stanimir Varbanov
2020-09-28 16:44 ` [PATCH 1/3] venus: vdec: Fix non reliable setting of LAST flag Stanimir Varbanov
2020-10-09 12:45 ` Alexandre Courbot
2020-10-09 23:28 ` Stanimir Varbanov
2020-10-09 12:56 ` Alexandre Courbot
2020-10-09 15:53 ` Stanimir Varbanov
2020-09-28 16:44 ` [PATCH 2/3] venus: vdec: Make decoder return LAST flag for sufficient event Stanimir Varbanov
2020-10-07 19:53 ` vgarodia
2020-10-10 1:21 ` Stanimir Varbanov
2020-09-28 16:44 ` [PATCH 3/3] venus: helpers: Lock outside of buffer queue helper Stanimir Varbanov
2020-10-07 20:03 ` vgarodia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd91071c76f8f2151fdcd70a16c19edf@codeaurora.org \
--to=vgarodia@codeaurora.org \
--cc=acourbot@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mansur@codeaurora.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.