From: John Garry <john.g.garry@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH v2] block: Use enum for blk-mq tagset flags
Date: Fri, 3 Jan 2025 08:38:10 +0000 [thread overview]
Message-ID: <cd96ea21-056f-44fd-a4b1-ade01182a8f6@oracle.com> (raw)
In-Reply-To: <20250103082723.GA30419@lst.de>
On 03/01/2025 08:27, Christoph Hellwig wrote:
> On Fri, Jan 03, 2025 at 08:23:02AM +0000, John Garry wrote:
>> - better to not have unused gaps
> Who cares?
it's not that important, as long as it the flags are properly ordered
and it's obvious where the gaps are
> >> - catch missing blk-mq debugfs array names
>> - this has been a problem in the past
> Again who really cares?
People who use blk-mq debugfs
And maybe the maintainer when we have the tedious routine of a new flag
being added but the debugfs entry being missed and then the follow on
patch (to add the entry).
>
>> Cons:
>> - boilerplate
Anyway, I feel too strongly about all of this.
next prev parent reply other threads:[~2025-01-03 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 14:44 [PATCH v2] block: Use enum for blk-mq tagset flags John Garry
2025-01-03 6:44 ` Christoph Hellwig
2025-01-03 8:23 ` John Garry
2025-01-03 8:27 ` Christoph Hellwig
2025-01-03 8:38 ` John Garry [this message]
2025-01-03 15:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd96ea21-056f-44fd-a4b1-ade01182a8f6@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.