From: Segher Boessenkool <segher@kernel.crashing.org>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org, Doug Thompson <dougthompson@xmission.com>
Subject: Re: [PATCH] [POWERPC] pasemi: Broaden specific references to 1682M
Date: Tue, 6 Nov 2007 02:42:08 +0100 [thread overview]
Message-ID: <cd9a9e67893406e486d2ffc7599e28b7@kernel.crashing.org> (raw)
In-Reply-To: <20071105032802.GA16613@lixom.net>
Hi Olof,
Nice cleanup! One minor thing...
> static struct of_device_id pasemi_bus_ids[] = {
> + /* Unfortunately needed for legacy firmwares */
> { .type = "localbus", },
> { .type = "sdc", },
> + { .compatible = "pasemi,localbus", },
> + { .compatible = "pasemi,sdc", },
The new comment is for the device_type entries only, right? You
might want to make that more clear.
Segher
next prev parent reply other threads:[~2007-11-06 1:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 3:28 [PATCH] [POWERPC] pasemi: Broaden specific references to 1682M Olof Johansson
2007-11-05 12:55 ` Michael Buesch
2007-11-05 18:57 ` Doug Thompson
2007-11-05 19:22 ` Olof Johansson
2007-11-06 1:42 ` Segher Boessenkool [this message]
2007-11-06 2:01 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd9a9e67893406e486d2ffc7599e28b7@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dougthompson@xmission.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.