From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [dm-devel] [PATCH] bio: have bio_kmap_irq return the size of mapped data (fwd) Date: Wed, 8 Nov 2017 11:08:13 -0700 Message-ID: References: <20171108094730.GA7074@infradead.org> <20171108150559.GB10374@infradead.org> <650d7a0d-f344-155a-5b53-4ce368c4aca4@kernel.dk> <20171108153436.GA24548@infradead.org> <20171108180358.GA6724@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171108180358.GA6724@infradead.org> Content-Language: en-US Sender: linux-block-owner@vger.kernel.org To: Christoph Hellwig Cc: Mikulas Patocka , linux-block@vger.kernel.org, dm-devel@redhat.com List-Id: dm-devel.ids On 11/08/2017 11:03 AM, Christoph Hellwig wrote: > On Wed, Nov 08, 2017 at 08:36:25AM -0700, Jens Axboe wrote: >> On 11/08/2017 08:34 AM, Christoph Hellwig wrote: >>> On Wed, Nov 08, 2017 at 08:20:58AM -0700, Jens Axboe wrote: >>>> On top of that, there are no users of it at all... >>> >>> But Mikulas wants to add one :) >> >> I know... >> >>> Note that __bio_kmap_atomic has the same issues, only has a single >>> users either and would be cleaner if opencoded there as it already >>> has the current bvec. See patch below. >> >> Kill them all with fire. The open coded version is much clearer. > > Feel free to throw the patch in under either your or my name. I'll do a combo. Just checking if it's OK I add your signed-off-by to the patch, I don't want something with you as an author, but not having an SOB. -- Jens Axboe