From: Moinak Bhattacharyya <moinakb001@gmail.com>
To: Amir Goldstein <amir73il@gmail.com>, Bernd Schubert <bernd@bsbernd.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
io-uring@vger.kernel.org
Subject: Re: [PATCH] Fuse: Add backing file support for uring_cmd
Date: Sat, 22 Feb 2025 16:33:08 -0600 [thread overview]
Message-ID: <cda3cf68-6ed1-4e06-b29a-ce5aee34ec20@gmail.com> (raw)
In-Reply-To: <CAOQ4uxgNyKL9-PqDPjZsXum-1+YNwOcj=jhGCYmhrhr2JcCjNw@mail.gmail.com>
> Without CONFIG_FUSE_PASSTHROUGH, fuse/passthrough.c
> is compiled out, so the check cannot be moved into fuse_backing_*
> we'd need inline helpers that return -EOPNOTSUPP when
> CONFIG_FUSE_PASSTHROUGH is not defined.
> I don't mind, but I am not sure this is justified (yet).
Sent out a review for this. IMO even without multiple use sites, the
static inline helper method seems cleaner to me. I'm ok if we don't want
it, but I really do think it would make our lives easier.
next prev parent reply other threads:[~2025-02-22 22:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 15:19 [PATCH] Fuse: Add backing file support for uring_cmd Moinak Bhattacharyya
2025-02-21 15:24 ` Bernd Schubert
2025-02-21 15:36 ` Moinak Bhattacharyya
2025-02-21 16:14 ` Bernd Schubert
2025-02-21 16:17 ` Bernd Schubert
2025-02-21 16:35 ` Amir Goldstein
2025-02-21 17:24 ` Bernd Schubert
2025-02-22 22:33 ` Moinak Bhattacharyya [this message]
2025-02-21 16:24 ` Amir Goldstein
2025-02-21 17:13 ` Bernd Schubert
2025-02-21 17:25 ` Amir Goldstein
2025-02-21 17:44 ` Bernd Schubert
2025-02-21 18:13 ` Moinak Bhattacharyya
2025-02-21 18:14 ` Moinak Bhattacharyya
2025-02-21 18:21 ` Amir Goldstein
2025-02-22 22:13 ` Moinak Bhattacharyya
2025-02-21 18:23 ` Bernd Schubert
2025-02-21 18:31 ` Amir Goldstein
2025-02-24 12:08 ` Miklos Szeredi
2025-02-24 16:06 ` Moinak Bhattacharyya
2025-02-24 16:24 ` Miklos Szeredi
2025-02-24 12:27 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cda3cf68-6ed1-4e06-b29a-ce5aee34ec20@gmail.com \
--to=moinakb001@gmail.com \
--cc=amir73il@gmail.com \
--cc=bernd@bsbernd.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.