All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: Philip Richard Oberfichtner <pro@denx.de>, u-boot@lists.denx.de
Cc: sjg@chromium.org, trini@konsulko.com
Subject: Re: [PATCH v3 1/3] bootcount: Remove legacy I2C driver
Date: Tue, 31 Oct 2023 09:06:58 +0100	[thread overview]
Message-ID: <cdaada91-ba1e-542d-72e7-b1459a9613bc@denx.de> (raw)
In-Reply-To: <20231031073844.15683-4-pro@denx.de>

Hello Philip,

On 31.10.23 08:38, Philip Richard Oberfichtner wrote:
> The legacy I2C bootcounter will hereby be removed and eventually
> be replaced by a driver model implementation in the follow-up commit.
> 
> The legacy driver has the following drawbacks:
> 	- It's not adhering to the driver model
> 	- Settings are grabbed from Kconfig rather than device tree
> 	- i2c_{read,write} are being used instead of dm_i2c_{read,write}
> 
> Signed-off-by: Philip Richard Oberfichtner <pro@denx.de>
> ---
> 
> Notes:
>     Changes in v3: none
>     Changes in v2: none
> 
>  drivers/bootcount/Kconfig         | 24 +++--------------
>  drivers/bootcount/Makefile        |  1 -
>  drivers/bootcount/bootcount_i2c.c | 43 -------------------------------
>  3 files changed, 3 insertions(+), 65 deletions(-)
>  delete mode 100644 drivers/bootcount/bootcount_i2c.c

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de

  reply	other threads:[~2023-10-31  8:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31  7:38 [PATCH v3 0/3] bootcount: Replace I2C legacy implementation by driver model Philip Richard Oberfichtner
2023-10-31  7:38 ` [PATCH v3 1/3] bootcount: Remove legacy I2C driver Philip Richard Oberfichtner
2023-10-31  8:06   ` Heiko Schocher [this message]
2023-11-02 14:07   ` Heiko Schocher
2023-10-31  7:38 ` [PATCH v3 2/3] i2c: Implement i2c_get_chip_by_phandle() Philip Richard Oberfichtner
2023-10-31  8:07   ` Heiko Schocher
2023-11-02 14:07   ` Heiko Schocher
2023-10-31  7:38 ` [PATCH v3 3/3] bootcount: Add driver model I2C driver Philip Richard Oberfichtner
2023-10-31  8:07   ` Heiko Schocher
2023-11-02 14:08   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdaada91-ba1e-542d-72e7-b1459a9613bc@denx.de \
    --to=hs@denx.de \
    --cc=pro@denx.de \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.