Re: [Buildroot] [PATCH 3/4] package/gnu-efi: fix build due to short-wchar

[Julien Olivain <ju.o@free.fr>]

On 19/01/2025 09:45, Thomas Petazzoni via buildroot wrote:
> The gnu-efi code base is so far built with -fshort-wchar:
> 
> ‘-fshort-wchar’
>      Override the underlying type for ‘wchar_t’ to be ‘short unsigned
>      int’ instead of the default for the target.  This option is useful
>      for building programs to run under WINE.
> 
>      *Warning:* the ‘-fshort-wchar’ switch causes GCC to generate code
>      that is not binary compatible with code generated without that
>      switch.  Use it to conform to a non-default application binary
>      interface.
> 
> However, this is highly incompatible with the definitions of wchar_t
> by musl, causing build issues:
> 
> /workdir/instance-0/output-1/build/gnu-efi-3.0.18//lib/console.c:84:68: 
> error: passing argument 2 of 'ConOut->OutputString' from incompatible 
> pointer type [-Werror=incompatible-pointer-types]
> [...]
> /workdir/instance-0/output-1/build/gnu-efi-3.0.18//lib/console.c:84:68: 
> note: expected 'CHAR16 *' {aka 'int *'} but argument is of type 'short 
> unsigned int *'
> 
> These have been addressed upstream by simply not using -fshort-wchar
> anymore, so we backport the relevant patches.
> 
> The patch 0003-Use-char16_t-literals.patch was directly backported, it
> was "redone" (it's a very mechanical patch) as backporting the patch
> and fixing the conflicts was more effort than redoing the patch from
> scratch. But in essence, it is the same patch as what is upstream.
> 
> Fixes:
> 
>   
> http://autobuild.buildroot.net/results/8b2f5b38284e70dde8c5619e5050e7f201a0bcc3/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot