From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11FA6C00145 for ; Mon, 12 Dec 2022 13:22:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232663AbiLLNWa (ORCPT ); Mon, 12 Dec 2022 08:22:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232724AbiLLNVy (ORCPT ); Mon, 12 Dec 2022 08:21:54 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 21D62B7D6; Mon, 12 Dec 2022 05:21:49 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 35A961FB; Mon, 12 Dec 2022 05:22:29 -0800 (PST) Received: from [10.57.88.235] (unknown [10.57.88.235]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C6EA3F71E; Mon, 12 Dec 2022 05:21:43 -0800 (PST) Message-ID: Date: Mon, 12 Dec 2022 13:21:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 6/9] arm64: dts: allwinner: fix touchscreen reset GPIO polarity To: Samuel Holland , Quentin Schulz , Quentin Schulz Cc: linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Bastien Nocera , =?UTF-8?Q?Guido_G=c3=bcnther?= , Sascha Hauer , Pengutronix Kernel Team , Angus Ainslie , Ondrej Jirman , Icenowy Zheng , Andy Gross , Aleksei Mamlin , Fabio Estevam , David Jander , Frieder Schrempf , Bjorn Andersson , Konrad Dybcio , Peter Geis , Heiko Stuebner , Shawn Guo , Jernej Skrabec , Lukasz Majewski , AngeloGioacchino Del Regno , Chen-Yu Tsai , Michael Riesch , Rob Herring , NXP Linux Team , Dmitry Torokhov , Hans de Goede , Jagan Teki , Krzysztof Kozlowski References: <20221103-upstream-goodix-reset-v3-0-0975809eb183@theobroma-systems.com> <20221103-upstream-goodix-reset-v3-6-0975809eb183@theobroma-systems.com> <48329048-880d-02d6-0384-abdfa4c61c46@sholland.org> Content-Language: en-GB From: Robin Murphy In-Reply-To: <48329048-880d-02d6-0384-abdfa4c61c46@sholland.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2022-12-12 06:32, Samuel Holland wrote: > Hi Quentin, > > On 12/6/22 05:11, Quentin Schulz wrote: >> On 12/6/22 01:26, Samuel Holland wrote: >>> On 12/5/22 07:40, Quentin Schulz wrote: >>>> From: Quentin Schulz >>>> >>>> The reset line is active low for the Goodix touchscreen controller so >>>> let's fix the polarity in the Device Tree node. >>>> >>>> Signed-off-by: Quentin Schulz >>>> --- >>>>   arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts       | >>>> 2 +- >>>>   arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts | >>>> 2 +- >>>>   arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi          | >>>> 2 +- >>>>   arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts             | >>>> 2 +- >>>>   4 files changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git >>>> a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts >>>> b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts >>>> index 8233582f62881..5fd581037d987 100644 >>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts >>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts >>>> @@ -122,7 +122,7 @@ touchscreen@5d { >>>>           interrupt-parent = <&pio>; >>>>           interrupts = <7 4 IRQ_TYPE_EDGE_FALLING>; >>>>           irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>;    /* CTP-INT: PH4 */ >>>> -        reset-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>;    /* CTP-RST: >>>> PH8 */ >>>> +        reset-gpios = <&pio 7 8 GPIO_ACTIVE_LOW>;    /* CTP-RST: PH8 */ >>> >>> You are changing the DT binding here, in a way that breaks backward >>> compatibility with existing devicetrees. NACK. >>> >> >> Yes. >> >> Some boards will get their DT binding broken, there's no way around it >> sadly. >> >> We know already that the PRT8MM DT binding was written with a different >> understanding than for other boards. There are some board schematics I >> don't have access to so maybe the same applies to those. >> >> A reminder that even if you got your polarity wrong, it could still work >> in some cases (timings right today but nothing guaranteed it'll stay >> this way forever). >> >> with the current driver, what I assume we should get for an "incorrect" >> polarity (with GPIO_ACTIVE_LOW) is: >>             ___________________ >> INT _______|                   |___________ >> >>     ____________           __________________ >> RST             |_________| >> >>    ^ >>    L__ pull-up on RST so high by default >>         ^ >>         L___ gpiod_direction_output(0) (deassert GPIO active-low, so high) >>            ^ >>            L____ goodix_irq_direction_output >>                 ^ >>                 L___ gpiod_direction_output(1) (assert GPIO active-low, >> so low) >>                           ^ >>                           L____ gpiod_direction_input() (floating, >> pull-up on RST so high) >> >> This works because of the pull-up on RST and that what matters is that >> the INT lane is configured 100µs before a rising edge on RST line (for >> at least 5ms). However, the init sequence is not properly followed and >> might get broken in the future since it is not something that we >> explicitly support. > > We as platform DT/binding maintainers explicitly support compatibility > with existing devicetrees, whether those devicetrees are "correct" or > not. If a new version of Linux does not work with an old DT, that is a > regression in Linux. > >> With the proposed patch: >>             ___________________ >> INT _______|                   |___________ >> >>     ____         __________________ >> RST     |_______| >> >>    ^ >>    L__ pull-up on RST so high by default >>         ^ >>         L___ gpiod_direction_output(1) (assert GPIO active-low, so low) >>            ^ >>            L____ goodix_irq_direction_output >>                 ^ >>                 L___ gpiod_direction_output(1) (deassert GPIO >> active-low, so high) >>                           ^ >>                           L____ gpiod_direction_input() (floating, >> pull-up on RST so high) >> >> This should work too and does not rely on some side effects/timings and >> should be future-proof. > > Thanks for the explanation. So the reset sequence happens to work with > either GPIO polarity because the pin is set to high impedance before and > afterward. I tested this patch (no driver changes) on a PinePhone, and > indeed Linux's touchscreen driver still loads and works fine. > >> The other option would be to only fix known "broken" boards (e.g. >> PRT8MM, maybe others) and specify in the DT binding documentation that >> the reset-gpios polarity is "inverted" (that is, the reset is asserted >> when the reset-gpios as specified in the DT is deasserted). This makes >> the DT binding documentation **implementation specific** which is >> everything the DT binding is trying to avoid. > > Not really, the binding just encodes existing practice. New boards must > invert the polarity relative to the datasheet because existing boards > did the same thing previously. The board devicetrees drive the binding; > Linux is only a consumer of it. So the binding is still not Linux-specific. No, the whole point of a binding is to define a contract between producers and consumers. It is a specification, not a consensus. (I see up-thread there was some use of "binding" to refer to DTS producers, so maybe there's a bit of confusion in play here) The goodix.yaml binding does not state that any polarity flag in the "reset-gpios" specifier should be ignored, therefore consumers are objectively wrong to ignore it, and producers are objectively wrong to specify a polarity that does not represent the underlying hardware. > In fact, here you rely on the "implementation specific" behavior of the > Linux driver to claim that this a non-breaking change. If some other DT > consumer has a driver which leaves the reset line as an output, this > patch would be a breaking change for them. And it turns out that such a > driver exists: As discussed previously, there are already established DTBs in use that *correctly* specify both active-low and active-high (hardware-inverted) polarities here, so that would mean Zephyr is already broken in general. However, since it looks like they've chosen to maintain their own project-specific bindings and DTS files, if they do also have the equivalent bug then it would seem to be entirely in their own hands. Thanks, Robin. > https://github.com/zephyrproject-rtos/zephyr/commit/17089a2e14acb0428502 > https://github.com/zephyrproject-rtos/zephyr/pull/48927 > >> Something needs to be done, and no solution will make everyone happy. > > I am happy as long as the change does not create any DT compatibility > issues, either between OSes or between OS versions. You demonstrated > that Linux was fine, and the BSDs don't have appear to have a driver for > this hardware. So from an Allwinner platform perspective, I am fine with > this patch. > > But you should ensure the Zephyr folks are okay with making the same > change to their driver and devicetrees, since it is a breaking change > for them. > > Regards, > Samuel > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A910C4332F for ; Mon, 12 Dec 2022 13:22:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mhX8BHzKl84zHdjna3QSpkaw+u4zeJeny7X7mkMjUvU=; b=RuIL/ITof0e/AI sSpjDnRULoEfN+cFdwuQOkxV3acdHMqowUj9sce76m3/flt39LOeO80UEjnMFI6DdJ1Iuqq3dmQ8O uP7PvX22OogUI9l+BkZH4r5Xtv9sEvtbRnLuayLnKSzQBpBM48tZg+Ze9o2EeOjrcAJyTEdxccsi+ XskULVrNvMo3bMVDiHgKyLmAYc9ZSHgP4QiFA5lw0ktxItq4NszXHmqYPPdOQPZaE+SJpk4o/eg2b zRcM4ttyEGnLQ1td/6jYnmAC2dPzusRCNuHQMs5zeGZ6CzPu0lZ7yxiwpQtDtHIxwZVX1kU8i75YX aTAqi4+jK/HDJM6Wlzfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4il7-00GK3D-PT; Mon, 12 Dec 2022 13:22:18 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4iko-00GJti-En; Mon, 12 Dec 2022 13:22:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 35A961FB; Mon, 12 Dec 2022 05:22:29 -0800 (PST) Received: from [10.57.88.235] (unknown [10.57.88.235]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C6EA3F71E; Mon, 12 Dec 2022 05:21:43 -0800 (PST) Message-ID: Date: Mon, 12 Dec 2022 13:21:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 6/9] arm64: dts: allwinner: fix touchscreen reset GPIO polarity To: Samuel Holland , Quentin Schulz , Quentin Schulz Cc: linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Bastien Nocera , =?UTF-8?Q?Guido_G=c3=bcnther?= , Sascha Hauer , Pengutronix Kernel Team , Angus Ainslie , Ondrej Jirman , Icenowy Zheng , Andy Gross , Aleksei Mamlin , Fabio Estevam , David Jander , Frieder Schrempf , Bjorn Andersson , Konrad Dybcio , Peter Geis , Heiko Stuebner , Shawn Guo , Jernej Skrabec , Lukasz Majewski , AngeloGioacchino Del Regno , Chen-Yu Tsai , Michael Riesch , Rob Herring , NXP Linux Team , Dmitry Torokhov , Hans de Goede , Jagan Teki , Krzysztof Kozlowski References: <20221103-upstream-goodix-reset-v3-0-0975809eb183@theobroma-systems.com> <20221103-upstream-goodix-reset-v3-6-0975809eb183@theobroma-systems.com> <48329048-880d-02d6-0384-abdfa4c61c46@sholland.org> Content-Language: en-GB From: Robin Murphy In-Reply-To: <48329048-880d-02d6-0384-abdfa4c61c46@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_052159_744967_FB17EC2B X-CRM114-Status: GOOD ( 43.89 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjAyMi0xMi0xMiAwNjozMiwgU2FtdWVsIEhvbGxhbmQgd3JvdGU6Cj4gSGkgUXVlbnRpbiwK PiAKPiBPbiAxMi82LzIyIDA1OjExLCBRdWVudGluIFNjaHVseiB3cm90ZToKPj4gT24gMTIvNi8y MiAwMToyNiwgU2FtdWVsIEhvbGxhbmQgd3JvdGU6Cj4+PiBPbiAxMi81LzIyIDA3OjQwLCBRdWVu dGluIFNjaHVseiB3cm90ZToKPj4+PiBGcm9tOiBRdWVudGluIFNjaHVseiA8cXVlbnRpbi5zY2h1 bHpAdGhlb2Jyb21hLXN5c3RlbXMuY29tPgo+Pj4+Cj4+Pj4gVGhlIHJlc2V0IGxpbmUgaXMgYWN0 aXZlIGxvdyBmb3IgdGhlIEdvb2RpeCB0b3VjaHNjcmVlbiBjb250cm9sbGVyIHNvCj4+Pj4gbGV0 J3MgZml4IHRoZSBwb2xhcml0eSBpbiB0aGUgRGV2aWNlIFRyZWUgbm9kZS4KPj4+Pgo+Pj4+IFNp Z25lZC1vZmYtYnk6IFF1ZW50aW4gU2NodWx6IDxxdWVudGluLnNjaHVsekB0aGVvYnJvbWEtc3lz dGVtcy5jb20+Cj4+Pj4gLS0tCj4+Pj4gIMKgIGFyY2gvYXJtNjQvYm9vdC9kdHMvYWxsd2lubmVy L3N1bjUwaS1hNjQtYW1hcnVsYS1yZWxpYy5kdHPCoMKgwqDCoMKgwqAgfAo+Pj4+IDIgKy0KPj4+ PiAgwqAgYXJjaC9hcm02NC9ib290L2R0cy9hbGx3aW5uZXIvc3VuNTBpLWE2NC1vY2VhbmljLTUy MDUtNWlubWZkLmR0cyB8Cj4+Pj4gMiArLQo+Pj4+ICDCoCBhcmNoL2FybTY0L2Jvb3QvZHRzL2Fs bHdpbm5lci9zdW41MGktYTY0LXBpbmVwaG9uZS5kdHNpwqDCoMKgwqDCoMKgwqDCoMKgIHwKPj4+ PiAyICstCj4+Pj4gIMKgIGFyY2gvYXJtNjQvYm9vdC9kdHMvYWxsd2lubmVyL3N1bjUwaS1hNjQt cGluZXRhYi5kdHPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfAo+Pj4+IDIgKy0KPj4+PiAgwqAg NCBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4+Pj4KPj4+ PiBkaWZmIC0tZ2l0Cj4+Pj4gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2FsbHdpbm5lci9zdW41MGkt YTY0LWFtYXJ1bGEtcmVsaWMuZHRzCj4+Pj4gYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2FsbHdpbm5l ci9zdW41MGktYTY0LWFtYXJ1bGEtcmVsaWMuZHRzCj4+Pj4gaW5kZXggODIzMzU4MmY2Mjg4MS4u NWZkNTgxMDM3ZDk4NyAxMDA2NDQKPj4+PiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2FsbHdp bm5lci9zdW41MGktYTY0LWFtYXJ1bGEtcmVsaWMuZHRzCj4+Pj4gKysrIGIvYXJjaC9hcm02NC9i b290L2R0cy9hbGx3aW5uZXIvc3VuNTBpLWE2NC1hbWFydWxhLXJlbGljLmR0cwo+Pj4+IEBAIC0x MjIsNyArMTIyLDcgQEAgdG91Y2hzY3JlZW5ANWQgewo+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAg aW50ZXJydXB0LXBhcmVudCA9IDwmcGlvPjsKPj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgIGludGVy cnVwdHMgPSA8NyA0IElSUV9UWVBFX0VER0VfRkFMTElORz47Cj4+Pj4gIMKgwqDCoMKgwqDCoMKg wqDCoCBpcnEtZ3Bpb3MgPSA8JnBpbyA3IDQgR1BJT19BQ1RJVkVfSElHSD47wqDCoMKgIC8qIENU UC1JTlQ6IFBINCAqLwo+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXNldC1ncGlvcyA9IDwmcGlvIDcg OCBHUElPX0FDVElWRV9ISUdIPjvCoMKgwqAgLyogQ1RQLVJTVDoKPj4+PiBQSDggKi8KPj4+PiAr wqDCoMKgwqDCoMKgwqAgcmVzZXQtZ3Bpb3MgPSA8JnBpbyA3IDggR1BJT19BQ1RJVkVfTE9XPjvC oMKgwqAgLyogQ1RQLVJTVDogUEg4ICovCj4+Pgo+Pj4gWW91IGFyZSBjaGFuZ2luZyB0aGUgRFQg YmluZGluZyBoZXJlLCBpbiBhIHdheSB0aGF0IGJyZWFrcyBiYWNrd2FyZAo+Pj4gY29tcGF0aWJp bGl0eSB3aXRoIGV4aXN0aW5nIGRldmljZXRyZWVzLiBOQUNLLgo+Pj4KPj4KPj4gWWVzLgo+Pgo+ PiBTb21lIGJvYXJkcyB3aWxsIGdldCB0aGVpciBEVCBiaW5kaW5nIGJyb2tlbiwgdGhlcmUncyBu byB3YXkgYXJvdW5kIGl0Cj4+IHNhZGx5Lgo+Pgo+PiBXZSBrbm93IGFscmVhZHkgdGhhdCB0aGUg UFJUOE1NIERUIGJpbmRpbmcgd2FzIHdyaXR0ZW4gd2l0aCBhIGRpZmZlcmVudAo+PiB1bmRlcnN0 YW5kaW5nIHRoYW4gZm9yIG90aGVyIGJvYXJkcy4gVGhlcmUgYXJlIHNvbWUgYm9hcmQgc2NoZW1h dGljcyBJCj4+IGRvbid0IGhhdmUgYWNjZXNzIHRvIHNvIG1heWJlIHRoZSBzYW1lIGFwcGxpZXMg dG8gdGhvc2UuCj4+Cj4+IEEgcmVtaW5kZXIgdGhhdCBldmVuIGlmIHlvdSBnb3QgeW91ciBwb2xh cml0eSB3cm9uZywgaXQgY291bGQgc3RpbGwgd29yawo+PiBpbiBzb21lIGNhc2VzICh0aW1pbmdz IHJpZ2h0IHRvZGF5IGJ1dCBub3RoaW5nIGd1YXJhbnRlZWQgaXQnbGwgc3RheQo+PiB0aGlzIHdh eSBmb3JldmVyKS4KPj4KPj4gd2l0aCB0aGUgY3VycmVudCBkcml2ZXIsIHdoYXQgSSBhc3N1bWUg d2Ugc2hvdWxkIGdldCBmb3IgYW4gImluY29ycmVjdCIKPj4gcG9sYXJpdHkgKHdpdGggR1BJT19B Q1RJVkVfTE9XKSBpczoKPj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgX19fX19fX19fX19fX19f X19fXwo+PiBJTlQgX19fX19fX3zCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg fF9fX19fX19fX19fCj4+Cj4+ICDCoMKgwqAgX19fX19fX19fX19fwqDCoMKgwqDCoMKgwqDCoMKg wqAgX19fX19fX19fX19fX19fX19fCj4+IFJTVMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8X19f X19fX19ffAo+Pgo+PiAgwqDCoCBeCj4+ICDCoMKgIExfXyBwdWxsLXVwIG9uIFJTVCBzbyBoaWdo IGJ5IGRlZmF1bHQKPj4gIMKgwqDCoMKgwqDCoMKgIF4KPj4gIMKgwqDCoMKgwqDCoMKgIExfX18g Z3Bpb2RfZGlyZWN0aW9uX291dHB1dCgwKSAoZGVhc3NlcnQgR1BJTyBhY3RpdmUtbG93LCBzbyBo aWdoKQo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXgo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqAg TF9fX18gZ29vZGl4X2lycV9kaXJlY3Rpb25fb3V0cHV0Cj4+ICDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgXgo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIExfX18gZ3Bp b2RfZGlyZWN0aW9uX291dHB1dCgxKSAoYXNzZXJ0IEdQSU8gYWN0aXZlLWxvdywKPj4gc28gbG93 KQo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg Xgo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg TF9fX18gZ3Bpb2RfZGlyZWN0aW9uX2lucHV0KCkgKGZsb2F0aW5nLAo+PiBwdWxsLXVwIG9uIFJT VCBzbyBoaWdoKQo+Pgo+PiBUaGlzIHdvcmtzIGJlY2F1c2Ugb2YgdGhlIHB1bGwtdXAgb24gUlNU IGFuZCB0aGF0IHdoYXQgbWF0dGVycyBpcyB0aGF0Cj4+IHRoZSBJTlQgbGFuZSBpcyBjb25maWd1 cmVkIDEwMMK1cyBiZWZvcmUgYSByaXNpbmcgZWRnZSBvbiBSU1QgbGluZSAoZm9yCj4+IGF0IGxl YXN0IDVtcykuIEhvd2V2ZXIsIHRoZSBpbml0IHNlcXVlbmNlIGlzIG5vdCBwcm9wZXJseSBmb2xs b3dlZCBhbmQKPj4gbWlnaHQgZ2V0IGJyb2tlbiBpbiB0aGUgZnV0dXJlIHNpbmNlIGl0IGlzIG5v dCBzb21ldGhpbmcgdGhhdCB3ZQo+PiBleHBsaWNpdGx5IHN1cHBvcnQuCj4gCj4gV2UgYXMgcGxh dGZvcm0gRFQvYmluZGluZyBtYWludGFpbmVycyBleHBsaWNpdGx5IHN1cHBvcnQgY29tcGF0aWJp bGl0eQo+IHdpdGggZXhpc3RpbmcgZGV2aWNldHJlZXMsIHdoZXRoZXIgdGhvc2UgZGV2aWNldHJl ZXMgYXJlICJjb3JyZWN0IiBvcgo+IG5vdC4gSWYgYSBuZXcgdmVyc2lvbiBvZiBMaW51eCBkb2Vz IG5vdCB3b3JrIHdpdGggYW4gb2xkIERULCB0aGF0IGlzIGEKPiByZWdyZXNzaW9uIGluIExpbnV4 Lgo+IAo+PiBXaXRoIHRoZSBwcm9wb3NlZCBwYXRjaDoKPj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgX19fX19fX19fX19fX19fX19fXwo+PiBJTlQgX19fX19fX3zCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgfF9fX19fX19fX19fCj4+Cj4+ICDCoMKgwqAgX19fX8KgwqDCoMKg wqDCoMKgwqAgX19fX19fX19fX19fX19fX19fCj4+IFJTVMKgwqDCoMKgIHxfX19fX19ffAo+Pgo+ PiAgwqDCoCBeCj4+ICDCoMKgIExfXyBwdWxsLXVwIG9uIFJTVCBzbyBoaWdoIGJ5IGRlZmF1bHQK Pj4gIMKgwqDCoMKgwqDCoMKgIF4KPj4gIMKgwqDCoMKgwqDCoMKgIExfX18gZ3Bpb2RfZGlyZWN0 aW9uX291dHB1dCgxKSAoYXNzZXJ0IEdQSU8gYWN0aXZlLWxvdywgc28gbG93KQo+PiAgwqDCoMKg wqDCoMKgwqDCoMKgwqAgXgo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqAgTF9fX18gZ29vZGl4X2ly cV9kaXJlY3Rpb25fb3V0cHV0Cj4+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXgo+ PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIExfX18gZ3Bpb2RfZGlyZWN0aW9uX291 dHB1dCgxKSAoZGVhc3NlcnQgR1BJTwo+PiBhY3RpdmUtbG93LCBzbyBoaWdoKQo+PiAgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXgo+PiAgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgTF9fX18gZ3Bpb2Rf ZGlyZWN0aW9uX2lucHV0KCkgKGZsb2F0aW5nLAo+PiBwdWxsLXVwIG9uIFJTVCBzbyBoaWdoKQo+ Pgo+PiBUaGlzIHNob3VsZCB3b3JrIHRvbyBhbmQgZG9lcyBub3QgcmVseSBvbiBzb21lIHNpZGUg ZWZmZWN0cy90aW1pbmdzIGFuZAo+PiBzaG91bGQgYmUgZnV0dXJlLXByb29mLgo+IAo+IFRoYW5r cyBmb3IgdGhlIGV4cGxhbmF0aW9uLiBTbyB0aGUgcmVzZXQgc2VxdWVuY2UgaGFwcGVucyB0byB3 b3JrIHdpdGgKPiBlaXRoZXIgR1BJTyBwb2xhcml0eSBiZWNhdXNlIHRoZSBwaW4gaXMgc2V0IHRv IGhpZ2ggaW1wZWRhbmNlIGJlZm9yZSBhbmQKPiBhZnRlcndhcmQuIEkgdGVzdGVkIHRoaXMgcGF0 Y2ggKG5vIGRyaXZlciBjaGFuZ2VzKSBvbiBhIFBpbmVQaG9uZSwgYW5kCj4gaW5kZWVkIExpbnV4 J3MgdG91Y2hzY3JlZW4gZHJpdmVyIHN0aWxsIGxvYWRzIGFuZCB3b3JrcyBmaW5lLgo+IAo+PiBU aGUgb3RoZXIgb3B0aW9uIHdvdWxkIGJlIHRvIG9ubHkgZml4IGtub3duICJicm9rZW4iIGJvYXJk cyAoZS5nLgo+PiBQUlQ4TU0sIG1heWJlIG90aGVycykgYW5kIHNwZWNpZnkgaW4gdGhlIERUIGJp bmRpbmcgZG9jdW1lbnRhdGlvbiB0aGF0Cj4+IHRoZSByZXNldC1ncGlvcyBwb2xhcml0eSBpcyAi aW52ZXJ0ZWQiICh0aGF0IGlzLCB0aGUgcmVzZXQgaXMgYXNzZXJ0ZWQKPj4gd2hlbiB0aGUgcmVz ZXQtZ3Bpb3MgYXMgc3BlY2lmaWVkIGluIHRoZSBEVCBpcyBkZWFzc2VydGVkKS4gVGhpcyBtYWtl cwo+PiB0aGUgRFQgYmluZGluZyBkb2N1bWVudGF0aW9uICoqaW1wbGVtZW50YXRpb24gc3BlY2lm aWMqKiB3aGljaCBpcwo+PiBldmVyeXRoaW5nIHRoZSBEVCBiaW5kaW5nIGlzIHRyeWluZyB0byBh dm9pZC4KPiAKPiBOb3QgcmVhbGx5LCB0aGUgYmluZGluZyBqdXN0IGVuY29kZXMgZXhpc3Rpbmcg cHJhY3RpY2UuIE5ldyBib2FyZHMgbXVzdAo+IGludmVydCB0aGUgcG9sYXJpdHkgcmVsYXRpdmUg dG8gdGhlIGRhdGFzaGVldCBiZWNhdXNlIGV4aXN0aW5nIGJvYXJkcwo+IGRpZCB0aGUgc2FtZSB0 aGluZyBwcmV2aW91c2x5LiBUaGUgYm9hcmQgZGV2aWNldHJlZXMgZHJpdmUgdGhlIGJpbmRpbmc7 Cj4gTGludXggaXMgb25seSBhIGNvbnN1bWVyIG9mIGl0LiBTbyB0aGUgYmluZGluZyBpcyBzdGls bCBub3QgTGludXgtc3BlY2lmaWMuCgpObywgdGhlIHdob2xlIHBvaW50IG9mIGEgYmluZGluZyBp cyB0byBkZWZpbmUgYSBjb250cmFjdCBiZXR3ZWVuIApwcm9kdWNlcnMgYW5kIGNvbnN1bWVycy4g SXQgaXMgYSBzcGVjaWZpY2F0aW9uLCBub3QgYSBjb25zZW5zdXMuCgooSSBzZWUgdXAtdGhyZWFk IHRoZXJlIHdhcyBzb21lIHVzZSBvZiAiYmluZGluZyIgdG8gcmVmZXIgdG8gRFRTIApwcm9kdWNl cnMsIHNvIG1heWJlIHRoZXJlJ3MgYSBiaXQgb2YgY29uZnVzaW9uIGluIHBsYXkgaGVyZSkKClRo ZSBnb29kaXgueWFtbCBiaW5kaW5nIGRvZXMgbm90IHN0YXRlIHRoYXQgYW55IHBvbGFyaXR5IGZs YWcgaW4gdGhlIAoicmVzZXQtZ3Bpb3MiIHNwZWNpZmllciBzaG91bGQgYmUgaWdub3JlZCwgdGhl cmVmb3JlIGNvbnN1bWVycyBhcmUgCm9iamVjdGl2ZWx5IHdyb25nIHRvIGlnbm9yZSBpdCwgYW5k IHByb2R1Y2VycyBhcmUgb2JqZWN0aXZlbHkgd3JvbmcgdG8gCnNwZWNpZnkgYSBwb2xhcml0eSB0 aGF0IGRvZXMgbm90IHJlcHJlc2VudCB0aGUgdW5kZXJseWluZyBoYXJkd2FyZS4KCj4gSW4gZmFj dCwgaGVyZSB5b3UgcmVseSBvbiB0aGUgImltcGxlbWVudGF0aW9uIHNwZWNpZmljIiBiZWhhdmlv ciBvZiB0aGUKPiBMaW51eCBkcml2ZXIgdG8gY2xhaW0gdGhhdCB0aGlzIGEgbm9uLWJyZWFraW5n IGNoYW5nZS4gSWYgc29tZSBvdGhlciBEVAo+IGNvbnN1bWVyIGhhcyBhIGRyaXZlciB3aGljaCBs ZWF2ZXMgdGhlIHJlc2V0IGxpbmUgYXMgYW4gb3V0cHV0LCB0aGlzCj4gcGF0Y2ggd291bGQgYmUg YSBicmVha2luZyBjaGFuZ2UgZm9yIHRoZW0uIEFuZCBpdCB0dXJucyBvdXQgdGhhdCBzdWNoIGEK PiBkcml2ZXIgZXhpc3RzOgoKQXMgZGlzY3Vzc2VkIHByZXZpb3VzbHksIHRoZXJlIGFyZSBhbHJl YWR5IGVzdGFibGlzaGVkIERUQnMgaW4gdXNlIHRoYXQgCipjb3JyZWN0bHkqIHNwZWNpZnkgYm90 aCBhY3RpdmUtbG93IGFuZCBhY3RpdmUtaGlnaCAoaGFyZHdhcmUtaW52ZXJ0ZWQpIApwb2xhcml0 aWVzIGhlcmUsIHNvIHRoYXQgd291bGQgbWVhbiBaZXBoeXIgaXMgYWxyZWFkeSBicm9rZW4gaW4g Z2VuZXJhbC4gCkhvd2V2ZXIsIHNpbmNlIGl0IGxvb2tzIGxpa2UgdGhleSd2ZSBjaG9zZW4gdG8g bWFpbnRhaW4gdGhlaXIgb3duIApwcm9qZWN0LXNwZWNpZmljIGJpbmRpbmdzIGFuZCBEVFMgZmls ZXMsIGlmIHRoZXkgZG8gYWxzbyBoYXZlIHRoZSAKZXF1aXZhbGVudCBidWcgdGhlbiBpdCB3b3Vs ZCBzZWVtIHRvIGJlIGVudGlyZWx5IGluIHRoZWlyIG93biBoYW5kcy4KClRoYW5rcywKUm9iaW4u Cgo+IGh0dHBzOi8vZ2l0aHViLmNvbS96ZXBoeXJwcm9qZWN0LXJ0b3MvemVwaHlyL2NvbW1pdC8x NzA4OWEyZTE0YWNiMDQyODUwMgo+IGh0dHBzOi8vZ2l0aHViLmNvbS96ZXBoeXJwcm9qZWN0LXJ0 b3MvemVwaHlyL3B1bGwvNDg5MjcKPiAKPj4gU29tZXRoaW5nIG5lZWRzIHRvIGJlIGRvbmUsIGFu ZCBubyBzb2x1dGlvbiB3aWxsIG1ha2UgZXZlcnlvbmUgaGFwcHkuCj4gCj4gSSBhbSBoYXBweSBh cyBsb25nIGFzIHRoZSBjaGFuZ2UgZG9lcyBub3QgY3JlYXRlIGFueSBEVCBjb21wYXRpYmlsaXR5 Cj4gaXNzdWVzLCBlaXRoZXIgYmV0d2VlbiBPU2VzIG9yIGJldHdlZW4gT1MgdmVyc2lvbnMuIFlv dSBkZW1vbnN0cmF0ZWQKPiB0aGF0IExpbnV4IHdhcyBmaW5lLCBhbmQgdGhlIEJTRHMgZG9uJ3Qg aGF2ZSBhcHBlYXIgdG8gaGF2ZSBhIGRyaXZlciBmb3IKPiB0aGlzIGhhcmR3YXJlLiBTbyBmcm9t IGFuIEFsbHdpbm5lciBwbGF0Zm9ybSBwZXJzcGVjdGl2ZSwgSSBhbSBmaW5lIHdpdGgKPiB0aGlz IHBhdGNoLgo+IAo+IEJ1dCB5b3Ugc2hvdWxkIGVuc3VyZSB0aGUgWmVwaHlyIGZvbGtzIGFyZSBv a2F5IHdpdGggbWFraW5nIHRoZSBzYW1lCj4gY2hhbmdlIHRvIHRoZWlyIGRyaXZlciBhbmQgZGV2 aWNldHJlZXMsIHNpbmNlIGl0IGlzIGEgYnJlYWtpbmcgY2hhbmdlCj4gZm9yIHRoZW0uCj4gCj4g UmVnYXJkcywKPiBTYW11ZWwKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IExpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdAo+IExpbnV4LXJv Y2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgt cm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA3ECC4708D for ; Mon, 12 Dec 2022 13:23:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mh6SZ53KkRyGZB4qG4NtVEPVTZn27uI5XN7TbH9w3aE=; b=f5EuN41MJpxrq1 xKu6iKjbVIFKg5w29dITHIWBSyueCOEcDdCOsMKLLxlaslIhSWIJ1g+Wbu2KSNDKn1ouGwWCMEBbd u300o/+YTmbutjqYY6irwRlIuiSit6czAEQwzretX9hwA4Fkt9LcTFJY1CgaNgQEA321fumcnX861 pS1iyYqRha6mLY/Tg1fsYKKAlIaSWn+YTH9yaXMKlKUbOa3d3UL89X5P58pLAUCh5Th3Q4I6IdBSS Uw/mYaxS5bxdTUAvKDXwa1KRjL++MS3NO0dBXPVj9RU3pQN/ZoxbRVMXhUbacjmQLoCh2yPFBoBvR JbmnP4YIyFn1UgZYHWrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4ikz-00GJyQ-0j; Mon, 12 Dec 2022 13:22:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4iko-00GJti-En; Mon, 12 Dec 2022 13:22:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 35A961FB; Mon, 12 Dec 2022 05:22:29 -0800 (PST) Received: from [10.57.88.235] (unknown [10.57.88.235]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C6EA3F71E; Mon, 12 Dec 2022 05:21:43 -0800 (PST) Message-ID: Date: Mon, 12 Dec 2022 13:21:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 6/9] arm64: dts: allwinner: fix touchscreen reset GPIO polarity To: Samuel Holland , Quentin Schulz , Quentin Schulz Cc: linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Bastien Nocera , =?UTF-8?Q?Guido_G=c3=bcnther?= , Sascha Hauer , Pengutronix Kernel Team , Angus Ainslie , Ondrej Jirman , Icenowy Zheng , Andy Gross , Aleksei Mamlin , Fabio Estevam , David Jander , Frieder Schrempf , Bjorn Andersson , Konrad Dybcio , Peter Geis , Heiko Stuebner , Shawn Guo , Jernej Skrabec , Lukasz Majewski , AngeloGioacchino Del Regno , Chen-Yu Tsai , Michael Riesch , Rob Herring , NXP Linux Team , Dmitry Torokhov , Hans de Goede , Jagan Teki , Krzysztof Kozlowski References: <20221103-upstream-goodix-reset-v3-0-0975809eb183@theobroma-systems.com> <20221103-upstream-goodix-reset-v3-6-0975809eb183@theobroma-systems.com> <48329048-880d-02d6-0384-abdfa4c61c46@sholland.org> Content-Language: en-GB From: Robin Murphy In-Reply-To: <48329048-880d-02d6-0384-abdfa4c61c46@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_052159_744967_FB17EC2B X-CRM114-Status: GOOD ( 43.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMi0xMi0xMiAwNjozMiwgU2FtdWVsIEhvbGxhbmQgd3JvdGU6Cj4gSGkgUXVlbnRpbiwK PiAKPiBPbiAxMi82LzIyIDA1OjExLCBRdWVudGluIFNjaHVseiB3cm90ZToKPj4gT24gMTIvNi8y MiAwMToyNiwgU2FtdWVsIEhvbGxhbmQgd3JvdGU6Cj4+PiBPbiAxMi81LzIyIDA3OjQwLCBRdWVu dGluIFNjaHVseiB3cm90ZToKPj4+PiBGcm9tOiBRdWVudGluIFNjaHVseiA8cXVlbnRpbi5zY2h1 bHpAdGhlb2Jyb21hLXN5c3RlbXMuY29tPgo+Pj4+Cj4+Pj4gVGhlIHJlc2V0IGxpbmUgaXMgYWN0 aXZlIGxvdyBmb3IgdGhlIEdvb2RpeCB0b3VjaHNjcmVlbiBjb250cm9sbGVyIHNvCj4+Pj4gbGV0 J3MgZml4IHRoZSBwb2xhcml0eSBpbiB0aGUgRGV2aWNlIFRyZWUgbm9kZS4KPj4+Pgo+Pj4+IFNp Z25lZC1vZmYtYnk6IFF1ZW50aW4gU2NodWx6IDxxdWVudGluLnNjaHVsekB0aGVvYnJvbWEtc3lz dGVtcy5jb20+Cj4+Pj4gLS0tCj4+Pj4gIMKgIGFyY2gvYXJtNjQvYm9vdC9kdHMvYWxsd2lubmVy L3N1bjUwaS1hNjQtYW1hcnVsYS1yZWxpYy5kdHPCoMKgwqDCoMKgwqAgfAo+Pj4+IDIgKy0KPj4+ PiAgwqAgYXJjaC9hcm02NC9ib290L2R0cy9hbGx3aW5uZXIvc3VuNTBpLWE2NC1vY2VhbmljLTUy MDUtNWlubWZkLmR0cyB8Cj4+Pj4gMiArLQo+Pj4+ICDCoCBhcmNoL2FybTY0L2Jvb3QvZHRzL2Fs bHdpbm5lci9zdW41MGktYTY0LXBpbmVwaG9uZS5kdHNpwqDCoMKgwqDCoMKgwqDCoMKgIHwKPj4+ PiAyICstCj4+Pj4gIMKgIGFyY2gvYXJtNjQvYm9vdC9kdHMvYWxsd2lubmVyL3N1bjUwaS1hNjQt cGluZXRhYi5kdHPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfAo+Pj4+IDIgKy0KPj4+PiAgwqAg NCBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4+Pj4KPj4+ PiBkaWZmIC0tZ2l0Cj4+Pj4gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2FsbHdpbm5lci9zdW41MGkt YTY0LWFtYXJ1bGEtcmVsaWMuZHRzCj4+Pj4gYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2FsbHdpbm5l ci9zdW41MGktYTY0LWFtYXJ1bGEtcmVsaWMuZHRzCj4+Pj4gaW5kZXggODIzMzU4MmY2Mjg4MS4u NWZkNTgxMDM3ZDk4NyAxMDA2NDQKPj4+PiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2FsbHdp bm5lci9zdW41MGktYTY0LWFtYXJ1bGEtcmVsaWMuZHRzCj4+Pj4gKysrIGIvYXJjaC9hcm02NC9i b290L2R0cy9hbGx3aW5uZXIvc3VuNTBpLWE2NC1hbWFydWxhLXJlbGljLmR0cwo+Pj4+IEBAIC0x MjIsNyArMTIyLDcgQEAgdG91Y2hzY3JlZW5ANWQgewo+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAg aW50ZXJydXB0LXBhcmVudCA9IDwmcGlvPjsKPj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgIGludGVy cnVwdHMgPSA8NyA0IElSUV9UWVBFX0VER0VfRkFMTElORz47Cj4+Pj4gIMKgwqDCoMKgwqDCoMKg wqDCoCBpcnEtZ3Bpb3MgPSA8JnBpbyA3IDQgR1BJT19BQ1RJVkVfSElHSD47wqDCoMKgIC8qIENU UC1JTlQ6IFBINCAqLwo+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXNldC1ncGlvcyA9IDwmcGlvIDcg OCBHUElPX0FDVElWRV9ISUdIPjvCoMKgwqAgLyogQ1RQLVJTVDoKPj4+PiBQSDggKi8KPj4+PiAr wqDCoMKgwqDCoMKgwqAgcmVzZXQtZ3Bpb3MgPSA8JnBpbyA3IDggR1BJT19BQ1RJVkVfTE9XPjvC oMKgwqAgLyogQ1RQLVJTVDogUEg4ICovCj4+Pgo+Pj4gWW91IGFyZSBjaGFuZ2luZyB0aGUgRFQg YmluZGluZyBoZXJlLCBpbiBhIHdheSB0aGF0IGJyZWFrcyBiYWNrd2FyZAo+Pj4gY29tcGF0aWJp bGl0eSB3aXRoIGV4aXN0aW5nIGRldmljZXRyZWVzLiBOQUNLLgo+Pj4KPj4KPj4gWWVzLgo+Pgo+ PiBTb21lIGJvYXJkcyB3aWxsIGdldCB0aGVpciBEVCBiaW5kaW5nIGJyb2tlbiwgdGhlcmUncyBu byB3YXkgYXJvdW5kIGl0Cj4+IHNhZGx5Lgo+Pgo+PiBXZSBrbm93IGFscmVhZHkgdGhhdCB0aGUg UFJUOE1NIERUIGJpbmRpbmcgd2FzIHdyaXR0ZW4gd2l0aCBhIGRpZmZlcmVudAo+PiB1bmRlcnN0 YW5kaW5nIHRoYW4gZm9yIG90aGVyIGJvYXJkcy4gVGhlcmUgYXJlIHNvbWUgYm9hcmQgc2NoZW1h dGljcyBJCj4+IGRvbid0IGhhdmUgYWNjZXNzIHRvIHNvIG1heWJlIHRoZSBzYW1lIGFwcGxpZXMg dG8gdGhvc2UuCj4+Cj4+IEEgcmVtaW5kZXIgdGhhdCBldmVuIGlmIHlvdSBnb3QgeW91ciBwb2xh cml0eSB3cm9uZywgaXQgY291bGQgc3RpbGwgd29yawo+PiBpbiBzb21lIGNhc2VzICh0aW1pbmdz IHJpZ2h0IHRvZGF5IGJ1dCBub3RoaW5nIGd1YXJhbnRlZWQgaXQnbGwgc3RheQo+PiB0aGlzIHdh eSBmb3JldmVyKS4KPj4KPj4gd2l0aCB0aGUgY3VycmVudCBkcml2ZXIsIHdoYXQgSSBhc3N1bWUg d2Ugc2hvdWxkIGdldCBmb3IgYW4gImluY29ycmVjdCIKPj4gcG9sYXJpdHkgKHdpdGggR1BJT19B Q1RJVkVfTE9XKSBpczoKPj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgX19fX19fX19fX19fX19f X19fXwo+PiBJTlQgX19fX19fX3zCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg fF9fX19fX19fX19fCj4+Cj4+ICDCoMKgwqAgX19fX19fX19fX19fwqDCoMKgwqDCoMKgwqDCoMKg wqAgX19fX19fX19fX19fX19fX19fCj4+IFJTVMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8X19f X19fX19ffAo+Pgo+PiAgwqDCoCBeCj4+ICDCoMKgIExfXyBwdWxsLXVwIG9uIFJTVCBzbyBoaWdo IGJ5IGRlZmF1bHQKPj4gIMKgwqDCoMKgwqDCoMKgIF4KPj4gIMKgwqDCoMKgwqDCoMKgIExfX18g Z3Bpb2RfZGlyZWN0aW9uX291dHB1dCgwKSAoZGVhc3NlcnQgR1BJTyBhY3RpdmUtbG93LCBzbyBo aWdoKQo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXgo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqAg TF9fX18gZ29vZGl4X2lycV9kaXJlY3Rpb25fb3V0cHV0Cj4+ICDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgXgo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIExfX18gZ3Bp b2RfZGlyZWN0aW9uX291dHB1dCgxKSAoYXNzZXJ0IEdQSU8gYWN0aXZlLWxvdywKPj4gc28gbG93 KQo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg Xgo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg TF9fX18gZ3Bpb2RfZGlyZWN0aW9uX2lucHV0KCkgKGZsb2F0aW5nLAo+PiBwdWxsLXVwIG9uIFJT VCBzbyBoaWdoKQo+Pgo+PiBUaGlzIHdvcmtzIGJlY2F1c2Ugb2YgdGhlIHB1bGwtdXAgb24gUlNU IGFuZCB0aGF0IHdoYXQgbWF0dGVycyBpcyB0aGF0Cj4+IHRoZSBJTlQgbGFuZSBpcyBjb25maWd1 cmVkIDEwMMK1cyBiZWZvcmUgYSByaXNpbmcgZWRnZSBvbiBSU1QgbGluZSAoZm9yCj4+IGF0IGxl YXN0IDVtcykuIEhvd2V2ZXIsIHRoZSBpbml0IHNlcXVlbmNlIGlzIG5vdCBwcm9wZXJseSBmb2xs b3dlZCBhbmQKPj4gbWlnaHQgZ2V0IGJyb2tlbiBpbiB0aGUgZnV0dXJlIHNpbmNlIGl0IGlzIG5v dCBzb21ldGhpbmcgdGhhdCB3ZQo+PiBleHBsaWNpdGx5IHN1cHBvcnQuCj4gCj4gV2UgYXMgcGxh dGZvcm0gRFQvYmluZGluZyBtYWludGFpbmVycyBleHBsaWNpdGx5IHN1cHBvcnQgY29tcGF0aWJp bGl0eQo+IHdpdGggZXhpc3RpbmcgZGV2aWNldHJlZXMsIHdoZXRoZXIgdGhvc2UgZGV2aWNldHJl ZXMgYXJlICJjb3JyZWN0IiBvcgo+IG5vdC4gSWYgYSBuZXcgdmVyc2lvbiBvZiBMaW51eCBkb2Vz IG5vdCB3b3JrIHdpdGggYW4gb2xkIERULCB0aGF0IGlzIGEKPiByZWdyZXNzaW9uIGluIExpbnV4 Lgo+IAo+PiBXaXRoIHRoZSBwcm9wb3NlZCBwYXRjaDoKPj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgX19fX19fX19fX19fX19fX19fXwo+PiBJTlQgX19fX19fX3zCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgfF9fX19fX19fX19fCj4+Cj4+ICDCoMKgwqAgX19fX8KgwqDCoMKg wqDCoMKgwqAgX19fX19fX19fX19fX19fX19fCj4+IFJTVMKgwqDCoMKgIHxfX19fX19ffAo+Pgo+ PiAgwqDCoCBeCj4+ICDCoMKgIExfXyBwdWxsLXVwIG9uIFJTVCBzbyBoaWdoIGJ5IGRlZmF1bHQK Pj4gIMKgwqDCoMKgwqDCoMKgIF4KPj4gIMKgwqDCoMKgwqDCoMKgIExfX18gZ3Bpb2RfZGlyZWN0 aW9uX291dHB1dCgxKSAoYXNzZXJ0IEdQSU8gYWN0aXZlLWxvdywgc28gbG93KQo+PiAgwqDCoMKg wqDCoMKgwqDCoMKgwqAgXgo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqAgTF9fX18gZ29vZGl4X2ly cV9kaXJlY3Rpb25fb3V0cHV0Cj4+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXgo+ PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIExfX18gZ3Bpb2RfZGlyZWN0aW9uX291 dHB1dCgxKSAoZGVhc3NlcnQgR1BJTwo+PiBhY3RpdmUtbG93LCBzbyBoaWdoKQo+PiAgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXgo+PiAgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgTF9fX18gZ3Bpb2Rf ZGlyZWN0aW9uX2lucHV0KCkgKGZsb2F0aW5nLAo+PiBwdWxsLXVwIG9uIFJTVCBzbyBoaWdoKQo+ Pgo+PiBUaGlzIHNob3VsZCB3b3JrIHRvbyBhbmQgZG9lcyBub3QgcmVseSBvbiBzb21lIHNpZGUg ZWZmZWN0cy90aW1pbmdzIGFuZAo+PiBzaG91bGQgYmUgZnV0dXJlLXByb29mLgo+IAo+IFRoYW5r cyBmb3IgdGhlIGV4cGxhbmF0aW9uLiBTbyB0aGUgcmVzZXQgc2VxdWVuY2UgaGFwcGVucyB0byB3 b3JrIHdpdGgKPiBlaXRoZXIgR1BJTyBwb2xhcml0eSBiZWNhdXNlIHRoZSBwaW4gaXMgc2V0IHRv IGhpZ2ggaW1wZWRhbmNlIGJlZm9yZSBhbmQKPiBhZnRlcndhcmQuIEkgdGVzdGVkIHRoaXMgcGF0 Y2ggKG5vIGRyaXZlciBjaGFuZ2VzKSBvbiBhIFBpbmVQaG9uZSwgYW5kCj4gaW5kZWVkIExpbnV4 J3MgdG91Y2hzY3JlZW4gZHJpdmVyIHN0aWxsIGxvYWRzIGFuZCB3b3JrcyBmaW5lLgo+IAo+PiBU aGUgb3RoZXIgb3B0aW9uIHdvdWxkIGJlIHRvIG9ubHkgZml4IGtub3duICJicm9rZW4iIGJvYXJk cyAoZS5nLgo+PiBQUlQ4TU0sIG1heWJlIG90aGVycykgYW5kIHNwZWNpZnkgaW4gdGhlIERUIGJp bmRpbmcgZG9jdW1lbnRhdGlvbiB0aGF0Cj4+IHRoZSByZXNldC1ncGlvcyBwb2xhcml0eSBpcyAi aW52ZXJ0ZWQiICh0aGF0IGlzLCB0aGUgcmVzZXQgaXMgYXNzZXJ0ZWQKPj4gd2hlbiB0aGUgcmVz ZXQtZ3Bpb3MgYXMgc3BlY2lmaWVkIGluIHRoZSBEVCBpcyBkZWFzc2VydGVkKS4gVGhpcyBtYWtl cwo+PiB0aGUgRFQgYmluZGluZyBkb2N1bWVudGF0aW9uICoqaW1wbGVtZW50YXRpb24gc3BlY2lm aWMqKiB3aGljaCBpcwo+PiBldmVyeXRoaW5nIHRoZSBEVCBiaW5kaW5nIGlzIHRyeWluZyB0byBh dm9pZC4KPiAKPiBOb3QgcmVhbGx5LCB0aGUgYmluZGluZyBqdXN0IGVuY29kZXMgZXhpc3Rpbmcg cHJhY3RpY2UuIE5ldyBib2FyZHMgbXVzdAo+IGludmVydCB0aGUgcG9sYXJpdHkgcmVsYXRpdmUg dG8gdGhlIGRhdGFzaGVldCBiZWNhdXNlIGV4aXN0aW5nIGJvYXJkcwo+IGRpZCB0aGUgc2FtZSB0 aGluZyBwcmV2aW91c2x5LiBUaGUgYm9hcmQgZGV2aWNldHJlZXMgZHJpdmUgdGhlIGJpbmRpbmc7 Cj4gTGludXggaXMgb25seSBhIGNvbnN1bWVyIG9mIGl0LiBTbyB0aGUgYmluZGluZyBpcyBzdGls bCBub3QgTGludXgtc3BlY2lmaWMuCgpObywgdGhlIHdob2xlIHBvaW50IG9mIGEgYmluZGluZyBp cyB0byBkZWZpbmUgYSBjb250cmFjdCBiZXR3ZWVuIApwcm9kdWNlcnMgYW5kIGNvbnN1bWVycy4g SXQgaXMgYSBzcGVjaWZpY2F0aW9uLCBub3QgYSBjb25zZW5zdXMuCgooSSBzZWUgdXAtdGhyZWFk IHRoZXJlIHdhcyBzb21lIHVzZSBvZiAiYmluZGluZyIgdG8gcmVmZXIgdG8gRFRTIApwcm9kdWNl cnMsIHNvIG1heWJlIHRoZXJlJ3MgYSBiaXQgb2YgY29uZnVzaW9uIGluIHBsYXkgaGVyZSkKClRo ZSBnb29kaXgueWFtbCBiaW5kaW5nIGRvZXMgbm90IHN0YXRlIHRoYXQgYW55IHBvbGFyaXR5IGZs YWcgaW4gdGhlIAoicmVzZXQtZ3Bpb3MiIHNwZWNpZmllciBzaG91bGQgYmUgaWdub3JlZCwgdGhl cmVmb3JlIGNvbnN1bWVycyBhcmUgCm9iamVjdGl2ZWx5IHdyb25nIHRvIGlnbm9yZSBpdCwgYW5k IHByb2R1Y2VycyBhcmUgb2JqZWN0aXZlbHkgd3JvbmcgdG8gCnNwZWNpZnkgYSBwb2xhcml0eSB0 aGF0IGRvZXMgbm90IHJlcHJlc2VudCB0aGUgdW5kZXJseWluZyBoYXJkd2FyZS4KCj4gSW4gZmFj dCwgaGVyZSB5b3UgcmVseSBvbiB0aGUgImltcGxlbWVudGF0aW9uIHNwZWNpZmljIiBiZWhhdmlv ciBvZiB0aGUKPiBMaW51eCBkcml2ZXIgdG8gY2xhaW0gdGhhdCB0aGlzIGEgbm9uLWJyZWFraW5n IGNoYW5nZS4gSWYgc29tZSBvdGhlciBEVAo+IGNvbnN1bWVyIGhhcyBhIGRyaXZlciB3aGljaCBs ZWF2ZXMgdGhlIHJlc2V0IGxpbmUgYXMgYW4gb3V0cHV0LCB0aGlzCj4gcGF0Y2ggd291bGQgYmUg YSBicmVha2luZyBjaGFuZ2UgZm9yIHRoZW0uIEFuZCBpdCB0dXJucyBvdXQgdGhhdCBzdWNoIGEK PiBkcml2ZXIgZXhpc3RzOgoKQXMgZGlzY3Vzc2VkIHByZXZpb3VzbHksIHRoZXJlIGFyZSBhbHJl YWR5IGVzdGFibGlzaGVkIERUQnMgaW4gdXNlIHRoYXQgCipjb3JyZWN0bHkqIHNwZWNpZnkgYm90 aCBhY3RpdmUtbG93IGFuZCBhY3RpdmUtaGlnaCAoaGFyZHdhcmUtaW52ZXJ0ZWQpIApwb2xhcml0 aWVzIGhlcmUsIHNvIHRoYXQgd291bGQgbWVhbiBaZXBoeXIgaXMgYWxyZWFkeSBicm9rZW4gaW4g Z2VuZXJhbC4gCkhvd2V2ZXIsIHNpbmNlIGl0IGxvb2tzIGxpa2UgdGhleSd2ZSBjaG9zZW4gdG8g bWFpbnRhaW4gdGhlaXIgb3duIApwcm9qZWN0LXNwZWNpZmljIGJpbmRpbmdzIGFuZCBEVFMgZmls ZXMsIGlmIHRoZXkgZG8gYWxzbyBoYXZlIHRoZSAKZXF1aXZhbGVudCBidWcgdGhlbiBpdCB3b3Vs ZCBzZWVtIHRvIGJlIGVudGlyZWx5IGluIHRoZWlyIG93biBoYW5kcy4KClRoYW5rcywKUm9iaW4u Cgo+IGh0dHBzOi8vZ2l0aHViLmNvbS96ZXBoeXJwcm9qZWN0LXJ0b3MvemVwaHlyL2NvbW1pdC8x NzA4OWEyZTE0YWNiMDQyODUwMgo+IGh0dHBzOi8vZ2l0aHViLmNvbS96ZXBoeXJwcm9qZWN0LXJ0 b3MvemVwaHlyL3B1bGwvNDg5MjcKPiAKPj4gU29tZXRoaW5nIG5lZWRzIHRvIGJlIGRvbmUsIGFu ZCBubyBzb2x1dGlvbiB3aWxsIG1ha2UgZXZlcnlvbmUgaGFwcHkuCj4gCj4gSSBhbSBoYXBweSBh cyBsb25nIGFzIHRoZSBjaGFuZ2UgZG9lcyBub3QgY3JlYXRlIGFueSBEVCBjb21wYXRpYmlsaXR5 Cj4gaXNzdWVzLCBlaXRoZXIgYmV0d2VlbiBPU2VzIG9yIGJldHdlZW4gT1MgdmVyc2lvbnMuIFlv dSBkZW1vbnN0cmF0ZWQKPiB0aGF0IExpbnV4IHdhcyBmaW5lLCBhbmQgdGhlIEJTRHMgZG9uJ3Qg aGF2ZSBhcHBlYXIgdG8gaGF2ZSBhIGRyaXZlciBmb3IKPiB0aGlzIGhhcmR3YXJlLiBTbyBmcm9t IGFuIEFsbHdpbm5lciBwbGF0Zm9ybSBwZXJzcGVjdGl2ZSwgSSBhbSBmaW5lIHdpdGgKPiB0aGlz IHBhdGNoLgo+IAo+IEJ1dCB5b3Ugc2hvdWxkIGVuc3VyZSB0aGUgWmVwaHlyIGZvbGtzIGFyZSBv a2F5IHdpdGggbWFraW5nIHRoZSBzYW1lCj4gY2hhbmdlIHRvIHRoZWlyIGRyaXZlciBhbmQgZGV2 aWNldHJlZXMsIHNpbmNlIGl0IGlzIGEgYnJlYWtpbmcgY2hhbmdlCj4gZm9yIHRoZW0uCj4gCj4g UmVnYXJkcywKPiBTYW11ZWwKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IExpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdAo+IExpbnV4LXJv Y2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==