All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Josh Soref via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Elijah Newren" <newren@gmail.com>, "René Scharfe" <l.s.r@web.de>,
	"Phillip Wood" <phillip.wood123@gmail.com>,
	"Josh Soref" <jsoref@gmail.com>, "Josh Soref" <jsoref@gmail.com>,
	"Josh Soref" <jsoref@gmail.com>
Subject: [PATCH v2 7/9] SubmittingPatches: clarify GitHub visual
Date: Thu, 21 Dec 2023 16:41:03 +0000	[thread overview]
Message-ID: <cdb5fd0957fee7ce8c19720f588da96898cd3dc9.1703176866.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1623.v2.git.1703176865.gitgitgadget@gmail.com>

From: Josh Soref <jsoref@gmail.com>

GitHub has two general forms for its states, sometimes they're a simple
colored object (e.g. green check or red x), and sometimes there's also a
colored container (e.g. green box or red circle) with containing that
object (e.g. check or x).

That's a lot of words to try to describe things, but in general, the key
for a failure is that it's recognized as an `x` and that it's associated
with the color red -- the color of course is problematic for people who
are red-green color-blind, but that's why they are paired with distinct
shapes.

Using the term `cross` doesn't really help.

Signed-off-by: Josh Soref <jsoref@gmail.com>
---
 Documentation/SubmittingPatches | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 4476b52a50f..8f79253c5cb 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -603,7 +603,7 @@ to your fork of Git on GitHub.  You can monitor the test state of all your
 branches here: `https://github.com/<Your GitHub handle>/git/actions/workflows/main.yml`
 
 If a branch did not pass all test cases then it is marked with a red
-cross. In that case you can click on the failing job and navigate to
++x+. In that case you can click on the failing job and navigate to
 "ci/run-build-and-tests.sh" and/or "ci/print-test-failures.sh". You
 can also download "Artifacts" which are tarred (or zipped) archives
 with test data relevant for debugging.
-- 
gitgitgadget


  parent reply	other threads:[~2023-12-21 16:41 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19  8:41 [PATCH 0/8] Minor improvements to CodingGuidelines and SubmittingPatches Josh Soref via GitGitGadget
2023-12-19  8:41 ` [PATCH 1/8] CodingGuidelines: move period inside parentheses Josh Soref via GitGitGadget
2023-12-19  8:41 ` [PATCH 2/8] CodingGuidelines: write punctuation marks Josh Soref via GitGitGadget
2023-12-19  8:41 ` [PATCH 3/8] SubmittingPatches: drop ref to "What's in git.git" Josh Soref via GitGitGadget
2023-12-19  8:41 ` [PATCH 4/8] SubmittingPatches: update extra tags list Josh Soref via GitGitGadget
2023-12-20 15:18   ` Phillip Wood
2023-12-20 15:30     ` Elijah Newren
2023-12-20 16:09       ` Josh Soref
2023-12-20 16:49         ` Elijah Newren
2023-12-20 17:42           ` Josh Soref
2023-12-21 15:09             ` phillip.wood123
2023-12-20 16:31     ` Junio C Hamano
2023-12-19  8:41 ` [PATCH 5/8] SubmittingPatches: improve extra tags advice Josh Soref via GitGitGadget
2023-12-19  8:41 ` [PATCH 6/8] SubmittingPatches: clarify GitHub visual Josh Soref via GitGitGadget
2023-12-19 14:44   ` René Scharfe
2023-12-20 15:40     ` Elijah Newren
2023-12-20 16:25       ` Josh Soref
2023-12-20 16:39       ` Junio C Hamano
2023-12-19  8:41 ` [PATCH 7/8] SubmittingPatches: clarify GitHub artifact format Josh Soref via GitGitGadget
2023-12-20 15:21   ` Elijah Newren
2023-12-20 16:16     ` Josh Soref
2023-12-20 17:00       ` Elijah Newren
2023-12-19  8:41 ` [PATCH 8/8] SubmittingPatches: hyphenate non-ASCII Josh Soref via GitGitGadget
2023-12-20 15:43 ` [PATCH 0/8] Minor improvements to CodingGuidelines and SubmittingPatches Elijah Newren
2023-12-21 16:40 ` [PATCH v2 0/9] " Josh Soref via GitGitGadget
2023-12-21 16:40   ` [PATCH v2 1/9] CodingGuidelines: move period inside parentheses Josh Soref via GitGitGadget
2023-12-21 21:03     ` Junio C Hamano
2023-12-21 21:52       ` Josh Soref
2023-12-22  1:30       ` Dragan Simic
2023-12-21 16:40   ` [PATCH v2 2/9] CodingGuidelines: write punctuation marks Josh Soref via GitGitGadget
2023-12-21 20:57     ` Junio C Hamano
2023-12-21 21:46       ` Josh Soref
2023-12-21 21:57         ` Junio C Hamano
2023-12-21 16:40   ` [PATCH v2 3/9] SubmittingPatches: drop ref to "What's in git.git" Josh Soref via GitGitGadget
2023-12-21 21:09     ` Junio C Hamano
2023-12-21 16:41   ` [PATCH v2 4/9] SubmittingPatches: discourage new trailers Josh Soref via GitGitGadget
2023-12-21 16:41   ` [PATCH v2 5/9] SubmittingPatches: update extra tags list Josh Soref via GitGitGadget
2023-12-21 21:16     ` Junio C Hamano
2023-12-21 21:55       ` Josh Soref
2023-12-21 16:41   ` [PATCH v2 6/9] SubmittingPatches: improve extra tags advice Josh Soref via GitGitGadget
2023-12-21 21:18     ` Junio C Hamano
2023-12-21 16:41   ` Josh Soref via GitGitGadget [this message]
2023-12-21 21:27     ` [PATCH v2 7/9] SubmittingPatches: clarify GitHub visual Junio C Hamano
2023-12-21 16:41   ` [PATCH v2 8/9] SubmittingPatches: clarify GitHub artifact format Josh Soref via GitGitGadget
2023-12-21 16:41   ` [PATCH v2 9/9] SubmittingPatches: hyphenate non-ASCII Josh Soref via GitGitGadget
2023-12-28  4:55   ` [PATCH v3 0/9] Minor improvements to CodingGuidelines and SubmittingPatches Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 1/9] CodingGuidelines: move period inside parentheses Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 2/9] CodingGuidelines: write punctuation marks Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 3/9] SubmittingPatches: drop ref to "What's in git.git" Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 4/9] SubmittingPatches: discourage new trailers Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 5/9] SubmittingPatches: update extra tags list Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 6/9] SubmittingPatches: provide tag naming advice Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 7/9] SubmittingPatches: clarify GitHub visual Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 8/9] SubmittingPatches: clarify GitHub artifact format Josh Soref via GitGitGadget
2023-12-28  4:55     ` [PATCH v3 9/9] SubmittingPatches: hyphenate non-ASCII Josh Soref via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdb5fd0957fee7ce8c19720f588da96898cd3dc9.1703176866.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jsoref@gmail.com \
    --cc=l.s.r@web.de \
    --cc=newren@gmail.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.