From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEE0E306774 for ; Thu, 2 Jul 2026 09:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782986169; cv=none; b=EqZeIed8uLzqCcvHkaQy1b8V8mXSymdW4LDZ71FH8Oc8K8+Y6lmabdPasmEVizbs+Rea6bQkITlRS1VDKkH+7Wh1igtLr8j/Qd0r4FyFIlePdBmf7wdlO2Km95vUtFMJil7SUIr/gZQg1voCSnD/qfOzyVaejliNyVcK9TLpWg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782986169; c=relaxed/simple; bh=oa39J5Vbq61tCuJw7ABqSD6dMS2Vr07cKB1Fdz0+aIw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b/c0K9sHRamzy0ztDftCl7gO6VvmD3WdLXzTmNUZAw6n2x4LfECcr6WUL3z4PKT3nU5nGOkFa8d6b+r9tpHibVVfGkkyjm2c/f2/n9GRaJdBFuBL96PJ4kpexKeBho7n2ukKY3CQGt0oHkg5obDgU3eNm6/XEbTKM0JND9xFKsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o0fW9Z8D; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WzH6LMnX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o0fW9Z8D"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WzH6LMnX" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6628ZaRn3046363 for ; Thu, 2 Jul 2026 09:56:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UnUR1LOesZgE+LhExMMNkZRlI6t8z7VRKCRBzJBUFR4=; b=o0fW9Z8DPpV5Nebk 0wNp1ydqmGqi0YInPLG9F9eTTDAe+pgIjnjWvkoKKMJcdK4nbW+c0IB0nCSsczxx M5mZ/UX9WWJreEDTB744zcZOSsBJ9Xht9BuO1PImt3tOnhemyVdkBWIlh6FNHHAC andSu9HU9egIPz1OwdAl6vMYv9PBZflabA6vDAIBEyrC8xrAw3jaCqzTyMQxFZzT HqB6YwHgrNTE+OpmQigzfRKkaDi3UdZaIEZM2OtE5eFuvozSa1KglngoN7XM1iTe TnodHd3VKG+IJhhOm6Qie185Wc0pOeQSj6ZthO3+tgXOOpZ5fR2hiwj40sG3LfuD 45zVtQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f58k3awuk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 09:56:06 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-37fe90ee192so2364995a91.3 for ; Thu, 02 Jul 2026 02:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782986166; x=1783590966; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UnUR1LOesZgE+LhExMMNkZRlI6t8z7VRKCRBzJBUFR4=; b=WzH6LMnXK/r6PmBJkfNNGPZLJk4ou9Np/0365ksUfC9Kxy6OEW2jzMtCTwkopMvU02 rR+pPczhTTCc4jF5gSA4t80hbNt8jozmrohAkVTl0LThjIjG1GMaxxz6a2jjFNpEAf3m 9qE9jB+78idTEvjrJolAEER9ztaNy6IlyqIMS0mVhc8u6gF0BbRvgtsD1FySDu5lYEAX X49NF+n16PR8CZ8TpyUV/7kieVtmR7oLt9vH2oTggJHNrh4FJFaomEDBMem8RHPd7lev o+zyFcIO2pT8pWjCs+dj+wNjDCO1+svQHTcR3qsIOslNiknhmMvh0LngJBvihIasZKZt Gnow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782986166; x=1783590966; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UnUR1LOesZgE+LhExMMNkZRlI6t8z7VRKCRBzJBUFR4=; b=dK6ALRT7Zb1zH+q21hv5IPP84TXsd+YyP6h465EtE3H4VvzNwKTRIsEu/fNCs3tmCU QS2/9ewNJY1j0qRgVwNJMDpYjL/nIxAgkujWfGY20SMM0v6/9DJjYjquudtB6Et9fJy4 08VtZUBYqcrDj/+E85rp3GQQV8y2FpKuNOuHuSSK1u1AINLkXBP2ArxPX0zQ+Eputo9z lZxyGQkKjSe6nTcxtkWPYDpxdEyqtJw+pf6UF6zQxtfVPedNlCa92PWIozDh2Aqo09B7 pr/IKKjZeomJQGUwYyMEOLkiX1ACMV2PMa46NmqiNVGoY9SKr0fvL8gIs0y7Z/ffzezG 20LA== X-Forwarded-Encrypted: i=1; AHgh+Rp82/Xkry4wqzNCkaioqzehtJXizN32tCQY9ToCEpyvqqCx40zEY4kYwTPjStLHZOMz1Bxhdi6zg6l5GtU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9G37/I8C56d9CXK8gMKSDxBYvgNCtsQ2y/+clWD2eSwcbQOx+ ipk2n4MmIROcnuqBiClJiCj81sqjpZPm07nVy4HSLwKMox0+1+d2+DjEKuFYPBeRc74ZUPI89ap b8TOfPyW/KtPI44uYGd4i7Gx/qoZsZIIctHifugieJs71A4ncyQnN9Wctz1isy0vwbW/AHvHrh0 1D8Q== X-Gm-Gg: AfdE7cnY6jeVpCV7NY9+8us9TRbfG6063gXCVV4KMaTWduoRzc9DDI86Ui2xU5XREwt NVmyZRFx4A7SELEuIZDGJmdhPn1RW7oSN8Xty3b7bTjwJNtMo6TgtSM1WdYDLnRvXfT3ckClH7M 71P64Kjy8ed3O29PoGb8WkMMG6d0nO3YQdQGtrBDSWXnvDqR31M+Oh8M67FMX81wSbfTM9B0y8L smqOJVIaz51bF7eWqYOKrpR77/+UVf5EJR4MAjSy4/CQ0Kh8GvLO9OiDHYH0fG+zYl+yiMxdwtw WKBfI7DhCkpFnbMdNpgHr3t2BIa8oRJusZnrD6gF2bmc4xWk1+ThvcxIzwszMiCaAeZC7Neewx1 jvgAPjdXBICS4mEm9+ANJTGMHeKM0p6B4Bm94/q7dxEZI1BVJ5rwBVwqpSOR3Pk1iUdt2G64pHN by+hZChdfq X-Received: by 2002:a17:90b:1806:b0:37f:db06:229c with SMTP id 98e67ed59e1d1-380aa1cad60mr5597218a91.22.1782986165859; Thu, 02 Jul 2026 02:56:05 -0700 (PDT) X-Received: by 2002:a17:90b:1806:b0:37f:db06:229c with SMTP id 98e67ed59e1d1-380aa1cad60mr5597187a91.22.1782986165247; Thu, 02 Jul 2026 02:56:05 -0700 (PDT) Received: from [10.133.33.211] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3810200f089sm138115a91.7.2026.07.02.02.56.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:56:04 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 17:56:01 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] wifi: ath12k: fix MAC address copy on big endian To: Alexander Wilhelm Cc: Jeff Johnson , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260629-fix-mac-addr-copy-on-big-endian-v1-1-3de40f74c13e@westermo.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDEwMiBTYWx0ZWRfXw0xglxTWNPcI 3mDNQFkv7Z55XsPQ/FcVKYa4hYPCfBXOefmRnsEyzgUf+8Ao3HKzQbXrKuNCORclEZnHgRmtPd2 HzuXaVDibGGvjko60ututSywjCXhzTs2YqVX4/4bIySUKe9Xd3kB4LgX832oItxKTaJSkgcynXq 7F+QmuwmxAOW+NzyxoQmDjwYYtQRd+dBOp7BTgQBrCG6hKZ0QAc7XP+e7PZdqUq4gLq2qGjjV9Z lCfDKzzynAQWd8Gqdep68dHF6wTnAURURFdfrkt+nSm3cS7UGKtcrLNW6AjdCtzQtu8rvrqEVVq 29YXtcsQhcit4Gy2/Yr0fHW1tRTuUnoi2dKt/vTA5Fi6f80d4OPEJebLstZQl6qX0qtaIoODcVL AnqZgqiJ2n29cWjCQhpfp2P2x1vkyd/49ltoSQ0mqZpb0Pwu7j1FJkRvD8G/ltftYUZ9B3YmnQm F4Q6Gchc8EO5c17OXzg== X-Authority-Analysis: v=2.4 cv=SuGgLvO0 c=1 sm=1 tr=0 ts=6a4635b6 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=uj8kP0hEhypoEna20nYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDEwMiBTYWx0ZWRfX5UKEZZ3lIEen yvDdVe+5lCTPBsO4vrbQ+jW73O1z0jMMjTn/1CB6jCBIh/9p75Au98MBxMDhyMAk41wkOHsrR8Z EvYOY3F1RTBpA9NvHy3nnBcZXGSiTZ8= X-Proofpoint-ORIG-GUID: SoHHObECFTAldelgIyYVtGSC4WUmIlGj X-Proofpoint-GUID: SoHHObECFTAldelgIyYVtGSC4WUmIlGj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 adultscore=0 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020102 On 7/2/2026 5:17 PM, Alexander Wilhelm wrote: > On Thu, Jul 02, 2026 at 10:41:25AM +0200, Alexander Wilhelm wrote: >> On Thu, Jul 02, 2026 at 04:12:00PM +0800, Baochen Qiang wrote: >>> >>> >>> On 6/29/2026 3:55 PM, Alexander Wilhelm wrote: >>>> The ath12k_dp_get_mac_addr function performs a simple memcpy from a >>>> CPU-native data types into an u8 array. On a big-endian architecture, this >>>> later results in a null‑pointer dereference. Convert the data to >>> >>> Alex, did you find a time to investigate the root cause of the null pointer? > > Hi Baochen, > > I am now running kernel v6.18.26, and it looks like the null-pointer issue is > gone. I only see the following log messages: > > ath12k_pci 0001:01:00.0: failed to vdev 0 create peer for AP: -110 what is the actual mac addr reported from firmware in the PEER MAP event? My understanding is that, without this patch (if we really need it) we get a wrong mac addr, then in ath12k_dp_link_peer_map_event() we are more likely to fail the peer look up hence would create a new peer and wakeup the waiting thread. But the log here clearly indicates that the wait timeout, which does not make sense to me. > ath12k_pci 0001:01:00.0: failed to create vdev 04:f0:21:c9:e0:0e ret -110 > ath12k_pci 0001:01:00.0: failed to assign chanctx for vif 04:f0:21:c9:e0:0e link id 0 link vif is already started > ath12k_pci 0001:01:00.0: invalid vdev id in vdev delete resp ev 0 > > Should I rebase the patch onto the latest `ath/master` branch and update the > commit description accordingly? > > > Best regards > Alexander Wilhelm