From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH net-next] net: socket: Fix missing break in switch statement
Date: Wed, 24 Apr 2019 14:47:46 -0500 [thread overview]
Message-ID: <cde163bd-0104-9502-38df-29b504ebfbca@embeddedor.com> (raw)
In-Reply-To: <CAK8P3a0Ak95EUq6-6ASHKEKw=x+9_+MO5ZaFcctaS4esz__J3A@mail.gmail.com>
Arnd,
On 4/24/19 1:45 PM, Arnd Bergmann wrote:
> On Wed, Apr 24, 2019 at 5:33 PM Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>>
>> Add missing break statement in order to prevent the code from falling
>> through to cases SIOCGSTAMP_NEW and SIOCGSTAMPNS_NEW.
>>
>> This bug was found thanks to the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Fixes: 0768e17073dc ("net: socket: implement 64-bit timestamps")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Just for clarification: Dan didn't report this to me. I found this
bug while working on the last fall-through warnings in net.
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> I had just prepared the same patch after Dan told me about the issue today,
> but you managed to submit it first.
>
> Thanks for the fix!
>
Glad to help. :)
Thanks
--
Gustavo
next prev parent reply other threads:[~2019-04-24 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 15:31 [PATCH net-next] net: socket: Fix missing break in switch statement Gustavo A. R. Silva
2019-04-24 18:45 ` Arnd Bergmann
2019-04-24 19:47 ` Gustavo A. R. Silva [this message]
2019-04-26 15:29 ` David Miller
2019-04-26 15:45 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cde163bd-0104-9502-38df-29b504ebfbca@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.