All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Romain Caritey" <Romain.Caritey@microchip.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Connor Davis" <connojdavis@gmail.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Anthony PERARD" <anthony.perard@vates.tech>,
	"Michal Orzel" <michal.orzel@amd.com>,
	"Julien Grall" <julien@xen.org>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 10/12] xen/riscv: introduce p2m_gpa_bits
Date: Thu, 23 Apr 2026 15:47:20 +0200	[thread overview]
Message-ID: <cde7a080-4501-4641-8848-2035e2370ab3@gmail.com> (raw)
In-Reply-To: <14ae97df-cb9b-4b43-bb39-6b9395ad918b@suse.com>



On 4/21/26 11:46 AM, Jan Beulich wrote:
> On 10.04.2026 17:54, Oleksii Kurochko wrote:
>> common/device-tree/domain-build.c uses p2m_gpa_bits to determine the
>> upper bound of the GPA space when searching for unused regions, so it
>> must be defined when CONFIG_DOMAIN_BUILD_HELPERS=y.
>>
>> The variable is initialised to PADDR_BITS and narrowed in p2m_init() to
>> the GPA width of the selected G-stage mode, allowing an external entity
>> (e.g. an IOMMU) to restrict it further if needed.
>>
>> p2m_gpa_bits is a global rather than a per-domain value, which is
>> acceptable for now because all domains are required to use the same
>> G-stage MMU mode, as dom0less common code allocates it per all
>> domains.
>>
>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> 
> Pretty hesitantly:

Could you please clarify what specifically you don't like here?

> Acked-by: Jan Beulich <jbeulich@suse.com>

Thanks.

~ Oleksii


  reply	other threads:[~2026-04-23 13:47 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 15:54 [PATCH v3 00/12] RISCV: enable DOMAIN_BUILD_HELPERS Oleksii Kurochko
2026-04-10 15:54 ` [PATCH v3 01/12] xen/riscv: implement get_page_from_gfn() Oleksii Kurochko
2026-04-20 14:17   ` Jan Beulich
2026-04-10 15:54 ` [PATCH v3 02/12] xen: fix len type for guest copy functions Oleksii Kurochko
2026-04-20 15:43   ` Jan Beulich
2026-04-20 15:44   ` Jan Beulich
2026-04-22 10:02     ` Oleksii Kurochko
2026-04-10 15:54 ` [PATCH v3 03/12] xen/riscv: implement copy_to_guest_phys() Oleksii Kurochko
2026-04-20 15:46   ` Jan Beulich
2026-04-10 15:54 ` [PATCH v3 04/12] xen/dom0less: rename kernel_zimage_probe() to kernel_image_probe() Oleksii Kurochko
2026-04-10 15:54 ` [PATCH v3 05/12] xen/riscv: add kernel loading support Oleksii Kurochko
2026-04-21  8:57   ` Jan Beulich
2026-04-22 11:45     ` Oleksii Kurochko
2026-04-22 11:57       ` Jan Beulich
2026-04-22 13:47         ` Oleksii Kurochko
2026-04-22 13:54           ` Jan Beulich
2026-04-22 14:32             ` Oleksii Kurochko
2026-04-21  9:01   ` Jan Beulich
2026-04-10 15:54 ` [PATCH v3 06/12] xen: move declaration of fw_unreserved_regions() to common header Oleksii Kurochko
2026-04-10 15:54 ` [PATCH v3 07/12] xen: introduce domain-layout.h with common domain_use_host_layout() Oleksii Kurochko
2026-04-21  9:20   ` Jan Beulich
2026-04-22 14:38     ` Oleksii Kurochko
2026-04-10 15:54 ` [PATCH v3 08/12] xen/riscv: rework G-stage mode handling Oleksii Kurochko
2026-04-21  9:39   ` Jan Beulich
2026-04-22 16:06     ` Oleksii Kurochko
2026-04-10 15:54 ` [PATCH v3 09/12] xen: rename p2m_ipa_bits to p2m_gpa_bits Oleksii Kurochko
2026-04-10 15:54 ` [PATCH v3 10/12] xen/riscv: introduce p2m_gpa_bits Oleksii Kurochko
2026-04-21  9:46   ` Jan Beulich
2026-04-23 13:47     ` Oleksii Kurochko [this message]
2026-05-04  5:39       ` Jan Beulich
2026-04-10 15:54 ` [PATCH v3 11/12] xen/riscv: add definition of guest RAM banks Oleksii Kurochko
2026-04-21 10:24   ` Jan Beulich
2026-04-23 13:50     ` Oleksii Kurochko
2026-04-10 15:54 ` [PATCH v3 12/12] xen/riscv: enable DOMAIN_BUILD_HELPERS Oleksii Kurochko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cde7a080-4501-4641-8848-2035e2370ab3@gmail.com \
    --to=oleksii.kurochko@gmail.com \
    --cc=Romain.Caritey@microchip.com \
    --cc=alistair.francis@wdc.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=connojdavis@gmail.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.