From: "Purkait, Soham" <soham.purkait@intel.com>
To: Karthik Poosa <karthik.poosa@intel.com>,
<intel-xe@lists.freedesktop.org>
Cc: <rodrigo.vivi@intel.com>, <anshuman.gupta@intel.com>,
<badal.nilawar@intel.com>, <raag.jadav@intel.com>,
<riana.tauro@intel.com>, <sk.anirban@intel.com>,
<mallesh.koujalagi@intel.com>,
<ravi.kishore.koppuravuri@intel.com>
Subject: Re: [PATCH v3 9/9] drm/xe/hwmon: Update fan info after late binding
Date: Mon, 2 Nov 2026 11:56:42 +0530 [thread overview]
Message-ID: <cdeea51f-79d9-4ce2-bc20-0850e20de940@intel.com> (raw)
In-Reply-To: <20261015190751.1268916-10-karthik.poosa@intel.com>
Hi Karthik,
On 16-10-2026 00:37, Karthik Poosa wrote:
> Add xe_hwmon_fan_update_post_lb() to update fan info after late binding.
> Add param is_init into xe_hwmon_read_fan_control_info() to avoid
> resetting user pwm mode post-LB.
> Call init path with is_init=true from preregistration.
>
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> Assisted-by: LLM
> ---
> drivers/gpu/drm/xe/xe_hwmon.c | 41 +++++++++++++++++++++++++---
> drivers/gpu/drm/xe/xe_hwmon.h | 2 ++
> drivers/gpu/drm/xe/xe_late_bind_fw.c | 3 ++
> 3 files changed, 42 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index d9f6cc9c81f6..e91bcacdfe93 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -2068,7 +2068,7 @@ static const struct attribute_group hwmon_curve_attrgroup = {
> .is_visible = xe_hwmon_curve_attributes_visible,
> };
>
> -static int xe_hwmon_read_fan_control_info(struct xe_hwmon *hwmon)
> +static int xe_hwmon_read_fan_control_info(struct xe_hwmon *hwmon, bool is_init)
> {
> struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
> int point;
> @@ -2129,8 +2129,13 @@ static int xe_hwmon_read_fan_control_info(struct xe_hwmon *hwmon)
> fi->fan_table[STOCK_FAN_TABLE].fcp[point].speed);
> }
>
> - /* Set PWM enable mode to automatic i.e stock table in use. */
> - fi->pwm_enable_mode = XE_FAN_PWM_AUTO_STOCK_TABLE;
> + /*
> + * Set PWM enable mode to automatic i.e stock table in use, only during init.
> + * For late binding, the mode is already set by the user and should not be
> + * overridden.
> + */
> + if (is_init)
> + fi->pwm_enable_mode = XE_FAN_PWM_AUTO_STOCK_TABLE;
>
> /* Read minimum fan PWM */
> ret = xe_hwmon_pcode_read_fan_control(hwmon, FSC_READ_FAN_MIN_PWM, fan,
> @@ -3070,7 +3075,7 @@ xe_hwmon_get_preregistration_info(struct xe_hwmon *hwmon)
> xe_hwmon_fan_input_read(hwmon, channel, &fan_speed);
>
> /* Fan control tables initialization */
> - if (xe_hwmon_read_fan_control_info(hwmon))
> + if (xe_hwmon_read_fan_control_info(hwmon, true))
> xe_warn(hwmon->xe, "Fan control tables are not available\n");
> }
> return xe_hwmon_init_temp_info(hwmon);
> @@ -3258,4 +3263,32 @@ void xe_hwmon_resume(struct xe_device *xe)
> mutex_unlock(&hwmon->hwmon_lock);
> }
>
> +/**
> + * xe_hwmon_fan_update_post_lb - Update fan info after late binding
> + * @xe: xe device instance
> + *
> + * This function reads the number of fans and their stock table after late binding.
> + */
> +void xe_hwmon_fan_update_post_lb(struct xe_device *xe)
> +{
> + struct xe_hwmon *hwmon = xe->hwmon;
> +
> + if (!hwmon || !xe->info.has_fan_control)
> + return;
> +
> + mutex_lock(&hwmon->hwmon_lock);
> +
> + if (xe_hwmon_get_fan_enable_mask(hwmon)) {
> + xe_warn(hwmon->xe, "Failed to read fan enable mask after LB\n");
Could we use "late binding" instead of LB as kernel-doc spells the same ?
> + goto unlock;
> + }
> +
> + /* Read stock tables. */
> + if (xe_hwmon_read_fan_control_info(hwmon, false))
> + xe_warn(hwmon->xe, "Failed to read stock fan tables after LB\n");
Ditto.
> +
> +unlock:
> + mutex_unlock(&hwmon->hwmon_lock);
> +}
> +
> MODULE_IMPORT_NS("INTEL_PMT_TELEMETRY");
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.h b/drivers/gpu/drm/xe/xe_hwmon.h
> index 6c6f30208508..7198d7a4a1be 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.h
> +++ b/drivers/gpu/drm/xe/xe_hwmon.h
> @@ -14,10 +14,12 @@ struct xe_device;
> int xe_hwmon_register(struct xe_device *xe);
> void xe_hwmon_suspend(struct xe_device *xe);
> void xe_hwmon_resume(struct xe_device *xe);
> +void xe_hwmon_fan_update_post_lb(struct xe_device *xe);
> #else
> static inline int xe_hwmon_register(struct xe_device *xe) { return 0; };
> static inline void xe_hwmon_suspend(struct xe_device *xe) {}
> static inline void xe_hwmon_resume(struct xe_device *xe) {}
> +static inline void xe_hwmon_fan_update_post_lb(struct xe_device *xe) {}
> #endif
>
> #endif /* _XE_HWMON_H_ */
> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> index 768442ca7da6..34295418ef50 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> @@ -13,6 +13,7 @@
> #include <drm/drm_print.h>
>
> #include "xe_device.h"
> +#include "xe_hwmon.h"
> #include "xe_late_bind_fw.h"
> #include "xe_pcode.h"
> #include "xe_pcode_api.h"
> @@ -252,6 +253,8 @@ static void xe_late_bind_work(struct work_struct *work)
> if (!ret) {
> drm_dbg(&xe->drm, "Load %s firmware successful\n",
> fw_id_to_name[lbfw->id]);
> + if (fw_id_to_name[lbfw->id] == XE_LB_FW_FAN_CONTROL)
comparison looks incorrect.
> + xe_hwmon_fan_update_post_lb(late_bind_to_xe(late_bind));
xe is already in scope here.
Regards,
Soham
> goto out;
> }
>
next prev parent reply other threads:[~2026-11-02 6:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 19:07 [PATCH v3 0/9] Add fan control support Karthik Poosa
2026-10-15 19:07 ` [PATCH v3 1/9] drm/xe/hwmon: initialize fan-control backend and table cache Karthik Poosa
2026-10-28 18:46 ` Purkait, Soham
2026-10-29 11:34 ` Poosa, Karthik
2026-10-29 12:02 ` Purkait, Soham
2026-10-29 12:04 ` Purkait, Soham
2026-11-05 5:58 ` Purkait, Soham
2026-11-05 16:56 ` Poosa, Karthik
2026-10-15 19:07 ` [PATCH v3 2/9] drm/xe/hwmon: expose fanN_max Karthik Poosa
2026-10-29 4:35 ` Purkait, Soham
2026-10-29 11:39 ` Poosa, Karthik
2026-10-15 19:07 ` [PATCH v3 3/9] drm/xe/pcode: add ordered write batch helper Karthik Poosa
2026-10-29 5:45 ` Purkait, Soham
2026-10-29 11:40 ` Poosa, Karthik
2026-10-15 19:07 ` [PATCH v3 4/9] drm/xe/hwmon: expose pwm[1-3] Karthik Poosa
2026-10-29 11:31 ` Purkait, Soham
2026-11-05 17:09 ` Poosa, Karthik
2026-10-15 19:07 ` [PATCH v3 5/9] drm/xe/hwmon: expose pwm[1-3]_enable Karthik Poosa
2026-10-29 18:33 ` Purkait, Soham
2026-11-05 17:41 ` Poosa, Karthik
2026-10-15 19:07 ` [PATCH v3 6/9] drm/xe/hwmon: Enable fan curve control support Karthik Poosa
2026-10-30 6:33 ` Purkait, Soham
2026-10-15 19:07 ` [PATCH v3 7/9] drm/xe/hwmon: Add kernel-doc for fan control Karthik Poosa
2026-10-30 13:42 ` Purkait, Soham
2026-10-15 19:07 ` [PATCH v3 8/9] drm/xe/hwmon: preserve fan user table across suspend resume Karthik Poosa
2026-11-02 5:58 ` Purkait, Soham
2026-10-15 19:07 ` [PATCH v3 9/9] drm/xe/hwmon: Update fan info after late binding Karthik Poosa
2026-11-02 6:26 ` Purkait, Soham [this message]
2026-10-15 19:46 ` ✗ CI.checkpatch: warning for Add fan control support Patchwork
2026-10-15 19:48 ` ✓ CI.KUnit: success " Patchwork
2026-10-15 21:01 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-10-16 7:56 ` ✗ Xe.CI.FULL: " Patchwork
2026-11-15 17:30 ` [PATCH v3 0/9] " James R Taylor
-- strict thread matches above, loose matches on Subject: below --
2026-10-15 19:01 Karthik Poosa
2026-10-15 19:01 ` [PATCH v3 9/9] drm/xe/hwmon: Update fan info after late binding Karthik Poosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdeea51f-79d9-4ce2-bc20-0850e20de940@intel.com \
--to=soham.purkait@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=mallesh.koujalagi@intel.com \
--cc=raag.jadav@intel.com \
--cc=ravi.kishore.koppuravuri@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=sk.anirban@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.