From mboxrd@z Thu Jan 1 00:00:00 1970 From: shuah at kernel.org (shuah) Date: Tue, 23 Apr 2019 20:46:38 -0600 Subject: [PATCH 1/6] selftests: Extract single-test shell logic from lib.mk In-Reply-To: References: <20190409235556.3967-1-keescook@chromium.org> <20190409235556.3967-2-keescook@chromium.org> <714c1bf0-63a5-9cec-ccd6-7f3abb020574@kernel.org> <6610ef83-b3e0-28b5-b976-5a5f68ca492d@kernel.org> Message-ID: On 4/23/19 8:43 PM, Kees Cook wrote: > On Tue, Apr 23, 2019 at 3:47 PM shuah wrote: >> You can see it by running >> >> make summary=1 TARGETS="breakpoints" kselftest > > Okay, thanks for this! I'll give it a spin. > >> with and without your first patch. Ca you fix the regression and send >> me revised patches. Sorry, I didn't get back to you sooner. A few bugs >> I found kept me busy. >> >> While I was testing your patch series, I found test build failures due >> to circular dependency that needed fixing. In addition, the same >> headers_install dependency, also broke O= and KBUILD_OUTPUT builds >> and fixed those as well. Long story short, these fixes might conflict >> with your work. > > I can rebase the series -- which tree should I look at? (Is it all in > -next already?) > Yes - the two patches are in linux-kselftest next thanks, -- Shuah From mboxrd@z Thu Jan 1 00:00:00 1970 From: shuah@kernel.org (shuah) Date: Tue, 23 Apr 2019 20:46:38 -0600 Subject: [PATCH 1/6] selftests: Extract single-test shell logic from lib.mk In-Reply-To: References: <20190409235556.3967-1-keescook@chromium.org> <20190409235556.3967-2-keescook@chromium.org> <714c1bf0-63a5-9cec-ccd6-7f3abb020574@kernel.org> <6610ef83-b3e0-28b5-b976-5a5f68ca492d@kernel.org> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20190424024638.yByUXrSq7cOVC3om9kFtpjuR3PKCT5irR9G3WbJYTnE@z> On 4/23/19 8:43 PM, Kees Cook wrote: > On Tue, Apr 23, 2019@3:47 PM shuah wrote: >> You can see it by running >> >> make summary=1 TARGETS="breakpoints" kselftest > > Okay, thanks for this! I'll give it a spin. > >> with and without your first patch. Ca you fix the regression and send >> me revised patches. Sorry, I didn't get back to you sooner. A few bugs >> I found kept me busy. >> >> While I was testing your patch series, I found test build failures due >> to circular dependency that needed fixing. In addition, the same >> headers_install dependency, also broke O= and KBUILD_OUTPUT builds >> and fixed those as well. Long story short, these fixes might conflict >> with your work. > > I can rebase the series -- which tree should I look at? (Is it all in > -next already?) > Yes - the two patches are in linux-kselftest next thanks, -- Shuah