From: Jiri Slaby <jirislaby@kernel.org>
To: Nicolas Pitre <nico@fluxnic.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Nicolas Pitre <npitre@baylibre.com>, Dave Mielke <Dave@mielke.cc>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/11] vt: pad double-width code points with a zero-white-space
Date: Mon, 14 Apr 2025 09:18:46 +0200 [thread overview]
Message-ID: <ce04dbc5-e2a7-4574-bc9c-4ecf4b7b0ece@kernel.org> (raw)
In-Reply-To: <20250410011839.64418-12-nico@fluxnic.net>
On 10. 04. 25, 3:14, Nicolas Pitre wrote:
> From: Nicolas Pitre <npitre@baylibre.com>
>
> In the Unicode screen buffer, we follow double-width code points with a
> space to maintain proper column alignment. This, however, creates
> semantic problems when e.g. using cut and paste or selection.
>
> Let's use a better code point for the column padding's purpose i.e. a
> zero-white-space rather than a full space.
>
> Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
> ---
> drivers/tty/vt/vt.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index e3d35c4f92..dc84f9c6b7 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -2937,12 +2937,13 @@ static int vc_con_write_normal(struct vc_data *vc, int tc, int c,
> width = 2;
> } else if (ucs_is_zero_width(c)) {
> prev_c = vc_uniscr_getc(vc, -1);
> - if (prev_c == ' ' &&
> + if (prev_c == 0x200B &&
Then introduce a NAME (macro) for this.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2025-04-14 7:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 1:13 [PATCH 00/11] vt: implement proper Unicode handling Nicolas Pitre
2025-04-10 1:13 ` [PATCH 01/11] vt: minor cleanup to vc_translate_unicode() Nicolas Pitre
2025-04-10 1:13 ` [PATCH 02/11] vt: move unicode processing to a separate file Nicolas Pitre
2025-04-14 6:47 ` Jiri Slaby
2025-04-15 19:03 ` Nicolas Pitre
2025-04-10 1:13 ` [PATCH 03/11] vt: properly support zero-width Unicode code points Nicolas Pitre
2025-04-14 6:51 ` Jiri Slaby
2025-04-15 19:06 ` Nicolas Pitre
2025-04-10 1:13 ` [PATCH 04/11] vt: introduce gen_ucs_width.py to create ucs_width.c Nicolas Pitre
2025-04-14 7:04 ` Jiri Slaby
2025-04-15 19:13 ` Nicolas Pitre
2025-04-10 1:13 ` [PATCH 05/11] vt: update ucs_width.c using gen_ucs_width.py Nicolas Pitre
2025-04-11 3:47 ` kernel test robot
2025-04-10 1:13 ` [PATCH 06/11] vt: introduce gen_ucs_recompose.py to create ucs_recompose.c Nicolas Pitre
2025-04-14 7:08 ` Jiri Slaby
2025-04-10 1:13 ` [PATCH 07/11] vt: create ucs_recompose.c using gen_ucs_recompose.py Nicolas Pitre
2025-04-11 6:00 ` kernel test robot
2025-04-10 1:14 ` [PATCH 08/11] vt: support Unicode recomposition Nicolas Pitre
2025-04-10 1:14 ` [PATCH 09/11] vt: update gen_ucs_width.py to produce more space efficient tables Nicolas Pitre
2025-04-14 7:14 ` Jiri Slaby
2025-04-15 19:16 ` Nicolas Pitre
2025-04-10 1:14 ` [PATCH 10/11] vt: update ucs_width.c following latest gen_ucs_width.py Nicolas Pitre
2025-04-14 7:17 ` Jiri Slaby
2025-04-10 1:14 ` [PATCH 11/11] vt: pad double-width code points with a zero-white-space Nicolas Pitre
2025-04-14 7:18 ` Jiri Slaby [this message]
2025-04-10 19:38 ` [PATCH 12/11] vt: remove zero-white-space handling from conv_uni_to_pc() Nicolas Pitre
2025-04-11 14:49 ` [PATCH 00/11] vt: implement proper Unicode handling Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce04dbc5-e2a7-4574-bc9c-4ecf4b7b0ece@kernel.org \
--to=jirislaby@kernel.org \
--cc=Dave@mielke.cc \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=npitre@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.