Re: [RFC PATCH bpf-next 1/5] bpf: Extend bpf syscall with common attributes support

[Leon Hwang <leon.hwang@linux.dev>]

On 29/7/25 11:43, kernel test robot wrote:
> Hi Leon,
> 
> [This is a private test report for your RFC patch.]
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on bpf-next/master]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Leon-Hwang/bpf-Extend-bpf-syscall-with-common-attributes-support/20250728-222848
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> patch link:    https://lore.kernel.org/r/20250728142346.95681-2-leon.hwang%40linux.dev
> patch subject: [RFC PATCH bpf-next 1/5] bpf: Extend bpf syscall with common attributes support
> config: arm-randconfig-002-20250729 (https://download.01.org/0day-ci/archive/20250729/202507291146.0df0CQq9-lkp@intel.com/config)
> compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250729/202507291146.0df0CQq9-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202507291146.0df0CQq9-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>>> kernel/bpf/syscall.c:6140:1: error: conflicting types for 'sys_bpf'
>     6140 | SYSCALL_DEFINE5(bpf, int, cmd, union bpf_attr __user *, uattr, unsigned int, size,
>          | ^
>    include/linux/syscalls.h:228:36: note: expanded from macro 'SYSCALL_DEFINE5'
>      228 | #define SYSCALL_DEFINE5(name, ...) SYSCALL_DEFINEx(5, _##name, __VA_ARGS__)
>          |                                    ^
>    include/linux/syscalls.h:235:2: note: expanded from macro 'SYSCALL_DEFINEx'
>      235 |         __SYSCALL_DEFINEx(x, sname, __VA_ARGS__)
>          |         ^
>    include/linux/syscalls.h:249:18: note: expanded from macro '__SYSCALL_DEFINEx'
>      249 |         asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__))       \
>          |                         ^
>    <scratch space>:50:1: note: expanded from here
>       50 | sys_bpf
>          | ^
>    include/linux/syscalls.h:929:17: note: previous declaration is here
>      929 | asmlinkage long sys_bpf(int cmd, union bpf_attr __user *attr, unsigned int size);
>          |                 ^
>    1 error generated.
> 

Thanks.

It will be fixed by

diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h


index e5603cc91..3d84faa04 100644


--- a/include/linux/syscalls.h


+++ b/include/linux/syscalls.h


@@ -926,7 +926,8 @@ asmlinkage long sys_seccomp(unsigned int op,
unsigned int flags,

 asmlinkage long sys_getrandom(char __user *buf, size_t count,
                              unsigned int flags);
 asmlinkage long sys_memfd_create(const char __user *uname_ptr, unsigned
int flags);
-asmlinkage long sys_bpf(int cmd, union bpf_attr __user *attr, unsigned
int size);

+asmlinkage long sys_bpf(int cmd, union bpf_attr __user *attr, unsigned
int size,

+                       struct bpf_common_attr __user *attr_common,
unsigned int size_common);

 asmlinkage long sys_execveat(int dfd, const char __user *filename,
                        const char __user *const __user *argv,
                        const char __user *const __user *envp, int flags);

Thanks,
Leon

[...]