From: Jens Axboe <axboe@kernel.dk>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [PATCH v4 0/3] zram: Replace bit spinlocks with a spinlock_t.
Date: Fri, 6 Sep 2024 08:50:57 -0600 [thread overview]
Message-ID: <ce1999f3-4b30-4e12-bbb9-9b0c090a7092@kernel.dk> (raw)
In-Reply-To: <20240906144849.HrQCoqvn@linutronix.de>
On 9/6/24 8:48 AM, Sebastian Andrzej Siewior wrote:
> On 2024-09-06 08:31:23 [-0600], Jens Axboe wrote:
>> On 9/6/24 8:14 AM, Sebastian Andrzej Siewior wrote:
>>> Hi,
>>>
>>> this is follow up to the previous posting, making the lock
>>> unconditionally. The original problem with bit spinlock is that it
>>> disabled preemption and the following operations (within the atomic
>>> section) perform operations that may sleep on PREEMPT_RT. Mike expressed
>>> that he would like to keep using zram on PREEMPT_RT.
>>
>> Looks good to me:
>>
>> Reviewed-by: Jens Axboe <axboe@kernel.dk>
> Thank you.
> This is routed via your tree, right?
I can certainly take it - Minchan let me know if you have concerns.
--
Jens Axboe
next prev parent reply other threads:[~2024-09-06 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 14:14 [PATCH v4 0/3] zram: Replace bit spinlocks with a spinlock_t Sebastian Andrzej Siewior
2024-09-06 14:14 ` [PATCH v4 1/3] " Sebastian Andrzej Siewior
2024-09-06 14:14 ` [PATCH v4 2/3] zram: Remove ZRAM_LOCK Sebastian Andrzej Siewior
2024-09-06 14:14 ` [PATCH v4 3/3] zram: Shrink zram_table_entry::flags Sebastian Andrzej Siewior
2024-09-06 14:31 ` [PATCH v4 0/3] zram: Replace bit spinlocks with a spinlock_t Jens Axboe
2024-09-06 14:48 ` Sebastian Andrzej Siewior
2024-09-06 14:50 ` Jens Axboe [this message]
2024-09-06 14:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1999f3-4b30-4e12-bbb9-9b0c090a7092@kernel.dk \
--to=axboe@kernel.dk \
--cc=aleksander.lobakin@intel.com \
--cc=bigeasy@linutronix.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.