From: Markus Elfring <Markus.Elfring@web.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shichao Lai <shichaorai@gmail.com>,
usb-storage@lists.one-eyed-alien.net, linux-usb@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Oliver Neukum <oneukum@suse.com>,
Xingwei Lee <xrivendell7@gmail.com>,
Yue Sun <samsun1006219@gmail.com>
Subject: Re: [v6] usb-storage: alauda: Check whether the media is initialized
Date: Sun, 26 May 2024 11:20:23 +0200 [thread overview]
Message-ID: <ce266282-029f-4333-9ef8-6ddce64e661f@web.de> (raw)
In-Reply-To: <2024052647-battle-sacred-83b3@gregkh>
>> …
>>> Fixes: e80b0fade09e ("[PATCH] USB Storage: add alauda support")
>>
>> How do you think about to omit the text “[PATCH] ” from the tag summary?
>
> Then it would be incorrect.
I find this view interesting.
> Again, Markus, please STOP sending review comments that are obviously wrong.
The mentioned tag needs an “one line summary”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n145
Do you find it required to repeat a questionable commit subject completely?
> New developers do not know who to ignore and you are telling
> them things that are wrong and not helpful at all.
Additional development views can occasionally become helpful.
> Please stop reviewing patches,
Patch review is one of the usual software development activities.
> this is not ok
I suggest to reconsider such a view once more.
> is actually harmful to our community.
Possible improvements are varying between affected software components.
Regards,
Markus
next prev parent reply other threads:[~2024-05-26 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 1:27 [PATCH v6] usb-storage: alauda: Check whether the media is initialized Shichao Lai
2024-05-26 6:49 ` Markus Elfring
2024-05-26 6:56 ` Greg Kroah-Hartman
2024-05-26 9:20 ` Markus Elfring [this message]
2024-05-26 11:43 ` [v6] " Greg Kroah-Hartman
2024-05-27 15:01 ` [PATCH v6] " Oliver Neukum
2024-05-27 15:20 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce266282-029f-4333-9ef8-6ddce64e661f@web.de \
--to=markus.elfring@web.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=samsun1006219@gmail.com \
--cc=shichaorai@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=xrivendell7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.