From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8568C433F5 for ; Tue, 26 Oct 2021 17:47:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB7D760E74 for ; Tue, 26 Oct 2021 17:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237927AbhJZRtw (ORCPT ); Tue, 26 Oct 2021 13:49:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236749AbhJZRtw (ORCPT ); Tue, 26 Oct 2021 13:49:52 -0400 Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F069AC061745 for ; Tue, 26 Oct 2021 10:47:27 -0700 (PDT) Received: by mail-il1-x131.google.com with SMTP id j10so132846ilu.2 for ; Tue, 26 Oct 2021 10:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C9tFGpLMa5xrDmXDxO7ju81p1Vqq09mwTmj1zWjZSPA=; b=WrpIcyns/rrvy6sy/Uu4SBiLUFp4VSA19rXS16RPf7+hIvg2l9cLNyCz8gUu9s1s4I EZmCdP3BHLTSNgYGw8rynX43/r0qkv7Dv8M/hYGXq4ym2mR/A7DYzukfrShsqYIrj6NS uDb9JzSmUZaovLW0n2H5mJMXIGUNz/ao41mCY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C9tFGpLMa5xrDmXDxO7ju81p1Vqq09mwTmj1zWjZSPA=; b=ftzrHLlkF5Vy6g4DcDFimDXNm5jFAMqlRNBXwAUDVVLpmJdFWYmcF7zUiTX69Ol31o olgw06wSYtryz2xbd4clqL78WFJ7tb8ffXVX1PEe+AiVWjFQDVOcA1RWXKCrRw38T9OH JVmbvraGP/yMrnrk1HnADlrqwx/mdViHvJRxBLM+uhcn2Gt7IxfKdnIEVymENo1zHOfe iEREHkRu4lmqxJSvxw0vISrZbREzGaPCEt2w+OhY12AfPwD1USF8gnIYmKk0A2fcKanJ fXkcYZJuf67K5S/StBKZvd8XExzosSedLUMvl1CQg96CCHLKRElZiLL8S2dAzeflddD4 832w== X-Gm-Message-State: AOAM533RXl78POmle89g3E2AEq+zzp5RUlNyMtWBPzmZyeUwKw4IMBbn k8ev1x3kRL1PCPsItB7av9oeJQ== X-Google-Smtp-Source: ABdhPJyZfrtMqU0bdcrMtX289RaYYgKkZvZ/cXE7jIlL4iq8P59U1UkVLcFOaycwBEOBddApgReW4w== X-Received: by 2002:a92:ca07:: with SMTP id j7mr15141191ils.119.1635270447357; Tue, 26 Oct 2021 10:47:27 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id r24sm10467666ioa.5.2021.10.26.10.47.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Oct 2021 10:47:26 -0700 (PDT) Subject: Re: [PATCH] selftests/bpf: fix fclose/pclose mismatch To: Andrea Righi , Shuah Khan , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko Cc: linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20211026143409.42666-1-andrea.righi@canonical.com> From: Shuah Khan Message-ID: Date: Tue, 26 Oct 2021 11:47:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20211026143409.42666-1-andrea.righi@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 10/26/21 8:34 AM, Andrea Righi wrote: > Make sure to use pclose() to properly close the pipe opened by popen(). > > Fixes: 81f77fd0deeb ("bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID") > Signed-off-by: Andrea Righi > --- > tools/testing/selftests/bpf/test_progs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c > index cc1cd240445d..e3fea6f281e4 100644 > --- a/tools/testing/selftests/bpf/test_progs.c > +++ b/tools/testing/selftests/bpf/test_progs.c > @@ -370,7 +370,7 @@ int extract_build_id(char *build_id, size_t size) > > if (getline(&line, &len, fp) == -1) > goto err; > - fclose(fp); > + pclose(fp); > > if (len > size) > len = size; > @@ -379,7 +379,7 @@ int extract_build_id(char *build_id, size_t size) > free(line); > return 0; > err: > - fclose(fp); > + pclose(fp); > return -1; > } > > Thank you for the patch. The return logic could be simpler doing out handling common for error and success path with just one call to close. Not related to this change though. Adding bpf maintainers to the thread Reviewed-by: Shuah Khan thanks, -- Shuah