From: Guoxin Pu <pugokushin@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] block: fix length of strscpy()
Date: Wed, 17 Jan 2024 14:11:46 +0800 [thread overview]
Message-ID: <ce4f98a3-7683-490b-a717-0eeb035cbd86@gmail.com> (raw)
In-Reply-To: <cb12eefa-9588-4244-a1de-b1ea62f6096d@kernel.dk>
On 02/01/2024 05:26, Jens Axboe wrote:
> On 1/1/24 10:50 AM, Guoxin Pu wrote:
>> In commit 146afeb235ccec10c17ad8ea26327c0c79dbd968 ("block: use strscpy()
>> to instead of strncpy()") , the length that should now represent the length
>> of the string with the terminating NULL was not updated alongside the
>> change.
>>
>> This has caused blkdevparts= definition on kernel cmdline to be not
>> correctly recognized and partitions not correctly initialized, breaking any
>> device relying on such partitions to boot, on stable releases since 6.6
>>
>> This patch fixes the lengths to contain the terminating NULL.
> This needs a Fixes line.
>
Sorry for the late reply.
Thank you for the review. The Fixes line was added and I've sent the new
patch as "[PATCH v2] block: fix length of strscpy()" earlier on Jan, 2nd.
And since 6.7 is out, do I need to rework the v2 patch and add cc stable
6.7.x?
next prev parent reply other threads:[~2024-01-17 6:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 17:50 [PATCH] block: fix length of strscpy() Guoxin Pu
2024-01-01 21:26 ` Jens Axboe
2024-01-17 6:11 ` Guoxin Pu [this message]
2024-01-01 21:47 ` David Laight
2024-01-02 2:31 ` Guoxin Pu
2024-01-02 9:14 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce4f98a3-7683-490b-a717-0eeb035cbd86@gmail.com \
--to=pugokushin@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.