From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932344AbcFNTPk (ORCPT ); Tue, 14 Jun 2016 15:15:40 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:39258 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371AbcFNTPh (ORCPT ); Tue, 14 Jun 2016 15:15:37 -0400 Subject: Re: [PATCH] selftests/exec: Add Makefile to install list since exec test expect it To: Shuah Khan , , References: <1465929912-11516-1-git-send-email-scientist@fb.com> <57605679.7080401@osg.samsung.com> CC: From: Yannick Brosseau Message-ID: Date: Tue, 14 Jun 2016 12:15:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <57605679.7080401@osg.samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c091:200::a:5bfe] X-ClientProxiedBy: DB5PR07CA0035.eurprd07.prod.outlook.com (10.167.223.45) To BLUPR15MB0115.namprd15.prod.outlook.com (10.161.125.147) X-MS-Office365-Filtering-Correlation-Id: 0085c12a-0a76-4a5f-b0e0-08d3948841d3 X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0115;2:iuEG4L7PwAa2A19ogDTfwuan1bonQWBUJMT6v2+O0CurtexdCOWS97Nok5KA+sbN9LPRE3HgdZ+7VRg8sh8rsHFHUErFk/shsG7oGUfw2kCCSp/lSA7zmwiumK/suVOiIK0J/SnNuQsECM0RxEMt6cUzXQh/+j7QqsFL3yae0iY7Olks1eOUHli/QWd6Q+ws;3:aWKj9UHE11+zv/Rqb4uI/Kup66wSiPEqET0qKGFmY1OADeJY7yvu7Z5tAAyj02oyqW7xRul7vHklpETf2rN55tkMuIi/rBYpcMi/zN/StKesjVS8rpBUkylNOsXUYgL8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR15MB0115; X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0115;25:1VvC5P4HTaQHMzDwk7tbMwykwOjFnUJE2djeqLqYurlR4ntqJzlUzgkPuddDWaIwupYyUoOpwFAjGWnFTWC48h08GamoKynp+7m0M1wzgGknr2/7z1FsDluP7p4rqrTf+x3I/fKc3m+qPTBDfBR5cYRF8pCB5oag0CcBOC2T96buxXxW40C7xt1uSSEGWDmT+hUJhDsKZQNrZ4GJKgC63JpN7UUux67ToBb36463iVC8cWX02QpFHYKR+yzg0V8hS2szikc35uaVceX1sB2zYdWVYvH6Q9RjNEJB9dM+pi3ALHoGs5Qd2dqNCOk5LdpiIcN9x9T/kLdWSHyiznizdHP9aqbVn38aRGx/V6meKHnYnJhT7OiC5C1GIJHhdvOAwonG25MzKu4atX5E0Ja/ApDT4VCIkhG/h+mgzCg2Q1IptdVI/f5fjP88DBmWx+wvcnYWP7ZZxg/drn5zmyC0I4MWKwnApKr5V384pQgslZRRGgkcV6exn5ktTQZKld9M2FjS5y+FHxyAJT9+5RvCYd95QciTpvlIcjTK8iQyzjZNE3ne1r+WvzgRy1PJdMytm0S2UL5HJoNPasBksmQlnbjJuWxqRVZyJU9jaQThJbio7AVvU40yJlYYyqhpFTVGK6eyj8JRqoAlEWE33dxilWpp7+ZrtmnC5zGuTsnKKL5LhTGx2CEuWiI9i6l5GCRYM8YNDMRIzoUAeICGOFvCpahHa2YTj9iNHlT6oSA9Hw8=;20:gMA8FaWya7sQzerhBgxFqk/9kG561dZ4n+Q726772R16+qyienYvmtKG4OlYwZT0hWcruaLV37J9kggl7eZqRs3f9l3Ln7FRXZbYVthKgoGb2LeQzkRgEaxhxZUbRn7iujOp8tk8bJ5eudFt+Kp0fBpDDnZEPt5XZSELGSLim1U= X-LD-Processed: 8ae927fe-1255-47a7-a2af-5f3a069daaa2,ExtAddr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BLUPR15MB0115;BCL:0;PCL:0;RULEID:;SRVR:BLUPR15MB0115; X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0115;4:4s7gLRwTSAx5gj2JmyGvmI/dtobKfw8GovCtNyBEg0MibGxAhEMbxpvmE29RUPUs41ihXppOZr4/5FNYj1Aif7yhlyntTEW1yCM29KwTos5E4w44aK3Hn6/zen3JW4Mj/exQnNpmckPCWKcmRJoH2/jD8kpbvGZj3ts3/M0Bd32GRWl5dH5o+MnDaUJu8TcmF51hW8zreVOmhnVMXJ3e5IodwcLHWog8AfsyYk8zahVKF6t5G/c4gpcNS61K0KGS2d0I4udXzUygNCMd4aXaV2F1ekqP0XXV8SMYZWlfTovwz0PJ6QHqZBiTre1bVbKi78hGnU0cFlUFXMd1de61xcKSTlHGlsyXexxfC/jLopQDP+HwbcL+19VpAXvPFNdMWDcMYeroiA8EsspUK5QcSf5Tw2BesBEhJ+XUMT3TsS0= X-Forefront-PRVS: 09730BD177 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(24454002)(377454003)(199003)(189002)(47776003)(33646002)(42186005)(31686004)(4326007)(50466002)(2201001)(2906002)(106356001)(105586002)(586003)(6116002)(1706002)(83506001)(19580405001)(5004730100002)(64126003)(36756003)(77096005)(23746002)(19580395003)(54356999)(76176999)(189998001)(2950100001)(101416001)(5008740100001)(92566002)(31696002)(81166006)(8676002)(81156014)(50986999)(97736004)(230700001)(68736007)(4001350100001)(5001770100001)(3826002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR15MB0115;H:[IPv6:2620:10d:c0a3:10fb:6267:20ff:fefd:5ccc];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR15MB0115;23:pA4wm7Cc5Sd8flbh+oIEFYGjAMRClfrng/QE7?= =?Windows-1252?Q?jUdr2LHyrRkfqCNNJfOJo5zdvSTwtDxKuCdB5GsJUeTfsZUyp4739oiT?= =?Windows-1252?Q?NZeN80QAfLt+Yj3I+8dzh7Mt8nwu26fvqlU+60dNEx9KklkExpTW3S/T?= =?Windows-1252?Q?dzsM8qy0301UsNBF81lwoOBI6iw9SHc6GA+ND/I4TaRI05aecTq93lr7?= =?Windows-1252?Q?h/ercjdazXveHQEDYrYCiiJwebkjfOsGuRB0rUrOnS6hfgAPmQiRXmwq?= =?Windows-1252?Q?gEjpGapnQXD2vS2ZtBCNN3mA0MChTbm7/RAAkdrfgWsNRu/ZyEc+P85s?= =?Windows-1252?Q?5vYz98dc/dFlCuTEmDWQoS0ccHFGiflpym4PYpE7yOmAqQGIzegKGmu4?= =?Windows-1252?Q?A9MXIqwl/agpnD/Mq1NqDR+dh6YGCfN6qkTshe+TXf5hSbBvbOm1GEBW?= =?Windows-1252?Q?ionvxDR7O/JnviRxgzkhBKjRTw3chi8KZh+1Lwl5H39nJMSLEm1H0UxD?= =?Windows-1252?Q?wdWReNUDW7Vtfdtl9xnTUB+oY0cMil9MYPxCvXP9+588HXBm9ggWYT3v?= =?Windows-1252?Q?1s1/avAEZTbp/WiiGj1uXhoTKhBimnsSADGDPcsxbGg1x9WyDaLSdCkH?= =?Windows-1252?Q?WXtIV/3cDLPu3ywzwKvuMfQa6f9tcdgORRC8SdCniPcboSueZlOJbdm3?= =?Windows-1252?Q?D3mND3oNC16m0Abfjr75yb+JILRD5vi13ItN4DjpfWCKBJ+7rWqu+dI5?= =?Windows-1252?Q?+f8YZydLPDpoFSFwpTDbpJMHDAHWurNaj6wC51C5nLzGDi1gWrB8XQpm?= =?Windows-1252?Q?CyDuHvjD3XBpKR+HmaLLTvB7JgRedc/GQ4K2ir5bdfL2BBjd2k3j2K/V?= =?Windows-1252?Q?d6TpQBTzZSBYrsPZZenJzkGXDBgB3dwcEhQfRwd5KLphIWe+kdiAGPJd?= =?Windows-1252?Q?0MPUJZB+bmeJkhvDL8yk86xO4zaoBaUZjK8iP5VcXFZOFVUC0iptkoF/?= =?Windows-1252?Q?J1ZD9mBhHQmii1ToMwlxeog2oeLzDvUBeLjQeIUwb/d4nrMCxUvycSYr?= =?Windows-1252?Q?8d6tGjVk06WEV5l7RlbirgYsUpeLvJP9CyuJ5aa2nsSEmpYlsRPwiu/4?= =?Windows-1252?Q?tJ48EYlrUs4QAostQ++tRDeQmDEQyCzZnn16WIEpjsa6UcTjGlcFCwSt?= =?Windows-1252?Q?Ugs06f3/XMfde71cCofm99M5ng8d5ET01Nrjkcuoh3nQCHWaTg8qgkwi?= =?Windows-1252?Q?khny1n8KzmeIp0rQd0vmygj9ImUuLrKKizK7uYQouLtve9wwzPabNOu0?= =?Windows-1252?Q?Q00?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0115;6:OiqlLNHPq7HsEVJKz8bPYcAFy5sFDFGo3sYLA6XoPD7dYJCwrv3dHSSE7OPgKQNgZ8Xa8wrEgYViubosda9iPdg2N66eiy+U0pHnn+MiC+PO9EdB0AbBNWdTRTuGd0dbZ16GDtV+GPWXrRHVIUMijPTSqeTPAuGfHHtAhj7P8NPA8dEFjWNqw/26DWBwkIh32lSO0WLUUUG8pbEBYFALpP8F5gUefbdV9nH4HwaoQ3f0cH4ZjpIxowKmRdzVMbTd4iC2ZWahp5itJWuK8N7gOQ==;5:BWmD1R6obS6CT3xYvzXqxCXxuf61C+/qotOsyVtSiR5xiCBpD7MzAxNA92115SqGz7aouMzzZIJ0v4qTj3t9EPes74WWoK3MXkTdkNvULf6ogB6DPBcdsFa2TPbYfSzoKERa7JZP7Z58+xIRzkpdwQ==;24:Xi6ib2VpEr5ToQjo5sNi/wNQGDMbXpanzNbCB5qGJA+1U4KOQVmDoxPn39P+y4Ja9/SKRkxLDdBreEyQJWGgffSmPJFW1ukF9yxpql/oGEU=;7:ejtGYrSuYxelZkmXP4cTR7GR5vzVrgUFunJ3M6EALToDJ9nqe3jxTyxwWfd8PKZKCWSkCE0ES4Mkqo8DUptE0qwpRMnY4cBBfEz/YHT1vzi0ctoZ5gF1vDICeI2G2GDk7bS75V2aHr7dyM1bO6zO9NGL8XgOV/Z5Xa0mQNnYEw4PWLfQVhxD/SAHEkEYaH62b3mmE9hElQ5vN6C3yoxiDA==;20:yY55kuYqhFqAi0oOhkOUnfTOkjMVpcitXPOpVQI7hE9IR05voiQhtY5ndkmnUs1ti1aybRtjEMgXTdQGGQ+pbA/UDPovLuazFv57rPln6eHMRBs52kRd7V413F7rWloEzDfja8vpUuwwuDobTQNqwmHypoNNTwdDV7Iy1Dr23q8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2016 19:15:31.3977 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR15MB0115 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-14_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/14/2016 12:09 PM, Shuah Khan wrote: > On 06/14/2016 12:45 PM, Yannick Brosseau wrote: >> When running the execveat test once installed, the Makefile it not available and the >> test fail. Bundling the Makefile file with the installed files fix that. > Install is for installing kselftest binaries and run-time dependencies > if any on a target system. It is not for being able to build it on the > target. Bundling Makefile doesn't make sense. The test tries to exec the Makefile file: fail += check_execveat_fail(dot_dfd, "Makefile", 0, EACCES); So it's a runtime dependency at the moment. We can either change the test to try to open another file or add the Makefile Yannick > -- Shuah > >> Signed-off-by: Yannick Brosseau >> --- >> tools/testing/selftests/exec/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile >> index 4e400eb..d2be580 100644 >> --- a/tools/testing/selftests/exec/Makefile >> +++ b/tools/testing/selftests/exec/Makefile >> @@ -1,6 +1,6 @@ >> CFLAGS = -Wall >> BINARIES = execveat >> -DEPS = execveat.symlink execveat.denatured script subdir >> +DEPS = execveat.symlink execveat.denatured script subdir Makefile >> all: $(BINARIES) $(DEPS) >> >> subdir: >>