From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=jae.hyun.yoo@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43h9dp683RzDqnD for ; Sat, 19 Jan 2019 06:15:57 +1100 (AEDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2019 11:15:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,491,1539673200"; d="scan'208";a="110965538" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.143]) ([10.7.153.143]) by orsmga008.jf.intel.com with ESMTP; 18 Jan 2019 11:15:55 -0800 Subject: Re: [PATCH v10 10/12] hwmon: Add PECI cputemp driver To: Miguel Ojeda Cc: Lee Jones , Rob Herring , Jean Delvare , Guenter Roeck , Mark Rutland , Joel Stanley , Andrew Jeffery , Jonathan Corbet , Greg Kroah-Hartman , Gustavo Pimentel , Kishon Vijay Abraham I , Lorenzo Pieralisi , "Darrick J . Wong" , Eric Sandeen , Arnd Bergmann , Wu Hao , Tomohiro Kusumi , "Bryant G . Ly" , Frederic Barrat , "David S . Miller" , Mauro Carvalho Chehab , Andrew Morton , Randy Dunlap , Philippe Ombredanne , Vinod Koul , Stephen Boyd , David Kershner , Uwe Kleine-Konig , Sagar Dharia , Johan Hovold , Thomas Gleixner , Juergen Gross , Cyrille Pitchen , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel , Linux Doc Mailing List , openbmc@lists.ozlabs.org, Alan Cox , Andy Shevchenko , Jason M Biils , Andrew Lunn , Stef van Os , Haiyue Wang , James Feist , Vernon Mauery References: <20190107214136.5256-1-jae.hyun.yoo@linux.intel.com> <20190107214136.5256-11-jae.hyun.yoo@linux.intel.com> <8ef997aa-2971-2907-3821-e71f9e8dd53a@linux.intel.com> From: Jae Hyun Yoo Message-ID: Date: Fri, 18 Jan 2019 11:15:54 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 21 Jan 2019 12:39:16 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 19:15:59 -0000 Hi Miguel, On 1/18/2019 11:05 AM, Miguel Ojeda wrote: > Hi Jae, > > On Fri, Jan 18, 2019 at 6:52 PM Jae Hyun Yoo > wrote: >> >> I'm assuming you meant: >> >> return !(temp->valid && time_before(jiffies, temp->last_updated + >> UPDATE_INTERVAL)); > > Yeah, or return !... || !..., whatever you feel is more comprehensible. :) > Okay, I'll change it like above. >> Thanks for your review! > > You're welcome! It is just nitpicking, but I thought sending the email > wouldn't hurt too much (in case you do another version of the series, > otherwise don't change it just for this! :-) > Currently, I'm making v11 series. I'll address your comments when I submit the version. Thanks again for your review! :) Regards, Jae > Cheers, > Miguel >