From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DB4CC7EE31 for ; Thu, 26 Jun 2025 13:58:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:Subject:From:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jxJ/+GIT8i2T2VJ1n6tfW4Ns7LsKzLgWRa8bu373EG0=; b=J4qMvkgVSzOJqfkoculgqXgWhF X7iDAMhptpy7p4CCKYxKoTfU/Ftkcc2bBCvgYv2n8pmtAixIiIRdoUnOHwA04/6s8tg2i5kbYWBXH OHqwlZe4NXPF78SCfU1XbtsQyA8brSHPgLE7qZ5r8o3XqGSt6La2x49Oa8N9fO4qGHgTPYQiJBGMg lOqV29jEmcEYPK1HZhLKBQ7tQZgfJ+S2deiVJu9evaMWIL++LHh8g/bMTwaPpSqhunMC8lOWE4Uzw ygzV9ZfQyUEEhuHhcCkuRlzioAic/5SYrJd0ERXS9bJVkuSNpbNMoyvHeEtQ8gt/V5CyYhuHbC2IY 2A85JSRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUn71-0000000BpW0-1khb; Thu, 26 Jun 2025 13:57:59 +0000 Received: from out-177.mta0.migadu.com ([2001:41d0:1004:224b::b1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUn2k-0000000Blio-1raY for linux-arm-kernel@lists.infradead.org; Thu, 26 Jun 2025 13:53:35 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1750946001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jxJ/+GIT8i2T2VJ1n6tfW4Ns7LsKzLgWRa8bu373EG0=; b=q3Rv2EQwghbWQOo1XaSDbcFu49quE13kRIvVREM0PKjnsNVV1rc3AS10a0Mx3LudcEXvHs sDaC2vuB+PvgI3l8Q1InsFKXX5w4xajOJHTVvZnsY2a+Aa4C7FzZrtH3nn7i95qwN2ot5Z QHjYdgduBbJf/3HTfvAdwv0zsn5hlAM= Date: Thu, 26 Jun 2025 21:52:58 +0800 MIME-Version: 1.0 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation To: David Hildenbrand Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com, Lance Yang References: <20250626092905.31305-1-ioworker0@gmail.com> <20250626124445.77865-1-ioworker0@gmail.com> <1a55f9f3-f5b1-4761-97ba-423756c707fe@redhat.com> Content-Language: en-US In-Reply-To: <1a55f9f3-f5b1-4761-97ba-423756c707fe@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250626_065334_614500_97659AF2 X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2025/6/26 21:16, David Hildenbrand wrote: > On 26.06.25 14:44, Lance Yang wrote: >> >> On 2025/6/26 17:29, Lance Yang wrote: >>> Before I send out the real patch, I'd like to get some quick feedback to >>> ensure I've understood the discussion correctly ;) >>> >>> Does this look like the right direction? >>> >>> diff --git a/mm/rmap.c b/mm/rmap.c >>> index fb63d9256f09..5ebffe2137e4 100644 >>> --- a/mm/rmap.c >>> +++ b/mm/rmap.c >>> @@ -1845,23 +1845,37 @@ void folio_remove_rmap_pud(struct folio >>> *folio, struct page *page, >>>    #endif >>>    } >>> -/* We support batch unmapping of PTEs for lazyfree large folios */ >>> -static inline bool can_batch_unmap_folio_ptes(unsigned long addr, >>> -            struct folio *folio, pte_t *ptep) >>> +static inline unsigned int folio_unmap_pte_batch(struct folio *folio, >>> +            struct page_vma_mapped_walk *pvmw, >>> +            enum ttu_flags flags, pte_t pte) >>>    { >>>        const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; >>> -    int max_nr = folio_nr_pages(folio); >>> -    pte_t pte = ptep_get(ptep); >>> +    unsigned long end_addr, addr = pvmw->address; >>> +    struct vm_area_struct *vma = pvmw->vma; >>> +    unsigned int max_nr; >>> + >>> +    if (flags & TTU_HWPOISON) >>> +        return 1; >>> +    if (!folio_test_large(folio)) >>> +        return 1; >>> +    /* We may only batch within a single VMA and a single page >>> table. */ >>> +    end_addr = pmd_addr_end(addr, vma->vm_end); >>> +    max_nr = (end_addr - addr) >> PAGE_SHIFT; >>> + >>> +    /* We only support lazyfree batching for now ... */ >>>        if (!folio_test_anon(folio) || folio_test_swapbacked(folio)) >>> -        return false; >>> +        return 1; >>>        if (pte_unused(pte)) >>> -        return false; >>> -    if (pte_pfn(pte) != folio_pfn(folio)) >>> -        return false; >>> +        return 1; >>> + >>> +    /* ... where we must be able to batch the whole folio. */ >>> +    if (pte_pfn(pte) != folio_pfn(folio) || max_nr != >>> folio_nr_pages(folio)) >>> +        return 1; >>> +    max_nr = folio_pte_batch(folio, addr, pvmw->pte, pte, max_nr, >>> fpb_flags, >>> +                 NULL, NULL, NULL); >>> -    return folio_pte_batch(folio, addr, ptep, pte, max_nr, >>> fpb_flags, NULL, >>> -                   NULL, NULL) == max_nr; >>> +    return (max_nr != folio_nr_pages(folio)) ? 1 : max_nr; >>>    } >>>    /* >>> @@ -2024,9 +2038,7 @@ static bool try_to_unmap_one(struct folio >>> *folio, struct vm_area_struct *vma, >>>                if (pte_dirty(pteval)) >>>                    folio_mark_dirty(folio); >>>            } else if (likely(pte_present(pteval))) { >>> -            if (folio_test_large(folio) && !(flags & TTU_HWPOISON) && >>> -                can_batch_unmap_folio_ptes(address, folio, pvmw.pte)) >>> -                nr_pages = folio_nr_pages(folio); >>> +            nr_pages = folio_unmap_pte_batch(folio, &pvmw, flags, >>> pteval); >>>                end_addr = address + nr_pages * PAGE_SIZE; >>>                flush_cache_range(vma, address, end_addr); >>> @@ -2206,13 +2218,16 @@ static bool try_to_unmap_one(struct folio >>> *folio, struct vm_area_struct *vma, >>>                hugetlb_remove_rmap(folio); >>>            } else { >>>                folio_remove_rmap_ptes(folio, subpage, nr_pages, vma); >>> -            folio_ref_sub(folio, nr_pages - 1); >>>            } >>>            if (vma->vm_flags & VM_LOCKED) >>>                mlock_drain_local(); >>> -        folio_put(folio); >>> -        /* We have already batched the entire folio */ >>> -        if (nr_pages > 1) >>> +        folio_put_refs(folio, nr_pages); >>> + >>> +        /* >>> +         * If we are sure that we batched the entire folio and cleared >>> +         * all PTEs, we can just optimize and stop right here. >>> +         */ >>> +        if (nr_pages == folio_nr_pages(folio)) >>>                goto walk_done; >>>            continue; >>>    walk_abort: >>> -- >> >> Oops ... Through testing on my machine, I found that the logic doesn't >> behave as expected because I messed up the meaning of max_nr (the >> available >> scan room in the page table) with folio_nr_pages(folio) :( >> >> With the following change: >> >> diff --git a/mm/rmap.c b/mm/rmap.c >> index 5ebffe2137e4..b1407348e14e 100644 >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -1850,9 +1850,9 @@ static inline unsigned int >> folio_unmap_pte_batch(struct folio *folio, >>               enum ttu_flags flags, pte_t pte) >>   { >>       const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; >> +    unsigned int max_nr, nr_pages = folio_nr_pages(folio); >>       unsigned long end_addr, addr = pvmw->address; >>       struct vm_area_struct *vma = pvmw->vma; >> -    unsigned int max_nr; >>       if (flags & TTU_HWPOISON) >>           return 1; >> @@ -1870,12 +1870,13 @@ static inline unsigned int >> folio_unmap_pte_batch(struct folio *folio, >>           return 1; >>       /* ... where we must be able to batch the whole folio. */ > > Why is that still required? :) Sorry ... I was still stuck in the "all-or-nothing" mindset ... So, IIUC, you mean we should completely remove the "max_nr < nr_pages" check and just let folio_pte_batch handle whatever partial batch it safely can. > >> -    if (pte_pfn(pte) != folio_pfn(folio) || max_nr != >> folio_nr_pages(folio)) >> +    if (pte_pfn(pte) != folio_pfn(folio) || max_nr < nr_pages) >>           return 1; >> -    max_nr = folio_pte_batch(folio, addr, pvmw->pte, pte, max_nr, >> fpb_flags, >> -                 NULL, NULL, NULL); >> -    return (max_nr != folio_nr_pages(folio)) ? 1 : max_nr; >> +    max_nr = folio_pte_batch(folio, addr, pvmw->pte, pte, nr_pages, >> +                 fpb_flags, NULL, NULL, NULL); >> + >> +    return (max_nr != nr_pages) ? 1 : max_nr; > > Why is that still required? :) Then simply return the number of PTEs that consecutively map to the large folio. Right? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 949E9C7EE32 for ; Thu, 26 Jun 2025 13:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject:From: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X/zBcHDltdVUZdyXHOcEUwVUaoveYHJ7+ILOWSg+QOY=; b=ejdlq8CO9F8rSq AUSsUTQGZxv6FTwUvEPa+n/c+WmU5xi3+gTJCCOMs5eWMK4WmzByXO4hDWY1FuxebuNkVsbK3/FNE +wwXwY1RlTp/fmnAweDDoxBCpqjEiXlg8tNjbLEFmxEsPPp69PmsvY8jYAbRc4BGdYUOmX9OeyjnS PeVNPOMw7zE4q6FsIikQyv0GX0ixUqC621Nu1tfe83G95FEd7Lsku+ikaaeGGMA4fGhiwR1sczTl6 jACX3aBZ/elos3U9SaGuKIG0PIb+rSMr2ZwUVaSQrR/hUyT/EoEd20Yan6RD/TlDcJY645r8kf9iB 9L+UMlvasjFq805W9G3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUn71-0000000BpWH-45P9; Thu, 26 Jun 2025 13:57:59 +0000 Received: from out-183.mta0.migadu.com ([2001:41d0:1004:224b::b7]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUn2u-0000000Blt4-1AtX for linux-riscv@lists.infradead.org; Thu, 26 Jun 2025 13:53:45 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1750946001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jxJ/+GIT8i2T2VJ1n6tfW4Ns7LsKzLgWRa8bu373EG0=; b=q3Rv2EQwghbWQOo1XaSDbcFu49quE13kRIvVREM0PKjnsNVV1rc3AS10a0Mx3LudcEXvHs sDaC2vuB+PvgI3l8Q1InsFKXX5w4xajOJHTVvZnsY2a+Aa4C7FzZrtH3nn7i95qwN2ot5Z QHjYdgduBbJf/3HTfvAdwv0zsn5hlAM= Date: Thu, 26 Jun 2025 21:52:58 +0800 MIME-Version: 1.0 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation To: David Hildenbrand Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com, Lance Yang References: <20250626092905.31305-1-ioworker0@gmail.com> <20250626124445.77865-1-ioworker0@gmail.com> <1a55f9f3-f5b1-4761-97ba-423756c707fe@redhat.com> Content-Language: en-US In-Reply-To: <1a55f9f3-f5b1-4761-97ba-423756c707fe@redhat.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250626_065344_451665_8473DC39 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org CgpPbiAyMDI1LzYvMjYgMjE6MTYsIERhdmlkIEhpbGRlbmJyYW5kIHdyb3RlOgo+IE9uIDI2LjA2 LjI1IDE0OjQ0LCBMYW5jZSBZYW5nIHdyb3RlOgo+Pgo+PiBPbiAyMDI1LzYvMjYgMTc6MjksIExh bmNlIFlhbmcgd3JvdGU6Cj4+PiBCZWZvcmUgSSBzZW5kIG91dCB0aGUgcmVhbCBwYXRjaCwgSSdk IGxpa2UgdG8gZ2V0IHNvbWUgcXVpY2sgZmVlZGJhY2sgdG8KPj4+IGVuc3VyZSBJJ3ZlIHVuZGVy c3Rvb2QgdGhlIGRpc2N1c3Npb24gY29ycmVjdGx5IDspCj4+Pgo+Pj4gRG9lcyB0aGlzIGxvb2sg bGlrZSB0aGUgcmlnaHQgZGlyZWN0aW9uPwo+Pj4KPj4+IGRpZmYgLS1naXQgYS9tbS9ybWFwLmMg Yi9tbS9ybWFwLmMKPj4+IGluZGV4IGZiNjNkOTI1NmYwOS4uNWViZmZlMjEzN2U0IDEwMDY0NAo+ Pj4gLS0tIGEvbW0vcm1hcC5jCj4+PiArKysgYi9tbS9ybWFwLmMKPj4+IEBAIC0xODQ1LDIzICsx ODQ1LDM3IEBAIHZvaWQgZm9saW9fcmVtb3ZlX3JtYXBfcHVkKHN0cnVjdCBmb2xpbyAKPj4+ICpm b2xpbywgc3RydWN0IHBhZ2UgKnBhZ2UsCj4+PiDCoMKgICNlbmRpZgo+Pj4gwqDCoCB9Cj4+PiAt LyogV2Ugc3VwcG9ydCBiYXRjaCB1bm1hcHBpbmcgb2YgUFRFcyBmb3IgbGF6eWZyZWUgbGFyZ2Ug Zm9saW9zICovCj4+PiAtc3RhdGljIGlubGluZSBib29sIGNhbl9iYXRjaF91bm1hcF9mb2xpb19w dGVzKHVuc2lnbmVkIGxvbmcgYWRkciwKPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVj dCBmb2xpbyAqZm9saW8sIHB0ZV90ICpwdGVwKQo+Pj4gK3N0YXRpYyBpbmxpbmUgdW5zaWduZWQg aW50IGZvbGlvX3VubWFwX3B0ZV9iYXRjaChzdHJ1Y3QgZm9saW8gKmZvbGlvLAo+Pj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHBhZ2Vfdm1hX21hcHBlZF93YWxrICpwdm13LAo+Pj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZW51bSB0dHVfZmxhZ3MgZmxhZ3MsIHB0ZV90IHB0ZSkK Pj4+IMKgwqAgewo+Pj4gwqDCoMKgwqDCoMKgIGNvbnN0IGZwYl90IGZwYl9mbGFncyA9IEZQQl9J R05PUkVfRElSVFkgfCBGUEJfSUdOT1JFX1NPRlRfRElSVFk7Cj4+PiAtwqDCoMKgIGludCBtYXhf bnIgPSBmb2xpb19ucl9wYWdlcyhmb2xpbyk7Cj4+PiAtwqDCoMKgIHB0ZV90IHB0ZSA9IHB0ZXBf Z2V0KHB0ZXApOwo+Pj4gK8KgwqDCoCB1bnNpZ25lZCBsb25nIGVuZF9hZGRyLCBhZGRyID0gcHZt dy0+YWRkcmVzczsKPj4+ICvCoMKgwqAgc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEgPSBwdm13 LT52bWE7Cj4+PiArwqDCoMKgIHVuc2lnbmVkIGludCBtYXhfbnI7Cj4+PiArCj4+PiArwqDCoMKg IGlmIChmbGFncyAmIFRUVV9IV1BPSVNPTikKPj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gMTsK Pj4+ICvCoMKgwqAgaWYgKCFmb2xpb190ZXN0X2xhcmdlKGZvbGlvKSkKPj4+ICvCoMKgwqDCoMKg wqDCoCByZXR1cm4gMTsKPj4+ICvCoMKgwqAgLyogV2UgbWF5IG9ubHkgYmF0Y2ggd2l0aGluIGEg c2luZ2xlIFZNQSBhbmQgYSBzaW5nbGUgcGFnZSAKPj4+IHRhYmxlLiAqLwo+Pj4gK8KgwqDCoCBl bmRfYWRkciA9IHBtZF9hZGRyX2VuZChhZGRyLCB2bWEtPnZtX2VuZCk7Cj4+PiArwqDCoMKgIG1h eF9uciA9IChlbmRfYWRkciAtIGFkZHIpID4+IFBBR0VfU0hJRlQ7Cj4+PiArCj4+PiArwqDCoMKg IC8qIFdlIG9ubHkgc3VwcG9ydCBsYXp5ZnJlZSBiYXRjaGluZyBmb3Igbm93IC4uLiAqLwo+Pj4g wqDCoMKgwqDCoMKgIGlmICghZm9saW9fdGVzdF9hbm9uKGZvbGlvKSB8fCBmb2xpb190ZXN0X3N3 YXBiYWNrZWQoZm9saW8pKQo+Pj4gLcKgwqDCoMKgwqDCoMKgIHJldHVybiBmYWxzZTsKPj4+ICvC oMKgwqDCoMKgwqDCoCByZXR1cm4gMTsKPj4+IMKgwqDCoMKgwqDCoCBpZiAocHRlX3VudXNlZChw dGUpKQo+Pj4gLcKgwqDCoMKgwqDCoMKgIHJldHVybiBmYWxzZTsKPj4+IC3CoMKgwqAgaWYgKHB0 ZV9wZm4ocHRlKSAhPSBmb2xpb19wZm4oZm9saW8pKQo+Pj4gLcKgwqDCoMKgwqDCoMKgIHJldHVy biBmYWxzZTsKPj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gMTsKPj4+ICsKPj4+ICvCoMKgwqAg LyogLi4uIHdoZXJlIHdlIG11c3QgYmUgYWJsZSB0byBiYXRjaCB0aGUgd2hvbGUgZm9saW8uICov Cj4+PiArwqDCoMKgIGlmIChwdGVfcGZuKHB0ZSkgIT0gZm9saW9fcGZuKGZvbGlvKSB8fCBtYXhf bnIgIT0gCj4+PiBmb2xpb19ucl9wYWdlcyhmb2xpbykpCj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0 dXJuIDE7Cj4+PiArwqDCoMKgIG1heF9uciA9IGZvbGlvX3B0ZV9iYXRjaChmb2xpbywgYWRkciwg cHZtdy0+cHRlLCBwdGUsIG1heF9uciwgCj4+PiBmcGJfZmxhZ3MsCj4+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgTlVMTCwgTlVMTCwgTlVMTCk7Cj4+PiAtwqDCoMKgIHJldHVy biBmb2xpb19wdGVfYmF0Y2goZm9saW8sIGFkZHIsIHB0ZXAsIHB0ZSwgbWF4X25yLCAKPj4+IGZw Yl9mbGFncywgTlVMTCwKPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg TlVMTCwgTlVMTCkgPT0gbWF4X25yOwo+Pj4gK8KgwqDCoCByZXR1cm4gKG1heF9uciAhPSBmb2xp b19ucl9wYWdlcyhmb2xpbykpID8gMSA6IG1heF9ucjsKPj4+IMKgwqAgfQo+Pj4gwqDCoCAvKgo+ Pj4gQEAgLTIwMjQsOSArMjAzOCw3IEBAIHN0YXRpYyBib29sIHRyeV90b191bm1hcF9vbmUoc3Ry dWN0IGZvbGlvIAo+Pj4gKmZvbGlvLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwKPj4+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHB0ZV9kaXJ0eShwdGV2YWwpKQo+Pj4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZvbGlvX21hcmtfZGlydHkoZm9saW8p Owo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqAgfSBlbHNlIGlmIChsaWtlbHkocHRlX3ByZXNlbnQo cHRldmFsKSkpIHsKPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChmb2xpb190ZXN0X2xh cmdlKGZvbGlvKSAmJiAhKGZsYWdzICYgVFRVX0hXUE9JU09OKSAmJgo+Pj4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBjYW5fYmF0Y2hfdW5tYXBfZm9saW9fcHRlcyhhZGRyZXNzLCBm b2xpbywgcHZtdy5wdGUpKQo+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBucl9w YWdlcyA9IGZvbGlvX25yX3BhZ2VzKGZvbGlvKTsKPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IG5yX3BhZ2VzID0gZm9saW9fdW5tYXBfcHRlX2JhdGNoKGZvbGlvLCAmcHZtdywgZmxhZ3MsIAo+ Pj4gcHRldmFsKTsKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZW5kX2FkZHIgPSBh ZGRyZXNzICsgbnJfcGFnZXMgKiBQQUdFX1NJWkU7Cj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIGZsdXNoX2NhY2hlX3JhbmdlKHZtYSwgYWRkcmVzcywgZW5kX2FkZHIpOwo+Pj4gQEAg LTIyMDYsMTMgKzIyMTgsMTYgQEAgc3RhdGljIGJvb2wgdHJ5X3RvX3VubWFwX29uZShzdHJ1Y3Qg Zm9saW8gCj4+PiAqZm9saW8sIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hLAo+Pj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBodWdldGxiX3JlbW92ZV9ybWFwKGZvbGlvKTsKPj4+IMKg wqDCoMKgwqDCoMKgwqDCoMKgIH0gZWxzZSB7Cj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGZvbGlvX3JlbW92ZV9ybWFwX3B0ZXMoZm9saW8sIHN1YnBhZ2UsIG5yX3BhZ2VzLCB2bWEp Owo+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZm9saW9fcmVmX3N1Yihmb2xpbywgbnJfcGFn ZXMgLSAxKTsKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPj4+IMKgwqDCoMKgwqDCoMKgwqDC oMKgIGlmICh2bWEtPnZtX2ZsYWdzICYgVk1fTE9DS0VEKQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBtbG9ja19kcmFpbl9sb2NhbCgpOwo+Pj4gLcKgwqDCoMKgwqDCoMKgIGZvbGlv X3B1dChmb2xpbyk7Cj4+PiAtwqDCoMKgwqDCoMKgwqAgLyogV2UgaGF2ZSBhbHJlYWR5IGJhdGNo ZWQgdGhlIGVudGlyZSBmb2xpbyAqLwo+Pj4gLcKgwqDCoMKgwqDCoMKgIGlmIChucl9wYWdlcyA+ IDEpCj4+PiArwqDCoMKgwqDCoMKgwqAgZm9saW9fcHV0X3JlZnMoZm9saW8sIG5yX3BhZ2VzKTsK Pj4+ICsKPj4+ICvCoMKgwqDCoMKgwqDCoCAvKgo+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBJZiB3 ZSBhcmUgc3VyZSB0aGF0IHdlIGJhdGNoZWQgdGhlIGVudGlyZSBmb2xpbyBhbmQgY2xlYXJlZAo+ Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBhbGwgUFRFcywgd2UgY2FuIGp1c3Qgb3B0aW1pemUgYW5k IHN0b3AgcmlnaHQgaGVyZS4KPj4+ICvCoMKgwqDCoMKgwqDCoMKgICovCj4+PiArwqDCoMKgwqDC oMKgwqAgaWYgKG5yX3BhZ2VzID09IGZvbGlvX25yX3BhZ2VzKGZvbGlvKSkKPj4+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byB3YWxrX2RvbmU7Cj4+PiDCoMKgwqDCoMKgwqDCoMKg wqDCoCBjb250aW51ZTsKPj4+IMKgwqAgd2Fsa19hYm9ydDoKPj4+IC0tIAo+Pgo+PiBPb3BzIC4u LiBUaHJvdWdoIHRlc3Rpbmcgb24gbXkgbWFjaGluZSwgSSBmb3VuZCB0aGF0IHRoZSBsb2dpYyBk b2Vzbid0Cj4+IGJlaGF2ZSBhcyBleHBlY3RlZCBiZWNhdXNlIEkgbWVzc2VkIHVwIHRoZSBtZWFu aW5nIG9mIG1heF9uciAodGhlIAo+PiBhdmFpbGFibGUKPj4gc2NhbiByb29tIGluIHRoZSBwYWdl IHRhYmxlKSB3aXRoIGZvbGlvX25yX3BhZ2VzKGZvbGlvKSA6KAo+Pgo+PiBXaXRoIHRoZSBmb2xs b3dpbmcgY2hhbmdlOgo+Pgo+PiBkaWZmIC0tZ2l0IGEvbW0vcm1hcC5jIGIvbW0vcm1hcC5jCj4+ IGluZGV4IDVlYmZmZTIxMzdlNC4uYjE0MDczNDhlMTRlIDEwMDY0NAo+PiAtLS0gYS9tbS9ybWFw LmMKPj4gKysrIGIvbW0vcm1hcC5jCj4+IEBAIC0xODUwLDkgKzE4NTAsOSBAQCBzdGF0aWMgaW5s aW5lIHVuc2lnbmVkIGludCAKPj4gZm9saW9fdW5tYXBfcHRlX2JhdGNoKHN0cnVjdCBmb2xpbyAq Zm9saW8sCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGVudW0gdHR1X2ZsYWdzIGZsYWdz LCBwdGVfdCBwdGUpCj4+IMKgIHsKPj4gwqDCoMKgwqDCoCBjb25zdCBmcGJfdCBmcGJfZmxhZ3Mg PSBGUEJfSUdOT1JFX0RJUlRZIHwgRlBCX0lHTk9SRV9TT0ZUX0RJUlRZOwo+PiArwqDCoMKgIHVu c2lnbmVkIGludCBtYXhfbnIsIG5yX3BhZ2VzID0gZm9saW9fbnJfcGFnZXMoZm9saW8pOwo+PiDC oMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgZW5kX2FkZHIsIGFkZHIgPSBwdm13LT5hZGRyZXNzOwo+ PiDCoMKgwqDCoMKgIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hID0gcHZtdy0+dm1hOwo+PiAt wqDCoMKgIHVuc2lnbmVkIGludCBtYXhfbnI7Cj4+IMKgwqDCoMKgwqAgaWYgKGZsYWdzICYgVFRV X0hXUE9JU09OKQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDE7Cj4+IEBAIC0xODcwLDEy ICsxODcwLDEzIEBAIHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgaW50IAo+PiBmb2xpb191bm1hcF9w dGVfYmF0Y2goc3RydWN0IGZvbGlvICpmb2xpbywKPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVy biAxOwo+PiDCoMKgwqDCoMKgIC8qIC4uLiB3aGVyZSB3ZSBtdXN0IGJlIGFibGUgdG8gYmF0Y2gg dGhlIHdob2xlIGZvbGlvLiAqLwo+IAo+IFdoeSBpcyB0aGF0IHN0aWxsIHJlcXVpcmVkPyA6KQoK U29ycnkgLi4uIEkgd2FzIHN0aWxsIHN0dWNrIGluIHRoZSAiYWxsLW9yLW5vdGhpbmciIG1pbmRz ZXQgLi4uCgpTbywgSUlVQywgeW91IG1lYW4gd2Ugc2hvdWxkIGNvbXBsZXRlbHkgcmVtb3ZlIHRo ZSAibWF4X25yIDwgbnJfcGFnZXMiCmNoZWNrIGFuZCBqdXN0IGxldCBmb2xpb19wdGVfYmF0Y2gg aGFuZGxlIHdoYXRldmVyIHBhcnRpYWwgYmF0Y2ggaXQKc2FmZWx5IGNhbi4KCj4gCj4+IC3CoMKg wqAgaWYgKHB0ZV9wZm4ocHRlKSAhPSBmb2xpb19wZm4oZm9saW8pIHx8IG1heF9uciAhPSAKPj4g Zm9saW9fbnJfcGFnZXMoZm9saW8pKQo+PiArwqDCoMKgIGlmIChwdGVfcGZuKHB0ZSkgIT0gZm9s aW9fcGZuKGZvbGlvKSB8fCBtYXhfbnIgPCBucl9wYWdlcykKPj4gwqDCoMKgwqDCoMKgwqDCoMKg IHJldHVybiAxOwo+PiAtwqDCoMKgIG1heF9uciA9IGZvbGlvX3B0ZV9iYXRjaChmb2xpbywgYWRk ciwgcHZtdy0+cHRlLCBwdGUsIG1heF9uciwgCj4+IGZwYl9mbGFncywKPj4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIE5VTEwsIE5VTEwsIE5VTEwpOwo+PiAtwqDCoMKgIHJldHVy biAobWF4X25yICE9IGZvbGlvX25yX3BhZ2VzKGZvbGlvKSkgPyAxIDogbWF4X25yOwo+PiArwqDC oMKgIG1heF9uciA9IGZvbGlvX3B0ZV9iYXRjaChmb2xpbywgYWRkciwgcHZtdy0+cHRlLCBwdGUs IG5yX3BhZ2VzLAo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZnBiX2ZsYWdz LCBOVUxMLCBOVUxMLCBOVUxMKTsKPj4gKwo+PiArwqDCoMKgIHJldHVybiAobWF4X25yICE9IG5y X3BhZ2VzKSA/IDEgOiBtYXhfbnI7Cj4gCj4gV2h5IGlzIHRoYXQgc3RpbGwgcmVxdWlyZWQ/IDop CgpUaGVuIHNpbXBseSByZXR1cm4gdGhlIG51bWJlciBvZiBQVEVzIHRoYXQgY29uc2VjdXRpdmVs eSBtYXAgdG8gdGhlCmxhcmdlIGZvbGlvLiBSaWdodD8KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1y aXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtcmlzY3YK