From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 151D6C433F5 for ; Wed, 8 Dec 2021 07:45:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240583AbhLHHsv (ORCPT ); Wed, 8 Dec 2021 02:48:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231739AbhLHHss (ORCPT ); Wed, 8 Dec 2021 02:48:48 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5011EC061574; Tue, 7 Dec 2021 23:45:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 90E21CE2037; Wed, 8 Dec 2021 07:45:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 853CCC341C3; Wed, 8 Dec 2021 07:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638949513; bh=wW9RIet2nCD3niwV3rcV7PvV9BC7tdBsrg1L8F8DdmE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FNkTtqglWMumOqKlVH+Oztoj3XnhZjMI47pI/4mALFUcnU0KHATz622LZK0km7XF8 cdc2z+Zusc2nYQVgWsXskm/5ppYcHMpYRTyheS/WbgJg8vU/k+f9lxvQeLsqHcEmtP qhekOYqMDzrxkW+q4JyGxlKnDQGdsiQVKbR9S66KLUv32rjO1on0aAMe3nN0pfGqbL oeuWS86YzrRKDOxlmbIpURLySBhgu95PWahr185TSCWpwbsKhjXjXR/0Y5CjST/tBj DtAnRBLw6ka5WQOJGDN9gq7M7Y4OmjVQ5s5qkbHLeASoRjEuMWAQq4mYmnB9rNJhFg Jr6pu2PG2SgPQ== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1murdX-00Ai3a-D7; Wed, 08 Dec 2021 07:45:11 +0000 MIME-Version: 1.0 Date: Wed, 08 Dec 2021 07:45:11 +0000 From: Marc Zyngier To: =?UTF-8?Q?qinjian=5B=E8=A6=83=E5=81=A5=5D?= Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, p.zabel@pengutronix.de, linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, =?UTF-8?Q?Wells_Lu_=E5=91=82=E8=8A=B3?= =?UTF-8?Q?=E9=A8=B0?= Subject: Re: [PATCH v5 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver In-Reply-To: <39f9b853af7c44cb94421354744512a8@cqplus1.com> References: <87r1ao23fp.wl-maz@kernel.org> <39f9b853af7c44cb94421354744512a8@cqplus1.com> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: maz@kernel.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: qinjian@cqplus1.com, robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, p.zabel@pengutronix.de, linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, wells.lu@sunplus.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 2021-12-08 07:15, qinjian[覃健] wrote: >> > +void sp_intc_set_ext(u32 hwirq, int ext_num) >> > +{ >> > + sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num); >> > +} >> > +EXPORT_SYMBOL_GPL(sp_intc_set_ext); >> >> No way. We don't export random symbols without a good justification, >> and you didn't give any. >> > > This function called by SP7021 display driver to decide DISPLAY_IRQ > routing to which parent irq (EXT_INT0 or EXT_INT1). Based on what? How can a display driver decide which parent is appropriate? What improvement does this bring? > In previous patches, which defined in DT, parsed & processed @ > sp_intc_xlate_of() > From your comment, this is a SW decision. So I removed it from DT & > intc driver, only > export this function to access the related intc reg. If a decision has to be made, it has to be done in the interrupt controller driver, or rely on the standard API. Exporting random low level functions to other random drivers is not acceptable. M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08489C433F5 for ; Wed, 8 Dec 2021 07:47:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0XGtA7ALMMTCPG0DqRwsWpRzcwnWI9JOFwFuwL4ub3k=; b=dI9FBI8nn7fmghSHZQSVxxO81d dLNOqxUOxiZ59yOz7IXR7HO4RQmmmirIjsaAmJ57XuTMKYKcic/hyrlejfGwL/3O/e4Iz0ZkQV7Cp 6QrvdcsMTNEfXqYn3N2Fzw93J8c70mth0+qrZfL1Xx+DTw9gpaV3Vn1xoGv4PlhUv1Ss3V4C64XDx 2FQpMuOjRGUp24CWj1vuogdo2kNUHZDa6uWf8VzleGHt4vyczmd37Ur/hnkJRMx8eaXFUc5pBpG8q N4Bnth3C9P4CiEAeVFU64Yartz5UQFhVzgwCnKr6LmpLWAPr5OFHVMHdhpDCKAyPj5R7BYgZ1smWN 09U2abcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1murdh-00BazZ-Ax; Wed, 08 Dec 2021 07:45:21 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1murdd-00Bayj-QP for linux-arm-kernel@lists.infradead.org; Wed, 08 Dec 2021 07:45:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5D463CE1FD7; Wed, 8 Dec 2021 07:45:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 853CCC341C3; Wed, 8 Dec 2021 07:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638949513; bh=wW9RIet2nCD3niwV3rcV7PvV9BC7tdBsrg1L8F8DdmE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FNkTtqglWMumOqKlVH+Oztoj3XnhZjMI47pI/4mALFUcnU0KHATz622LZK0km7XF8 cdc2z+Zusc2nYQVgWsXskm/5ppYcHMpYRTyheS/WbgJg8vU/k+f9lxvQeLsqHcEmtP qhekOYqMDzrxkW+q4JyGxlKnDQGdsiQVKbR9S66KLUv32rjO1on0aAMe3nN0pfGqbL oeuWS86YzrRKDOxlmbIpURLySBhgu95PWahr185TSCWpwbsKhjXjXR/0Y5CjST/tBj DtAnRBLw6ka5WQOJGDN9gq7M7Y4OmjVQ5s5qkbHLeASoRjEuMWAQq4mYmnB9rNJhFg Jr6pu2PG2SgPQ== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1murdX-00Ai3a-D7; Wed, 08 Dec 2021 07:45:11 +0000 MIME-Version: 1.0 Date: Wed, 08 Dec 2021 07:45:11 +0000 From: Marc Zyngier To: =?UTF-8?Q?qinjian=5B=E8=A6=83=E5=81=A5=5D?= Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, p.zabel@pengutronix.de, linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, =?UTF-8?Q?Wells_Lu_=E5=91=82=E8=8A=B3?= =?UTF-8?Q?=E9=A8=B0?= Subject: Re: [PATCH v5 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver In-Reply-To: <39f9b853af7c44cb94421354744512a8@cqplus1.com> References: <87r1ao23fp.wl-maz@kernel.org> <39f9b853af7c44cb94421354744512a8@cqplus1.com> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: qinjian@cqplus1.com, robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, p.zabel@pengutronix.de, linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, wells.lu@sunplus.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_234518_075559_89AC9881 X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0xMi0wOCAwNzoxNSwgcWluamlhblvopoPlgaVdIHdyb3RlOgo+PiA+ICt2b2lkIHNw X2ludGNfc2V0X2V4dCh1MzIgaHdpcnEsIGludCBleHRfbnVtKQo+PiA+ICt7Cj4+ID4gKwlzcF9p bnRjX2Fzc2lnbl9iaXQoaHdpcnEsIFJFR19JTlRSX1BSSU9SSVRZLCAhZXh0X251bSk7Cj4+ID4g K30KPj4gPiArRVhQT1JUX1NZTUJPTF9HUEwoc3BfaW50Y19zZXRfZXh0KTsKPj4gCj4+IE5vIHdh eS4gV2UgZG9uJ3QgZXhwb3J0IHJhbmRvbSBzeW1ib2xzIHdpdGhvdXQgYSBnb29kIGp1c3RpZmlj YXRpb24sCj4+IGFuZCB5b3UgZGlkbid0IGdpdmUgYW55Lgo+PiAKPiAKPiBUaGlzIGZ1bmN0aW9u IGNhbGxlZCBieSBTUDcwMjEgZGlzcGxheSBkcml2ZXIgdG8gZGVjaWRlIERJU1BMQVlfSVJRCj4g cm91dGluZyB0byB3aGljaCBwYXJlbnQgaXJxIChFWFRfSU5UMCBvciBFWFRfSU5UMSkuCgpCYXNl ZCBvbiB3aGF0PyBIb3cgY2FuIGEgZGlzcGxheSBkcml2ZXIgZGVjaWRlIHdoaWNoIHBhcmVudCBp cwphcHByb3ByaWF0ZT8gV2hhdCBpbXByb3ZlbWVudCBkb2VzIHRoaXMgYnJpbmc/Cgo+IEluIHBy ZXZpb3VzIHBhdGNoZXMsIHdoaWNoIGRlZmluZWQgaW4gRFQsIHBhcnNlZCAmIHByb2Nlc3NlZCBA Cj4gc3BfaW50Y194bGF0ZV9vZigpCj4gRnJvbSB5b3VyIGNvbW1lbnQsIHRoaXMgaXMgYSBTVyBk ZWNpc2lvbi4gU28gSSByZW1vdmVkIGl0IGZyb20gRFQgJgo+IGludGMgZHJpdmVyLCBvbmx5Cj4g ZXhwb3J0IHRoaXMgZnVuY3Rpb24gdG8gYWNjZXNzIHRoZSByZWxhdGVkIGludGMgcmVnLgoKSWYg YSBkZWNpc2lvbiBoYXMgdG8gYmUgbWFkZSwgaXQgaGFzIHRvIGJlIGRvbmUgaW4gdGhlIGludGVy cnVwdApjb250cm9sbGVyIGRyaXZlciwgb3IgcmVseSBvbiB0aGUgc3RhbmRhcmQgQVBJLiBFeHBv cnRpbmcgcmFuZG9tCmxvdyBsZXZlbCBmdW5jdGlvbnMgdG8gb3RoZXIgcmFuZG9tIGRyaXZlcnMg aXMgbm90IGFjY2VwdGFibGUuCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQg anVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK