From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH-for-9.2? 0/2] tests/functional: Fix tests failing when TCG is not available on macOS
Date: Tue, 3 Dec 2024 07:11:39 +0100 [thread overview]
Message-ID: <ce9fcfd6-b196-4dd3-b42f-e5f3c5beb37d@redhat.com> (raw)
In-Reply-To: <50f8076d-aa90-4b47-884c-ac3937ceec89@linaro.org>
On 02/12/2024 22.01, Philippe Mathieu-Daudé wrote:
> On 2/12/24 21:56, Thomas Huth wrote:
>> On 02/12/2024 21.40, Philippe Mathieu-Daudé wrote:
>>> Explicit the QTest accelerator to have these 2 tests
>>> pass on macOS when only HVF is built in.
>>
>> Could we maybe rather add something like this at the top of tests/
>> functional/meson.build :
>>
>> if 'CONFIG_TCG' not in config_all and 'CONFIG_KVM' not in config_all
>> subdir_done()
>> endif
>
> I'd rather not:
> - these tests don't need anything of TCG/KVM/HVF
> - we can run functional tests using QTest [*]
Ok, but then please switch to "-accel qtest" instead of "-machine
...,accel=qtest" since the latter is legacy and might go away sometime in
the future.
Thanks,
Thomas
next prev parent reply other threads:[~2024-12-03 6:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 20:40 [PATCH-for-9.2? 0/2] tests/functional: Fix tests failing when TCG is not available on macOS Philippe Mathieu-Daudé
2024-12-02 20:40 ` [PATCH-for-9.2? 1/2] tests/functional/test_version: Use QTest accelerator Philippe Mathieu-Daudé
2024-12-02 20:40 ` [PATCH-for-9.2? 2/2] tests/functional/test_empty_cpu_model: " Philippe Mathieu-Daudé
2024-12-02 20:56 ` [PATCH-for-9.2? 0/2] tests/functional: Fix tests failing when TCG is not available on macOS Thomas Huth
2024-12-02 21:01 ` Philippe Mathieu-Daudé
2024-12-03 6:11 ` Thomas Huth [this message]
2024-12-03 8:34 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce9fcfd6-b196-4dd3-b42f-e5f3c5beb37d@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.