From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "haoxiang_li2024@163.com" <haoxiang_li2024@163.com>
Cc: "Ostrovsky, Boris" <boris.ostrovsky@oracle.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"david.vrabel@citrix.com" <david.vrabel@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"tglx@kernel.org" <tglx@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"bp@alien8.de" <bp@alien8.de>,
"oleksandr_tyshchenko@epam.com" <oleksandr_tyshchenko@epam.com>,
"jgross@suse.com" <jgross@suse.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] xen/grant-table: fix resource leak in gnttab_init()
Date: Fri, 20 Nov 2026 22:06:58 +0000 [thread overview]
Message-ID: <ceade382ab685f63b90b5bda405363db01f486e7.camel@intel.com> (raw)
In-Reply-To: <78fc4539.482c.1a1f78783e1.Coremail.haoxiang_li2024@163.com>
On Fri, 2026-11-20 at 13:56 +0800, Haoxiang Li wrote:
>
> At 2026-11-20 07:18:03, "Edgecombe, Rick P" <rick.p.edgecombe@intel.com> wrote:
> >
> > If the PV guest hits this scenario can it survive? I don't know xen pv very
> > well. Does this means that the PV guest has no disk or network. If so, the user
> > is probably not concerned with a one time memory leak.
>
> Thanks for raising this. I tested an x86-64 PV Dom0 under Xen 4.17.7 in QEMU,
> using ata_piix for storage and e1000 for networking.
Ah ok, in dom0. (not xen person here)
>
> I injected -ENOMEM immediately before the initial MFN-array allocation in
> gnttab_map(), after arch_gnttab_init() had succeeded. With and without the
> patch, gnttab_init() returned -ENODEV, but Dom0 still booted to userspace.
> In both cases, disk I/O worked, and the network interface could reach the
> QEMU gateway.
>
> However, I agree that this is a one-time leak with limited impact. I have not
> demonstrated any further user-visible consequences from the leak.
Not that it's impossible, but at boot we could expect allocations to be less
likely to fail.
I guess since you injected the error you didn't hit this in practice? If so, I'd
think this would be a pretty low priority fix. The combo of rare scenario and
close to zero user impact. Fine to be corrected though.
prev parent reply other threads:[~2026-11-20 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 8:43 [PATCH] xen/grant-table: fix resource leak in gnttab_init() Haoxiang Li
2026-11-19 23:18 ` Edgecombe, Rick P
2026-11-20 5:56 ` Haoxiang Li
2026-11-20 22:06 ` Edgecombe, Rick P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceade382ab685f63b90b5bda405363db01f486e7.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david.vrabel@citrix.com \
--cc=haoxiang_li2024@163.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.