From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/pmu: Fix sleep under atomic in RC6 readout Date: Wed, 7 Feb 2018 09:20:27 +0000 Message-ID: References: <20180206161058.nuc2cfilodtqk32a@ideak-desk.fi.intel.com> <20180206183311.17924-1-tvrtko.ursulin@linux.intel.com> <151795146211.17167.9079739737184415375@mail.alporthouse.com> <20180206215447.mo6f772gcqzj6ivt@ideak-desk.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180206215447.mo6f772gcqzj6ivt@ideak-desk.fi.intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: imre.deak@intel.com, "Rafael J. Wysocki" Cc: David Airlie , Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org Ck9uIDA2LzAyLzIwMTggMjE6NTQsIEltcmUgRGVhayB3cm90ZToKPiBIaSBSYWZhZWwsCj4gCj4g T24gVHVlLCBGZWIgMDYsIDIwMTggYXQgMDk6MTE6MDJQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE4LTAyLTA2IDE4OjMzOjExKQo+Pj4g RnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4+Cj4+PiBX ZSBhcmUgbm90IGFsbG93ZWQgdG8gY2FsbCBpbnRlbF9ydW50aW1lX3BtX2dldCBmcm9tIHRoZSBQ TVUgY291bnRlciByZWFkCj4+PiBjYWxsYmFjayBzaW5jZSB0aGUgZm9ybWVyIGNhbiBzbGVlcCwg YW5kIHRoZSBsYXR0ZXIgaXMgcnVubmluZyB1bmRlciBJUlEKPj4+IGNvbnRleHQuCj4+Pgo+Pj4g VG8gd29ya2Fyb3VuZCB0aGlzLCB3ZSByZWNvcmQgdGhlIGxhc3Qga25vd24gUkM2IGFuZCB3aGls ZSBydW50aW1lCj4+PiBzdXNwZW5kZWQgZXN0aW1hdGUgaXRzIGluY3JlYXNlIGJ5IHF1ZXJ5aW5n IHRoZSBydW50aW1lIFBNIGNvcmUKPj4+IHRpbWVzdGFtcHMuCj4+Pgo+Pj4gRG93bnNpZGUgb2Yg dGhpcyBhcHByb2FjaCBpcyB0aGF0IHdlIGNhbiB0ZW1wb3JhcmlseSBsb3NlIGEgY2h1bmsgb2Yg UkM2Cj4+PiB0aW1lLCBmcm9tIHRoZSBsYXN0IFBNVSByZWFkLW91dCB0byBydW50aW1lIHN1c3Bl bmQgZW50cnksIGJ1dCB0aGF0IHdpbGwKPj4+IGV2ZW50dWFsbHkgY2F0Y2ggdXAsIG9uY2UgZGV2 aWNlIGNvbWVzIGJhY2sgb25saW5lIGFuZCBpbiB0aGUgcHJlc2VuY2Ugb2YKPj4+IFBNVSBxdWVy aWVzLgo+Pj4KPj4+IEFsc28sIHdlIGhhdmUgdG8gYmUgY2FyZWZ1bCBub3QgdG8gb3ZlcnNob290 IHRoZSBSQzYgZXN0aW1hdGUsIHNvIG9uY2UKPj4+IHJlc3VtZWQgYWZ0ZXIgYSBwZXJpb2Qgb2Yg YXBwcm94aW1hdGlvbiwgd2Ugb25seSB1cGRhdGUgdGhlIGNvdW50ZXIgb25jZQo+Pj4gaXQgY2F0 Y2hlcyB1cC4gV2l0aCB0aGUgb2JzZXJ2YXRpb24gdGhhdCBSQzYgaXMgaW5jcmVhc2luZyB3aGls ZSB0aGUKPj4+IGRldmljZSBpcyBzdXNwZW5kZWQsIHRoaXMgc2hvdWxkIG5vdCBwb3NlIGEgcHJv YmxlbSBhbmQgY2FuIG9ubHkgY2F1c2UKPj4+IHNsaWdodCBpbmFjY3VyYWNpZXMgZHVlIGNsb2Nr IGJhc2UgZGlmZmVyZW5jZXMuCj4+Pgo+Pj4gdjI6IFNpbXBsaWZ5IGJ5IGVzdGltYXRpbmcgb24g dG9wIG9mIFBNIGNvcmUgY291bnRlcnMuIChJbXJlKQo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFR2 cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+PiBCdWd6aWxsYTogaHR0 cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0OTQzCj4+PiBGaXhl czogNjA2MGI2YWVjMDNjICgiZHJtL2k5MTUvcG11OiBBZGQgUkM2IHJlc2lkZW5jeSBtZXRyaWNz IikKPj4+IFRlc3RjYXNlOiBpZ3QvcGVyZl9wbXUvcmM2LXJ1bnRpbWUtcG0KPj4+IENjOiBUdnJ0 a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pj4gQ2M6IENocmlzIFdpbHNv biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+Pj4gQ2M6IEltcmUgRGVhayA8aW1yZS5kZWFr QGludGVsLmNvbT4KPj4+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50ZWwu Y29tPgo+Pj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVs LmNvbT4KPj4+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4+PiBD YzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+Pj4gQ2M6IGludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPj4+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4+PiAtLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYyB8IDkzICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4+PiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcG11LmggfCAgNiArKysKPj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCA4NCBpbnNl cnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9wbXUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMK Pj4+IGluZGV4IDFjNDQwNDYwMjU1ZC4uYmZjNDAyZDQ3NjA5IDEwMDY0NAo+Pj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9wbXUuYwo+Pj4gQEAgLTQxNSw3ICs0MTUsODEgQEAgc3RhdGljIGludCBpOTE1X3Bt dV9ldmVudF9pbml0KHN0cnVjdCBwZXJmX2V2ZW50ICpldmVudCkKPj4+ICAgICAgICAgIHJldHVy biAwOwo+Pj4gICB9Cj4+PiAgIAo+Pj4gLXN0YXRpYyB1NjQgX19pOTE1X3BtdV9ldmVudF9yZWFk KHN0cnVjdCBwZXJmX2V2ZW50ICpldmVudCkKPj4+ICtzdGF0aWMgdTY0IGdldF9yYzYoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIGJvb2wgbG9ja2VkKQo+Pj4gK3sKPj4+ICsgICAgICAg dW5zaWduZWQgbG9uZyBmbGFnczsKPj4+ICsgICAgICAgdTY0IHZhbDsKPj4+ICsKPj4+ICsgICAg ICAgaWYgKGludGVsX3J1bnRpbWVfcG1fZ2V0X2lmX2luX3VzZShpOTE1KSkgewo+Pj4gKyAgICAg ICAgICAgICAgIHZhbCA9IGludGVsX3JjNl9yZXNpZGVuY3lfbnMoaTkxNSwgSVNfVkFMTEVZVklF VyhpOTE1KSA/Cj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBWTFZfR1RfUkVOREVSX1JDNiA6Cj4+PiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBHRU42X0dUX0dGWF9SQzYpOwo+Pj4gKwo+Pj4gKyAg ICAgICAgICAgICAgIGlmIChIQVNfUkM2cChpOTE1KSkKPj4+ICsgICAgICAgICAgICAgICAgICAg ICAgIHZhbCArPSBpbnRlbF9yYzZfcmVzaWRlbmN5X25zKGk5MTUsIEdFTjZfR1RfR0ZYX1JDNnAp Owo+Pj4gKwo+Pj4gKyAgICAgICAgICAgICAgIGlmIChIQVNfUkM2cHAoaTkxNSkpCj4+PiArICAg ICAgICAgICAgICAgICAgICAgICB2YWwgKz0gaW50ZWxfcmM2X3Jlc2lkZW5jeV9ucyhpOTE1LCBH RU42X0dUX0dGWF9SQzZwcCk7Cj4+PiArCj4+PiArICAgICAgICAgICAgICAgaW50ZWxfcnVudGlt ZV9wbV9wdXQoaTkxNSk7Cj4+PiArCj4+PiArICAgICAgICAgICAgICAgLyoKPj4+ICsgICAgICAg ICAgICAgICAgKiBJZiB3ZSBhcmUgY29taW5nIGJhY2sgZnJvbSBiZWluZyBydW50aW1lIHN1c3Bl bmRlZCB3ZSBtdXN0Cj4+PiArICAgICAgICAgICAgICAgICogYmUgY2FyZWZ1bCBub3QgdG8gcmVw b3J0IGEgbGFyZ2VyIHZhbHVlIHRoYW4gcmV0dXJuZWQKPj4+ICsgICAgICAgICAgICAgICAgKiBw cmV2aW91c2x5Lgo+Pj4gKyAgICAgICAgICAgICAgICAqLwo+Pj4gKwo+Pj4gKyAgICAgICAgICAg ICAgIGlmICghbG9ja2VkKQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3Bpbl9sb2NrX2ly cXNhdmUoJmk5MTUtPnBtdS5sb2NrLCBmbGFncyk7Cj4+PiArCj4+PiArICAgICAgICAgICAgICAg aWYgKHZhbCA+PSBpOTE1LT5wbXUuc2FtcGxlW19fSTkxNV9TQU1QTEVfUkM2X0VTVElNQVRFRF0u Y3VyKSB7Cj4+PiArICAgICAgICAgICAgICAgICAgICAgICBpOTE1LT5wbXUuc2FtcGxlW19fSTkx NV9TQU1QTEVfUkM2X0VTVElNQVRFRF0uY3VyID0gMDsKPj4+ICsgICAgICAgICAgICAgICAgICAg ICAgIGk5MTUtPnBtdS5zYW1wbGVbX19JOTE1X1NBTVBMRV9SQzZdLmN1ciA9IHZhbDsKPj4+ICsg ICAgICAgICAgICAgICB9IGVsc2Ugewo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgdmFsID0g aTkxNS0+cG11LnNhbXBsZVtfX0k5MTVfU0FNUExFX1JDNl9FU1RJTUFURURdLmN1cjsKPj4+ICsg ICAgICAgICAgICAgICB9Cj4+PiArCj4+PiArICAgICAgICAgICAgICAgaWYgKCFsb2NrZWQpCj4+ PiArICAgICAgICAgICAgICAgICAgICAgICBzcGluX3VubG9ja19pcnFyZXN0b3JlKCZpOTE1LT5w bXUubG9jaywgZmxhZ3MpOwo+Pj4gKyAgICAgICB9IGVsc2Ugewo+Pj4gKyAgICAgICAgICAgICAg IHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gaTkxNS0+ZHJtLnBkZXY7Cj4+PiArICAgICAgICAgICAg ICAgc3RydWN0IGRldmljZSAqa2RldiA9ICZwZGV2LT5kZXY7Cj4+PiArICAgICAgICAgICAgICAg dW5zaWduZWQgbG9uZyBmbGFnczI7Cj4+PiArCj4+PiArICAgICAgICAgICAgICAgLyoKPj4+ICsg ICAgICAgICAgICAgICAgKiBXZSBhcmUgcnVudGltZSBzdXNwZW5kZWQuCj4+PiArICAgICAgICAg ICAgICAgICoKPj4+ICsgICAgICAgICAgICAgICAgKiBSZXBvcnQgdGhlIGRlbHRhIGZyb20gd2hl biB0aGUgZGV2aWNlIHdhcyBzdXNwZW5kZWQgdG8gbm93LAo+Pj4gKyAgICAgICAgICAgICAgICAq IG9uIHRvcCBvZiB0aGUgbGFzdCBrbm93biByZWFsIHZhbHVlLCBhcyB0aGUgYXBwcm94aW1hdGVk IFJDNgo+Pj4gKyAgICAgICAgICAgICAgICAqIGNvdW50ZXIgdmFsdWUuCj4+PiArICAgICAgICAg ICAgICAgICovCj4+PiArICAgICAgICAgICAgICAgaWYgKCFsb2NrZWQpCj4+PiArICAgICAgICAg ICAgICAgICAgICAgICBzcGluX2xvY2tfaXJxc2F2ZSgmaTkxNS0+cG11LmxvY2ssIGZsYWdzKTsK Pj4+ICsKPj4+ICsgICAgICAgICAgICAgICBzcGluX2xvY2tfaXJxc2F2ZSgma2Rldi0+cG93ZXIu bG9jaywgZmxhZ3MyKTsKPj4+ICsKPj4+ICsgICAgICAgICAgICAgICBpZiAoIWk5MTUtPnBtdS5z YW1wbGVbX19JOTE1X1NBTVBMRV9SQzZfRVNUSU1BVEVEXS5jdXIpCj4+PiArICAgICAgICAgICAg ICAgICAgICAgICBpOTE1LT5wbXUuc3VzcGVuZGVkX2ppZmZpZXNfbGFzdCA9Cj4+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBrZGV2LT5wb3dlci5zdXNw ZW5kZWRfamlmZmllczsKPj4+ICsKPj4+ICsgICAgICAgICAgICAgICB2YWwgPSBrZGV2LT5wb3dl ci5zdXNwZW5kZWRfamlmZmllcyAtCj4+PiArICAgICAgICAgICAgICAgICAgICAgaTkxNS0+cG11 LnN1c3BlbmRlZF9qaWZmaWVzX2xhc3Q7Cj4+PiArICAgICAgICAgICAgICAgdmFsICs9IGppZmZp ZXMgLSBrZGV2LT5wb3dlci5hY2NvdW50aW5nX3RpbWVzdGFtcDsKPj4+ICsKPj4+ICsgICAgICAg ICAgICAgICBzcGluX3VubG9ja19pcnFyZXN0b3JlKCZrZGV2LT5wb3dlci5sb2NrLCBmbGFnczIp Owo+Pj4gKwo+Pj4gKyAgICAgICAgICAgICAgIHZhbCA9IGppZmZpZXNfdG9fbnNlY3ModmFsKTsK Pj4+ICsgICAgICAgICAgICAgICB2YWwgKz0gaTkxNS0+cG11LnNhbXBsZVtfX0k5MTVfU0FNUExF X1JDNl0uY3VyOwo+Pj4gKyAgICAgICAgICAgICAgIGk5MTUtPnBtdS5zYW1wbGVbX19JOTE1X1NB TVBMRV9SQzZfRVNUSU1BVEVEXS5jdXIgPSB2YWw7Cj4+PiArCj4+PiArICAgICAgICAgICAgICAg aWYgKCFsb2NrZWQpCj4+PiArICAgICAgICAgICAgICAgICAgICAgICBzcGluX3VubG9ja19pcnFy ZXN0b3JlKCZpOTE1LT5wbXUubG9jaywgZmxhZ3MpOwo+Pj4gKyAgICAgICB9Cj4+PiArCj4+PiAr ICAgICAgIHJldHVybiB2YWw7Cj4+PiArfQo+Pgo+PiBJIGZlZWwgc2xpZ2h0bHkgZGlydHksIGJ1 dCB0aGUgZGFuY2UgY2hlY2tzIG91dC4KPiAKPiBXb3VsZCBpdCBiZSBwb3NzaWJsZSB0byBhZGQg YW4gUlBNIGhlbHBlciB0aGF0IHByb3ZpZGVzIHRoZSBkZXZpY2Uncwo+IHJ1bnRpbWUgc3VzcGVu ZCByZXNpZGVuY3kgZm9yIHRoZSBhYm92ZSBwdXJwb3NlPyBUaGlzIHdvdWxkIGJlCj4gZXNzZW50 aWFsbHkgd2hhdCBydHBtX3N1c3BlbmRlZF90aW1lX3Nob3coKSBwcm92aWRlcy4KClRoYXQgd291 bGQgaW5kZWVkIGJlIG11Y2ggYmV0dGVyIHNpbmNlIGZpc2hpbmcgaW50byBpbnRlcm5hbHMgbGlr ZSB0aGUgCmFib3ZlIGlzIG5vdCB2ZXJ5IG5pY2UuCgpIb3dldmVyLCBpdCB3b3VsZCBhbHNvIGJl IGdvb2Qgbm90IHRvIGRlbGF5IHRoaXMgZml4IGZvciB0b28gbG9uZyBieSAKYWRkaXRpb25hbCBs b2dpc3RpY3MsIGFuZCBrZWVwIGl0IHNlbGYtY29udGFpbmVkIC0gZWFzeSB0byBiYWNrcG9ydC4K ClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==