All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org,
	 Christian Brauner <brauner@kernel.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>,
	Jori Koolstra <jkoolstra@xs4all.nl>,
	 Sasha Levin <sashal@kernel.org>,
	tech-board@groups.linuxfoundation.org,
	Jakub Kicinski <kuba@kernel.org>,
		workflows@vger.kernel.org
Subject: Re: [PATCH] coding-assistants: simplify attribution
Date: Tue, 04 Aug 2026 11:28:38 -0400	[thread overview]
Message-ID: <ced405b4c1f2459df4885dc8ed1cd122f7c88fb8.camel@kernel.org> (raw)
In-Reply-To: <87qzkuahlr.fsf@trenco.lwn.net>

On Wed, 2026-07-22 at 14:34 -0600, Jonathan Corbet wrote:
> As suggested by Christian, I have applied his patch to a branch and
> simplified the changelog, see below.
> 
> I'm nervous about applying it still because I don't think it's my role
> to set this sort of policy; I really want to feel that there is a
> consensus behind it.  So there's some additional CCs here because I
> would like to hear from some folks:
> 
> - This policy document originally came out of the TAB; is the TAB (on
>   CC) OK with this change?
> 
> - At least one maintainer (on CC) have said that they currently strip
>   Assisted-by tags out of patches before applying them, a practice that
>   would seem to undermine the whole policy.  Would this change be
>   sufficient to end that practice?
> 
> Thanks,
> 
> jon
> 
> From c31aa376a355e3b84b9e87ae1dbe19b394d4c82c Mon Sep 17 00:00:00 2001
> From: Christian Brauner <brauner@kernel.org>
> Date: Wed, 1 Jul 2026 17:54:48 +0200
> Subject: [PATCH] coding-assistants: simplify attribution
> 
> The requirement to identify specific models used in the Assisted-by tag
> provides free advertising to proprietary software companies while adding
> little or no useful information.  Change the requirement to simply:
> 
>   Assisted-by: LLM
> 
> to capture the fact that an LLM was used without tracking which one.
> 
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
> Reviewed-by: Jori Koolstra <jkoolstra@xs4all.nl>
> Message-ID: <20260701-work-coding-assistants-v1-1-a20a94d1d606@kernel.org>
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> ---
>  Documentation/process/coding-assistants.rst | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/process/coding-assistants.rst b/Documentation/process/coding-assistants.rst
> index 899f4459c52d..fe34f3e7e828 100644
> --- a/Documentation/process/coding-assistants.rst
> +++ b/Documentation/process/coding-assistants.rst
> @@ -43,12 +43,8 @@ When AI tools contribute to kernel development, proper attribution
>  helps track the evolving role of AI in the development process.
>  Contributions should include an Assisted-by tag in the following format::
>  
> -  Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
> +  Assisted-by: LLM [TOOL1] [TOOL2]
>  
> -Where:
> -
> -* ``AGENT_NAME`` is the name of the AI tool or framework
> -* ``MODEL_VERSION`` is the specific model version used
>  * ``[TOOL1] [TOOL2]`` are optional specialized analysis tools used
>    (e.g., coccinelle, sparse, smatch, clang-tidy)
>  
> @@ -56,4 +52,4 @@ Basic development tools (git, gcc, make, editors) should not be listed.
>  
>  Example::
>  
> -  Assisted-by: Claude:claude-3-opus coccinelle sparse
> +  Assisted-by: LLM coccinelle sparse

One thing that needs to be changed in conjunction with this is
checkpatch.pl. When I try to use the new format, I get:

● a9b9b7e55379: btrfs: pre-allocate delayed dir index for non-overwrite rename
  ● checkpatch.pl: :2036: WARNING: Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format

This patch fixes it for me, but I'm not sure it's restrictive enough.
Jon, feel free to fold this into the Documentation patch, or I can send
it separately if this seems right.

-----------------------8<-------------------------

[PATCH] checkpatch.pl: adapt to new Assisted-by: format

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 scripts/checkpatch.pl | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2b7a42bbdd94..7961d9584bc5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3124,11 +3124,12 @@ sub process {
 				}
 			}
 
-			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
+			# Assisted-by uses a free-form value (e.g. "LLM"), not an
+			# email address, so skip the email format checks below.
 			if ($sign_off =~ /^Assisted-by:/i) {
-				if ($email !~ /^\S+:\S+/) {
+				if ($email =~ /^\s*$/) {
 					WARN("BAD_SIGN_OFF",
-					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
+					     "Assisted-by requires a value\n" . $herecurr);
 				}
 				next;
 			}
-- 
2.55.0



  parent reply	other threads:[~2026-08-04 15:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 20:34 [PATCH] coding-assistants: simplify attribution Jonathan Corbet
2026-07-22 20:48 ` Konstantin Ryabitsev
2026-07-24 18:17   ` Mauro Carvalho Chehab
2026-08-04  8:10   ` Lorenzo Stoakes (ARM)
2026-08-04  9:23     ` David Hildenbrand (Arm)
2026-08-04 11:09     ` Jori Koolstra
2026-08-04 11:49       ` Lorenzo Stoakes (ARM)
2026-07-24 19:15 ` [tech-board] " David Hildenbrand (Arm)
2026-08-03 18:56 ` Jonathan Corbet
2026-08-03 19:50   ` [tech-board] " Miguel Ojeda
2026-08-04 15:28 ` Jeff Layton [this message]
2026-08-04 15:35   ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ced405b4c1f2459df4885dc8ed1cd122f7c88fb8.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=brauner@kernel.org \
    --cc=corbet@lwn.net \
    --cc=jkoolstra@xs4all.nl \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=sashal@kernel.org \
    --cc=tech-board@groups.linuxfoundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.