Re: [bitbake-devel][PATCH] fetch2: give every FetchData a default unpack_tracer

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2026-07-03 at 16:36 +0530, Siva Balasubramanian via lists.openembedded.org wrote:
> Fetch() sets an unpack_tracer attribute on the FetchData objects it
> manages, but the per-mirror FetchData objects created in
> build_mirroruris() are constructed directly and never get one. When a
> mirror is used for a git recipe that needs Git LFS, git.py's download()
> performs a checkout (via Git.unpack()) on the mirror's FetchData to
> materialise the LFS objects, and that unpack path dereferences
> ud.unpack_tracer, failing with:
> 
>     AttributeError: 'FetchData' object has no attribute 'unpack_tracer'
> 
> so PREMIRRORS/MIRRORS fetching is broken for git-lfs sources.
> 
> Fix this at the source by initialising unpack_tracer to a
> DummyUnpackTracer in FetchData.__init__(), so the attribute always
> exists. Fetch() still overrides it with the real (possibly
> user-configured via BB_UNPACK_TRACER_CLASS) tracer for the URLs it
> manages; the mirror FetchData objects only perform an internal,
> throwaway checkout that should not be traced anyway.
> 
> Add a MirrorUriTest regression test asserting the mirror FetchData
> objects carry an unpack_tracer.
> 
> Reported-by: Oliver Feilner <oliver.feilner@yaskawa.eu>
> 
> [YOCTO #15948]
> 
> Signed-off-by: Siva Balasubramanian <sivakumar.bs@gmail.com>

Wasn't this already fixed by:

https://git.openembedded.org/bitbake/commit/?id=f0c9cf8d3885c5b1c2ba448f064421dae476fcd0

?

We don't want to add a dummy one everywhere, only add one when needed
as the patch avove does...

Cheers,

Richard