From: Ping-Ke Shih <pkshih@realtek.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>,
Stefan Lippers-Hollmann <s.l-h@gmx.de>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
Christian Hewitt <chewitt@libreelec.tv>
Subject: RE: [PATCH v7 12/12] wifi: rtlwifi: Enable the new rtl8192du driver
Date: Tue, 28 May 2024 08:41:52 +0000 [thread overview]
Message-ID: <cedd13d7691f4692b2a2fa5a24d44a22@realtek.com> (raw)
In-Reply-To: <edb8cf11187349003b2d61c8cc71e4bed28c31f2.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> wrote:
> On Tue, 2024-05-28 at 02:39 +0000, Ping-Ke Shih wrote:
> > One thing is that should we honor the values set by user space?
> >
> > If user space has not set, driver wants to control this value by itself
> > according to AP/IBSS/station modes.
> > If user space has set, driver fully follows the value from user space.
> > Is above the behavior you want?
>
> Honestly, is it? I think most drivers these days probably ignore the
> values from userspace for lesser reasons (e.g. iwlwifi always has a
> firmware-internal limit of 16 IIRC.)
>
> This API also comes from the dawn of wireless in Linux, and was just
> ported from wireless extensions to nl80211. So I wouldn't feel too bad
> about simply ignoring it either.
Agree. My thought was limited to have the same behavior as rtlwifi was.
Ignoring handle of IEEE80211_CONF_CHANGE_RETRY_LIMITS would be simpler.
Ping-Ke
next prev parent reply other threads:[~2024-05-28 8:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 14:42 [PATCH v7 00/12] wifi: rtlwifi: Add new rtl8192du driver Bitterblue Smith
2024-05-23 14:43 ` [PATCH v7 01/12] wifi: rtlwifi: rtl8192d: Use "rtl92d" prefix Bitterblue Smith
2024-05-30 2:50 ` Ping-Ke Shih
2024-05-23 14:44 ` [PATCH v7 02/12] wifi: rtlwifi: Add rtl8192du/table.{c,h} Bitterblue Smith
2024-05-23 14:44 ` [PATCH v7 03/12] wifi: rtlwifi: Add new members to struct rtl_priv for RTL8192DU Bitterblue Smith
2024-05-23 14:45 ` [PATCH v7 04/12] wifi: rtlwifi: Add rtl8192du/hw.{c,h} Bitterblue Smith
2024-05-23 14:46 ` [PATCH v7 05/12] wifi: rtlwifi: Add rtl8192du/phy.{c,h} Bitterblue Smith
2024-05-23 14:46 ` [PATCH v7 06/12] wifi: rtlwifi: Add rtl8192du/trx.{c,h} Bitterblue Smith
2024-05-23 14:46 ` [PATCH v7 07/12] wifi: rtlwifi: Add rtl8192du/rf.{c,h} Bitterblue Smith
2024-05-23 14:47 ` [PATCH v7 08/12] wifi: rtlwifi: Add rtl8192du/fw.{c,h} and rtl8192du/led.{c,h} Bitterblue Smith
2024-05-23 14:47 ` [PATCH v7 09/12] wifi: rtlwifi: Add rtl8192du/dm.{c,h} Bitterblue Smith
2024-05-23 14:48 ` [PATCH v7 10/12] wifi: rtlwifi: Constify rtl_hal_cfg.{ops,usb_interface_cfg} and rtl_priv.cfg Bitterblue Smith
2024-05-23 14:48 ` [PATCH v7 11/12] wifi: rtlwifi: Add rtl8192du/sw.c Bitterblue Smith
2024-05-23 14:49 ` [PATCH v7 12/12] wifi: rtlwifi: Enable the new rtl8192du driver Bitterblue Smith
2024-05-27 7:47 ` Ping-Ke Shih
2024-05-27 9:25 ` Stefan Lippers-Hollmann
2024-05-27 23:06 ` Bitterblue Smith
2024-05-28 2:39 ` Ping-Ke Shih
2024-05-28 6:59 ` Johannes Berg
2024-05-28 8:41 ` Ping-Ke Shih [this message]
2024-05-28 2:02 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cedd13d7691f4692b2a2fa5a24d44a22@realtek.com \
--to=pkshih@realtek.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chewitt@libreelec.tv \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=s.l-h@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.