All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pavel A. Nekrasov" <pnekras@gmail.com>
To: netfilter-devel@lists.netfilter.org, johnpol@2ka.mipt.ru,
	laforge@netfilter.org, kaber@trash.net
Subject: Re: [1/3] OSF: code beautification.
Date: Wed, 1 Jun 2005 00:37:05 +0200	[thread overview]
Message-ID: <cede307105053115377afb8aac@mail.gmail.com> (raw)

hello!

>@@ -186,12 +181,10 @@
> 	df = ((ntohs(ip->frag_off) & IP_DF)?1:0);
> 	window = ntohs(tcp->window);
> 	
>-	if (tcp->doff*4 > sizeof(struct tcphdr))
>-	{
>+	if (tcp->doff*4 > sizeof(struct tcphdr)) {
> 		optsize = tcp->doff*4 - sizeof(struct tcphdr);

This won't work with fragments, you consider here that the tcp header
is linear and that isn't always true.

BTW, fix a deadlock. match() can be called from both bh and process context.

kind regards,
Pavel

             reply	other threads:[~2005-05-31 22:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-31 22:37 Pavel A. Nekrasov [this message]
2005-05-31 22:57 ` [1/3] OSF: code beautification Evgeniy Polyakov
2005-05-31 23:04   ` Evgeniy Polyakov
2005-06-01  0:03     ` Pavel A. Nekrasov
2005-06-01  0:11       ` Evgeniy Polyakov
2005-06-01  0:11         ` Pavel A. Nekrasov
2005-05-31 23:55 ` [0/3] OSF: resurect skb fragmentation patch Evgeniy Polyakov
  -- strict thread matches above, loose matches on Subject: below --
2005-05-29 20:20 [1/3] OSF: code beautification Evgeniy Polyakov
2005-06-11 16:30 ` Patrick McHardy
2005-06-11 16:44   ` Evgeniy Polyakov
2005-06-11 16:56     ` Patrick McHardy
2005-06-11 17:54       ` Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cede307105053115377afb8aac@mail.gmail.com \
    --to=pnekras@gmail.com \
    --cc=johnpol@2ka.mipt.ru \
    --cc=kaber@trash.net \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.