From: Allison Henderson <achender@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>,
Aibing Chen <chenaibing@cmss.chinamobile.com>
Cc: leon@kernel.org, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
hdanton@sina.com, hackerowskiy@gmail.com,
syzbot+ccdb5058c3df2d94811c@syzkaller.appspotmail.com
Subject: Re: [PATCH] RDMA/cma: add rdma_destroy_id_wq() and use it from RDS
Date: Sun, 15 Nov 2026 23:47:45 -0700 [thread overview]
Message-ID: <cee2fea9e09d50d33a9786260edbb295179fc1e9.camel@kernel.org> (raw)
In-Reply-To: <20261115001851.GH2532299@ziepe.ca>
On Sat, 2026-11-14 at 20:18 -0400, Jason Gunthorpe wrote:
> On Sat, Nov 14, 2026 at 11:05:41PM +0800, Aibing Chen wrote:
> > syzbot reported a possible circular locking dependency between
> > rds_trans_sem and the RDMA CM handler mutex:
> >
> > CPU0 (bind path) CPU1 (CM callback path)
> > ---- ----
> > down_read(&rds_trans_sem) mutex_lock(&handler_mutex)
> > rds_ib_laddr_check() cma_ib_req_handler()
> > rdma_destroy_id() rds_ib_cm_handle_connect()
> > mutex_lock(&handler_mutex) rds_conn_create()
> > rds_trans_get_preferred()
> > down_read(&rds_trans_sem)
> >
> > rds_ib_laddr_check_cm() destroys the CM id from inside
> > rds_trans_get_preferred()'s read-side critical section, while CM
> > callbacks create RDS connections (taking the same read lock) from
> > under handler_mutex.
> >
> > Break the cycle by destroying the CM id asynchronously: add
> > rdma_destroy_id_wq(), which queues the destruction on cma_wq, and
> > switch rds_ib_laddr_check_cm() to it. The destroy work is embedded
> > in struct rdma_id_private, which keeps the id alive until the work
> > runs; rds does not touch cm_id after the destroy call.
>
> This doesn't seem like it should be the core codes problem? Why can't
> rds do the workqueue?
>
> Jason
Hi Aibing,
Aibing, thanks for chasing this down. I think Jason is right, this
should probably be in the rds side. This solution doesnt quite cover
all the locking issues though. rds_conn_create calls
rds_trans_get_preferred() which falls through to rds_ib_laddr_check_cm()
when not local. And then we get a rdma_destroy_id while the listen id's
handler_mutex is still held.
I think a better way to do this might be to create a new work item and
then deffer the rdma_destroy_id to be completed later by a worker. The
work item would just hold the cm_id queued on rds_wq, and then the handler
just calls rdma_destroy_id() and frees itself. alloc the new work item at
the top of rds_ib_laddr_check_cm and then queue the new work item in place of
the rdma_destroy_id. You'll also need to add another flush_workqueue(rds_wq)
after rds_trans_unregister() in rds_ib_exit().
Other nits: this patch should have a fixes tag, and target the net tree
like this: "[PATCH net v2] net/rds ...". And I think the fixes tag is:
ec16227e1414 ("RDS/IB: Infiniband transport"). Drop the tested-by until it
is tested by syzbot and/or Eduard, and be sure to update your change log
below the dashed line.
Thanks for working on this!
Allion
next prev parent reply other threads:[~2026-11-16 6:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 15:05 [PATCH] RDMA/cma: add rdma_destroy_id_wq() and use it from RDS Aibing Chen
2026-11-15 0:18 ` Jason Gunthorpe
2026-11-16 6:47 ` Allison Henderson [this message]
2026-11-15 15:05 ` sashiko-bot
2026-11-16 7:54 ` [PATCH net v2] net/rds: defer CM id destruction to a workqueue Aibing Chen
2026-11-17 6:15 ` Allison Henderson
2026-11-17 7:54 ` sashiko-bot
2026-11-17 8:21 ` [PATCH net v3] " Aibing Chen
2026-11-17 8:33 ` sashiko-bot
2026-11-17 8:35 ` [PATCH net v2] " netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cee2fea9e09d50d33a9786260edbb295179fc1e9.camel@kernel.org \
--to=achender@kernel.org \
--cc=chenaibing@cmss.chinamobile.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hackerowskiy@gmail.com \
--cc=hdanton@sina.com \
--cc=horms@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=syzbot+ccdb5058c3df2d94811c@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.