All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
	dan.j.williams@intel.com, vkoul@kernel.org
Cc: ldewangan@nvidia.com, dmaengine@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [2/6] dma: tegra: make byte counters unsigned int
Date: Tue, 6 Nov 2018 16:11:40 +0300	[thread overview]
Message-ID: <ceef9771-e423-2533-f00a-0c1cdabc0fe7@gmail.com> (raw)

On 31.10.2018 19:03, Ben Dooks wrote:
> The buffer byte request length and counter are declared as signed integers
> but the values should never be below zero, so make these unsigned integers
> instead.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>  drivers/dma/tegra20-apb-dma.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index 8219ab88a507..adfd918baedc 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -155,7 +155,7 @@ struct tegra_dma_channel_regs {
>   */
>  struct tegra_dma_sg_req {
>  	struct tegra_dma_channel_regs	ch_regs;
> -	int				req_len;
> +	unsigned int			req_len;
>  	bool				configured;
>  	bool				last_sg;
>  	struct list_head		node;
> @@ -169,8 +169,8 @@ struct tegra_dma_sg_req {
>   */
>  struct tegra_dma_desc {
>  	struct dma_async_tx_descriptor	txd;
> -	int				bytes_requested;
> -	int				bytes_transferred;
> +	unsigned int			bytes_requested;
> +	unsigned int			bytes_transferred;
>  	enum dma_status			dma_status;
>  	struct list_head		node;
>  	struct list_head		tx_list;
> 
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>

             reply	other threads:[~2018-11-06 13:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 13:11 Dmitry Osipenko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-31 16:03 [2/6] dma: tegra: make byte counters unsigned int Ben Dooks
2018-10-12  9:44 Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ceef9771-e423-2533-f00a-0c1cdabc0fe7@gmail.com \
    --to=digetx@gmail.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=linux-tegra@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.