From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: Hiago De Franco <hfranco@baylibre.com>, xen-devel@lists.xenproject.org
Cc: "Alistair Francis" <alistair.francis@wdc.com>,
"Baptiste Le Duc" <baptiste.le-duc@vates.tech>,
"Connor Davis" <connojdavis@gmail.com>,
"Ronaldo Nunez" <rnunez@baylibre.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger@xenproject.org>,
"Stefano Stabellini" <sstabellini@kernel.org>
Subject: Re: [PATCH] xen/riscv: vsbi: add SBI TIME extension
Date: Fri, 20 Nov 2026 09:42:01 +0100 [thread overview]
Message-ID: <cefacdef-a9fc-4e8a-ae5b-6fab925109bc@gmail.com> (raw)
In-Reply-To: <bkmmgcqrbq47i7gxn3nt64xrypt2l2hrhlbip7rv7cfo7p6dqs@lssohgkujou5>
On 11/19/26 10:34 PM, Hiago De Franco wrote:
> On Thu, Nov 19, 2026 at 02:52:46PM +0100, Oleksii Kurochko wrote:
>>
>>
>> On 11/19/26 12:59 PM, Hiago De Franco wrote:
[...]
>>
>>>
>>> Tested by booting dom0less Linux guest, which prints "SBI TIME
>>> extension detected". To test this, I used the fork from Oleksii [1]
>>> (branch riscv-next-upstreaming) to boot linux guest with dom0less.
>>>
>>> Since this is an isolated patch and applies to the xen master branch, I
>>
>> Please note, though, that development happens on the staging branch; master
>> lags behind it, so patches should be based on staging. This one applies to
>> staging as is.
>
> Noted, I was basing it on master. I will fix that.
>
>>
>>> decided to send the patch. Please let me know if this is not correct.
>>
>> Generally speaking, I can't say whether this is right or wrong. IMO, we
>> should have a policy that we all agree on. If I'm not mistaken, Bruno
>> invited you to our weekly Xen RISC-V meetings, and we have one today. It
>> would be great if you could join us so we could discuss these things.
>>
>> At this point, the patch does look independent and ready to go. However,
>> another option would be to take the patch to the riscv-next-upstreaming
>> branch, apply it there, and verify that it works. That said, this might not
>> be the best general approach.
>>
>> The patch is currently targeting upstream/staging, which cannot boot any
>> guests. Strictly speaking, it is therefore difficult to verify how the patch
>> works without fetching [1], switching to the mentioned branch, and applying
>> the patch there. In this sense, the fact that staging cannot currently boot
>> a guest creates a kind of "logical dependency".
>>
>> So, technically, we could proceed with this patch as it is. However, if you
>> could join today's meeting, it would be good to discuss how we should handle
>> similar situations with future patches and agree on a general upstreaming
>> policy.
>
> Got it, since we had the call today I will prefer to proceed as the
> following:
>
> I will open a MR on https://gitlab.com/xen-project/people/olkur/xen
> staging branch, we do the testing and reviews there and once we have
> more work done upstream, I will resbumit or submit a v2. That way we add
> code upstream that is really capable of being tested.
Just a small remark.
We don't push changes directly to staging, as it is a protected branch.
Of course, force-pushing is technically possible, but that would put us
out of sync with upstream Xen's staging branch, meaning we'd probably
have to force-push all the time, which could lead to other issues as
well. What isn't good.
Usually, changes are brought to downstream staging only after they have
been merged into upstream staging. So, basically, we just need to run
git pull upstream staging.
Therefore, if you want to proceed with an MR, it would be better to
target riscv-next-upstream.
Feel free to suggest a better approach if you have one in mind. I'm
pretty open to suggestions.
Thanks.
~ Oleksii
next prev parent reply other threads:[~2026-11-20 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 11:59 [PATCH] xen/riscv: vsbi: add SBI TIME extension Hiago De Franco
2026-11-19 13:52 ` Oleksii Kurochko
[not found] ` <bkmmgcqrbq47i7gxn3nt64xrypt2l2hrhlbip7rv7cfo7p6dqs@lssohgkujou5>
2026-11-20 8:42 ` Oleksii Kurochko [this message]
2026-11-19 16:32 ` Baptiste Le Duc
2026-11-19 21:38 ` Hiago De Franco
2026-11-20 8:31 ` Oleksii Kurochko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cefacdef-a9fc-4e8a-ae5b-6fab925109bc@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=baptiste.le-duc@vates.tech \
--cc=connojdavis@gmail.com \
--cc=hfranco@baylibre.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=rnunez@baylibre.com \
--cc=roger@xenproject.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.