From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 13 Mar 2019 19:23:15 +0100 Subject: [U-Boot] [PATCH] test/py: Fix pytest4 deprecation warnings In-Reply-To: <20190313160127.GF8732@bill-the-cat> References: <20190313040814.17030-1-marek.vasut+renesas@gmail.com> <20190313111919.GA8732@bill-the-cat> <339bad93-6e99-a427-ebfc-0ac400235277@gmail.com> <20190313112501.GB8732@bill-the-cat> <904b8981-a18c-db82-e8bc-e75ea898f2e9@gmail.com> <20190313112942.GC8732@bill-the-cat> <806904e3-0d0d-3c02-a2d7-8db1310825b4@gmail.com> <20190313160127.GF8732@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 3/13/19 5:01 PM, Tom Rini wrote: > On Wed, Mar 13, 2019 at 12:30:59PM +0100, Marek Vasut wrote: >> On 3/13/19 12:29 PM, Tom Rini wrote: >>> On Wed, Mar 13, 2019 at 12:27:38PM +0100, Marek Vasut wrote: >>>> On 3/13/19 12:25 PM, Tom Rini wrote: >>>>> On Wed, Mar 13, 2019 at 12:20:49PM +0100, Marek Vasut wrote: >>>>>> On 3/13/19 12:19 PM, Tom Rini wrote: >>>>>>> On Wed, Mar 13, 2019 at 05:08:14AM +0100, Marek Vasut wrote: >>>>>>> >>>>>>>> Fix the following spit from pytest: >>>>>>>> >>>>>>>> u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly. >>>>>>>> Please use node.get_closest_marker(name) or node.iter_markers(name). >>>>>>>> Docs: https://docs.pytest.org/en/latest/mark.html#updating-code >>>>>>>> for board in mark.args: >>>>>>>> >>>>>>>> In both cases, the later suggestion is applicable. >>>>>>>> >>>>>>>> Signed-off-by: Marek Vasut >>>>>>>> Cc: Igor Opaniuk >>>>>>>> Cc: Tom Rini >>>>>>>> Cc: Simon Glass >>>>>>> >>>>>>> Deferred, for now we don't support newer pytest than 2.8.7 and you'll >>>>>>> need to use virtualenv to set that up if needed. There is not, AFAICT, >>>>>>> a way to support both versions. >>>>>> >>>>>> That's what's in debian testing though, so maybe we need to support it >>>>>> somehow. >>>>> >>>>> Yes, I'm _very_ frustrated at the speed at which pytest went from "this >>>>> is the API" to "this API is deprecated" to "this API doesn't work and >>>>> here's the new, incompatible API". Debian/testing needs to use >>>>> virtualenv to setup a python area with older pytest installed, just like >>>>> we do in .travis.yml. >>>> >>>> Can't we rather have people use the new APIs and virtualenv new python? >>> >>> Not as easily, no. Debian/testing may have something much newer but >>> Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand >>> but it's probably inbetween and so on. >> >> While I'm not a python expert, shouldn't virtualenv help with that ? > > Yes, and breaking old setups is usually frowned upon and making new > setups conform to the existing ways is how things are usually done. If you use venv with old setup, won't that give you the new python you need ? -- Best regards, Marek Vasut